From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2055.outbound.protection.outlook.com [40.107.7.55]) by sourceware.org (Postfix) with ESMTPS id 9362D3858D28 for ; Wed, 3 May 2023 08:42:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9362D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ceq4TNjeXh//XgMgrOCr6fUwKmHsMsQB8Y9FpE4cS60=; b=4slAVjdXtFKRTgxEDJQxfhjXD7n8bJF+in5/R9LmsLRvuywFBCwp73wBJzEnS3zeE4djJ2s5OelqnYe43xldcYw86Rb6dWwu1fr89NpfkBP7GntRQe6yU/ih0PFxcfpSccPBepeFtGTdD6VuT2OoRdoGM/KlwqO6ODEj8MXmoIQ= Received: from DB8P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::35) by PAVPR08MB9627.eurprd08.prod.outlook.com (2603:10a6:102:31b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 08:42:55 +0000 Received: from DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::e1) by DB8P191CA0025.outlook.office365.com (2603:10a6:10:130::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21 via Frontend Transport; Wed, 3 May 2023 08:42:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT059.mail.protection.outlook.com (100.127.142.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.19 via Frontend Transport; Wed, 3 May 2023 08:42:55 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Wed, 03 May 2023 08:42:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dce330ae9f3d412f X-CR-MTA-TID: 64aa7808 Received: from 23676f2d075e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 69E5731F-96C7-41C4-9655-F06D68491354.1; Wed, 03 May 2023 08:42:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 23676f2d075e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 May 2023 08:42:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTJ3+MaBhS4GFVil5+5r2XVzeuqXsL+LDoDWREKFMA8ILkwrIu7xFGFT0AKuEpInGwlMQaLkJg2nzhYDsYDkyys6gb0f+BkevXY88j53nbDZw+VFmSek2LIDSAWL0d7gypu6dfd0d4+zeFUUPOsnRm5TvFbjnftWZ09CA4wfzh2U49rTINI6NoMDe3HJ8Xj4SBs+WBgpt+Pv9YuUbbLjn5bcWLExpYO67PQYouCQyqEwHI2vNp5g1Z5g/swR6OjNRpA97r3shSGMD+HXVoer19T2jn003Z/Qrt7myYDcQTyofbKcUQm1HlUIcRx034roH/Jm+PDUwl/sCSLVRtVLzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ceq4TNjeXh//XgMgrOCr6fUwKmHsMsQB8Y9FpE4cS60=; b=kQzvaQYi3ikFdgOzA3JJ65puyYCwpS+0YqxQDQy5p7mUdx5gbUU1H0+YccqGHpe3uUkqV+C0m6PJY7DBvWYrpRn4LswnWulHQlRDzk/sAmaWZM+xwf1VoYANCyBP5kCPfOZI1kGcI295ZTzF75cCgPPvjHSJ4/ywNGfU9w+tbp/wuUPC0h6tyJSQrCPVYZPAous/XDIhBTW1a5l+AFNas2+3kA+vJMPEZ1bz+Ykp7f7/Vr54CUCNrBiC5RDj0j6Now0ze9eEt6A1Z4E5BvjqL2GoLHMKn5SkvcH5U5BWY46uEMnHSSAstlyZWQQ3Mfay9FlmFnuQlRnYr6YWeTMEUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ceq4TNjeXh//XgMgrOCr6fUwKmHsMsQB8Y9FpE4cS60=; b=4slAVjdXtFKRTgxEDJQxfhjXD7n8bJF+in5/R9LmsLRvuywFBCwp73wBJzEnS3zeE4djJ2s5OelqnYe43xldcYw86Rb6dWwu1fr89NpfkBP7GntRQe6yU/ih0PFxcfpSccPBepeFtGTdD6VuT2OoRdoGM/KlwqO6ODEj8MXmoIQ= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by DB9PR08MB9801.eurprd08.prod.outlook.com (2603:10a6:10:462::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 08:42:47 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1%3]) with mapi id 15.20.6363.022; Wed, 3 May 2023 08:42:47 +0000 From: Kyrylo Tkachov To: Christophe Lyon , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford CC: Christophe Lyon Subject: RE: [PATCH 16/22] arm: [MVE intrinsics] factorize vcreateq Thread-Topic: [PATCH 16/22] arm: [MVE intrinsics] factorize vcreateq Thread-Index: AQHZcfxUcUPgWb93A0qn4jm7jD8aXa9IUipw Date: Wed, 3 May 2023 08:42:47 +0000 Message-ID: References: <20230418134608.244751-1-christophe.lyon@arm.com> <20230418134608.244751-17-christophe.lyon@arm.com> In-Reply-To: <20230418134608.244751-17-christophe.lyon@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|DB9PR08MB9801:EE_|DBAEUR03FT059:EE_|PAVPR08MB9627:EE_ X-MS-Office365-Filtering-Correlation-Id: f0bbc5f4-c934-4aef-f5fc-08db4bb26402 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1IluY0KTZF2aD0RWFwK0Y4LGQKmuDijYuxWk2+oCW/2fX0SkgCJlO2MWfzCAvNEhY9Ni7/QovmFrdEMtvHHiQ0cGSo0L1S8fZBMPeIOBwqpweQrzcly32AkeA6Nwt4Xlb/VOVsc45NOOuOBW+O7tLgUtSdv69hCgoJekQgc3H3aZWpRMca68XuFRdOZqTznLsl2HFGbIY+HmRicqHP42hZUHu+ykIAIThqBXgQCoiH7rkF23YdrnvLIfSZk1MNA3dtvWPAGTxtEjb5DQx6Ibkhx8h84tbnzXMHRdaXoenFd1M2txx9zU33jJRAWKjqkkGR2Qu+Ylb8uOmvQ3tl3ju0T/U7Caegr2GaPLUw0U2DTm64KoLPeWanzfH0dYbDVo3RZY2Xfr4qv6BE/m/K2cVtc0NlVL9jq4U4RJmzwFxngkTI94T1kq4nis7ud+TZxl056P72+L5N0s/6j+MywVV/wnA6VhbNt7OVrvv+GarjLbgUevLtMEaWUzPWiEdwOfoMNEKI135SKUmf2zUjVHeEtQ2BQavb43c4FeMr98ezssowZ94ZfdH+vEKdRdm/qc0onPcj6N25jfWwjAotstFlK9UidAuJ7hjnSkZVg0lX2tD+1SCAJu4+dqq89oWQaj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199021)(9686003)(53546011)(26005)(6506007)(6636002)(4326008)(76116006)(33656002)(64756008)(66556008)(66446008)(66476007)(66946007)(478600001)(83380400001)(86362001)(71200400001)(316002)(38070700005)(38100700002)(41300700001)(122000001)(2906002)(55016003)(7696005)(186003)(8936002)(110136005)(5660300002)(52536014)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9801 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2c324429-f20b-4d1a-9c66-08db4bb25f04 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qO2T/apiL36tv28aqU64whsDzti4KMeM1dDLG38Df0zi6cIiqEqGCKZIkAxMzsxhbwGMpkoB7QzGXWO8BqTVqgoLeR3wzFwDYzhSSQFO6yG7YJraHl/RmCPYPPiVANIBaurwsCoK4K/HHAt7p8NzYknz4eak/BqfmLL/VhTbcpPr7wuroyElXt67Ea7P7PgEW4nwyrgbFgx25q9lmHYVyulApko1rWOHR9JM8oco2LV0nsRCxXFZtTHuvpZynEVZyjPriTOronmPZ/U3Ih0i4JhmL2lH4iUavXR9eajh43YO9c3bgwGs4/GQluP060DX6ma/i8dY2H0e4KWywkZtQSxdNBy+7FyPzGbQtbJj4vPEEEdfaP4FiRY+XIcXyUidq/JRnQKuQdaO4bdhDTaBDJXOS0saP25eaBhMbBZd2wSPoGipIA1dKTDJ+XCaEbpD6oilPAOElgThhaxwxIvB5lHXxPTsXb0f1oghTpvOmkcY1TSI9er30njujXGscyCyw9mFZ8MNAeutxla7SD4g6ou38oXhRDchqxRRDLGlzAFoHftfQfqYBzp5RP74Df6XSoiSPWA3M5JU1JNmkImYvc9wZRf2+JV+Ndn40ANL+WjI2syWsiN5rbF8inCkuN+4DJym68UXljvWWTTUaaZWpl2gfz1RyWd5X0Lv5UKkQ1pQDFbIowhe/6IfrU9+k6hfKFvYlPik/Y4TCdbAcqffkXr7xZ6ODpKEZgDJEEjDIwo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(55016003)(40480700001)(40460700003)(110136005)(6636002)(4326008)(70586007)(478600001)(70206006)(8676002)(316002)(7696005)(8936002)(81166007)(52536014)(41300700001)(82740400003)(5660300002)(356005)(186003)(36860700001)(336012)(47076005)(83380400001)(6506007)(34020700004)(9686003)(26005)(53546011)(86362001)(33656002)(82310400005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 08:42:55.7078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0bbc5f4-c934-4aef-f5fc-08db4bb26402 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9627 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Christophe Lyon > Sent: Tuesday, April 18, 2023 2:46 PM > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > Richard Earnshaw ; Richard Sandiford > > Cc: Christophe Lyon > Subject: [PATCH 16/22] arm: [MVE intrinsics] factorize vcreateq >=20 > We need a 'fake' iterator to be able to use mve_insn for vcreateq_f. >=20 > 2022-09-08 Christophe Lyon >=20 > gcc/ > * config/arm/iterators.md (MVE_FP_CREATE): New. > (mve_insn): Add VCREATEQ_S, VCREATEQ_U, VCREATEQ_F. > * config/arm/mve.md (mve_vcreateq_f): Rename into ... > (@mve_q_f): ... this. > (mve_vcreateq_): Rename into ... > (@mve_q_): ... this. > --- > gcc/config/arm/iterators.md | 5 +++++ > gcc/config/arm/mve.md | 6 +++--- > 2 files changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/gcc/config/arm/iterators.md b/gcc/config/arm/iterators.md > index b0ea1af77d2..5a531d77a33 100644 > --- a/gcc/config/arm/iterators.md > +++ b/gcc/config/arm/iterators.md > @@ -393,6 +393,10 @@ (define_int_iterator MVE_FP_N_BINARY [ > VSUBQ_N_F > ]) >=20 > +(define_int_iterator MVE_FP_CREATE [ > + VCREATEQ_F > + ]) I believe in similar cases in the aarch64 port we used the convention "ONLY= ", so something like VCREATEQ_F_ONLY. Ok with that change. Thanks, Kyrill > + > (define_code_attr mve_addsubmul [ > (minus "vsub") > (mult "vmul") > @@ -407,6 +411,7 @@ (define_int_attr mve_insn [ > (VBICQ_M_N_S "vbic") (VBICQ_M_N_U "vbic") > (VBICQ_M_S "vbic") (VBICQ_M_U "vbic") (VBICQ_M_F > "vbic") > (VBICQ_N_S "vbic") (VBICQ_N_U "vbic") > + (VCREATEQ_S "vcreate") (VCREATEQ_U "vcreate") > (VCREATEQ_F "vcreate") > (VEORQ_M_S "veor") (VEORQ_M_U "veor") (VEORQ_M_F > "veor") > (VMULQ_M_N_S "vmul") (VMULQ_M_N_U "vmul") > (VMULQ_M_N_F "vmul") > (VMULQ_M_S "vmul") (VMULQ_M_U "vmul") (VMULQ_M_F > "vmul") > diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md > index fbae1d3791f..f7f0ba65251 100644 > --- a/gcc/config/arm/mve.md > +++ b/gcc/config/arm/mve.md > @@ -700,12 +700,12 @@ (define_insn "mve_vcvtq_n_to_f_" >=20 > ;; [vcreateq_f]) > ;; > -(define_insn "mve_vcreateq_f" > +(define_insn "@mve_q_f" > [ > (set (match_operand:MVE_0 0 "s_register_operand" "=3Dw") > (unspec:MVE_0 [(match_operand:DI 1 "s_register_operand" "r") > (match_operand:DI 2 "s_register_operand" "r")] > - VCREATEQ_F)) > + MVE_FP_CREATE)) > ] > "TARGET_HAVE_MVE && TARGET_HAVE_MVE_FLOAT" > "vmov %q0[2], %q0[0], %Q1, %Q2\;vmov %q0[3], %q0[1], %R1, %R2" > @@ -715,7 +715,7 @@ (define_insn "mve_vcreateq_f" > ;; > ;; [vcreateq_u, vcreateq_s]) > ;; > -(define_insn "mve_vcreateq_" > +(define_insn "@mve_q_" > [ > (set (match_operand:MVE_1 0 "s_register_operand" "=3Dw") > (unspec:MVE_1 [(match_operand:DI 1 "s_register_operand" "r") > -- > 2.34.1