From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2079.outbound.protection.outlook.com [40.107.241.79]) by sourceware.org (Postfix) with ESMTPS id 5047D3858C54 for ; Fri, 12 May 2023 10:17:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5047D3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TyrW4yEX8ra617mcqwnuDRcv6FraPQXEQYPaQ19P3o8=; b=v04Hexh17gf/+T+CB+LjAPa1r1X0XFHVpUW7Vh4hBQwzPWhv5fN3Vg+Qgs/X0sUB0zGS12wFLx8TW+NLryVEEWFLAIPwWJSSYvbz5mLE9fbUoucwC/jlw2xXumuzOueAceM4ZNN+QCi+o9d6faHGyv6lHbOVNDmMHjljdUxxHmA= Received: from AM6P192CA0076.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::17) by DU0PR08MB9581.eurprd08.prod.outlook.com (2603:10a6:10:44b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.23; Fri, 12 May 2023 10:17:24 +0000 Received: from AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::d) by AM6P192CA0076.outlook.office365.com (2603:10a6:209:8d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.24 via Frontend Transport; Fri, 12 May 2023 10:17:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT038.mail.protection.outlook.com (100.127.140.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.23 via Frontend Transport; Fri, 12 May 2023 10:17:24 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Fri, 12 May 2023 10:17:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d54ad57e634c58ee X-CR-MTA-TID: 64aa7808 Received: from 012b418db7a6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 900C7786-E09B-47D0-8E02-3573B5889A16.1; Fri, 12 May 2023 10:17:13 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 012b418db7a6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 May 2023 10:17:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0pEef+Qz/7LQaTD8DKgbQOT1YzRR9XPChcBW+FqeYd1BmZ8STyG4SxMGIxFD4db/MdkjyMDc0+daFrqUcv3M5QKEakGXb6w61I/r6oBqB6z9wCt+uSDEDcYv/dnuTy/wVHI6ApndAFqhggu0WnmfZDC4L/1sGxSnZbl3+rYJCMMc3uoUnigqmIDBJtisgQ/0XYZbH+cJB9axMNQHMEBAsh+3HhL2l9xoyymAr/DiMb4/iv6g1P+pgzsfOAQswzR4amiIMHGipDzOdFQEQIWg2X1F12wfZEujJQ8N1ImFVum40rDpfVVd9+qEnQticqJnIdao2iqyLzDq5Sn1WNnlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TyrW4yEX8ra617mcqwnuDRcv6FraPQXEQYPaQ19P3o8=; b=AeTN3nEP0QHU6JZmdUoXMl0+kTqrPA7wYevJi7dBBe011ToCCMIXnZUI0rFakreWgElsDgsbpAfbVf7hVrgVxR54j0q7rPZR8e9c3efzQfIi9wT06///xfmeJyj2Y4EXSu8A82NRbhKQKOiBbIaQmiXYFHTLfTelFXp41tHMCNfJgyQkZWdLjoEdChvAGnw2hjd79fLVmg9uZgIPYZkpBOLCETh4MHknN4l7jcrjDuuSzcAayXWNTEYbzc7LO+3Y+Rkp3lmvZbsfyYvAcjZrNEzaiUz+4o1at+d/4aW+zvPSZ7e9UepcQHDXBsIC8mDxB+cW+vwl+Z8kCtetYIFazQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TyrW4yEX8ra617mcqwnuDRcv6FraPQXEQYPaQ19P3o8=; b=v04Hexh17gf/+T+CB+LjAPa1r1X0XFHVpUW7Vh4hBQwzPWhv5fN3Vg+Qgs/X0sUB0zGS12wFLx8TW+NLryVEEWFLAIPwWJSSYvbz5mLE9fbUoucwC/jlw2xXumuzOueAceM4ZNN+QCi+o9d6faHGyv6lHbOVNDmMHjljdUxxHmA= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by AS2PR08MB9499.eurprd08.prod.outlook.com (2603:10a6:20b:60d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.23; Fri, 12 May 2023 10:17:10 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1%3]) with mapi id 15.20.6387.023; Fri, 12 May 2023 10:17:09 +0000 From: Kyrylo Tkachov To: Christophe Lyon , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford CC: Christophe Lyon Subject: RE: [PATCH 01/26] arm: [MVE intrinsics] add binary_widen_opt_n shape Thread-Topic: [PATCH 01/26] arm: [MVE intrinsics] add binary_widen_opt_n shape Thread-Index: AQHZhLWYQS/H2eAcWUCf3EJM4fV4sa9WbDmQ Date: Fri, 12 May 2023 10:17:09 +0000 Message-ID: References: <20230512093855.79529-1-christophe.lyon@arm.com> In-Reply-To: <20230512093855.79529-1-christophe.lyon@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|AS2PR08MB9499:EE_|AM7EUR03FT038:EE_|DU0PR08MB9581:EE_ X-MS-Office365-Filtering-Correlation-Id: ef5ef677-c336-41e6-3208-08db52d214d0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 05Z/zDSrHoQWIJ0KnwKX377teKofOiBtrpsObZXxujWODcsz2TJpTTpXsCP9HhMqFBxDRxztqOCzghD6SGoU2ynog5BZ7NM0PfQZ9XBiNzzIMi+Nie/ZS+p5lgXGdylKcaLrlYocBSBRyhgMsbKLE0gVTiHi5fCb/0mITUmzXTuzyoh3DhYgFO+x8nmyzPxEXj/l7tw0h+j7zDnyDaVhdSA17LYzqAD8DnRksi9lP6TqlNtghDR+izp4CK88AUmbc+vV3OWbVtga4PtapAXkatAax80N1AuhxihABiWaFFD+Iyug0TOFC22raz3QD/XtH1xgeD1bNDBveguYCrBWEhKZZjHht6aUqidgLY6yDoMjNc81YR49IKDx/XvOxIintDbFKNA+qvxnQVWdykXqbTNDUdiyTYqhPUq2CfTKuDy+irpfdoOCiXrrRXxV18iep5jTcSHUpQpajezzWxeksPp3Ugb/tbjTukU9y7qArM/QqQWukhQ0sQsgDS7BKyN/VqtfuEf/Sb+goXgLHXTU5uLE3FtO9jbBjwvMGccl91KJC5M+lmzSaXVRH1rCIYM2NnopNoh7fahr6vHYLwKvgRMxCkr8j3ZFexynv3we+1VGErDJ+RTJ0p8BDodLqLHV X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199021)(186003)(55016003)(66946007)(478600001)(86362001)(110136005)(38100700002)(71200400001)(33656002)(7696005)(122000001)(4001150100001)(5660300002)(52536014)(2906002)(8936002)(8676002)(66446008)(76116006)(66476007)(64756008)(66556008)(38070700005)(6636002)(41300700001)(4326008)(316002)(9686003)(53546011)(6506007)(26005)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9499 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0694dd1e-f990-425e-0a5b-08db52d20bd2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4ZgidKqCv2S1tOvkvWAXGSbuDaxCrt7la8A2ybaHg4H+UqMZDvDZ/OdEllvLSQJh+yRxjCJRtxbdbx15G0Q/eRXqMt08eSmqITK3YA+L2GnKoIxtZtAzphg2at0VCi/J7NMZK5kK0SJ6KssrQIaJEMXS8DEPgl6CZoqRRJNC1ZBzO9E81qQQnTnSmdAN2rXRW/n1s+srGxPn9YXZHL7iIbccunLA9Ee9+omkt3dNdVDhIuZWpILPOPPpqF9X+corpnPMmCGMpz0TWp6UbvzNrOAPVwlx0kDn9tCWn+JqnBncQJCRh0kClgvJj7+dWTc4XoAmWECrDmEOftMkPCcDPS0iEkiT+DDrZI0wwLIq+65j2YfKm0T2BOF8A6W1HZI7YzzvH/tooUPwjX3WYFxrfOmImhoRGproA4SURVWxOCvlw+TFBiK5NT0giHAKUzpIDspiqyhNa354qb45PuZDFK2NNGg1oaN4IegXT7OmDNsaCJCqiTUdvqEcKVaBQKu/iZqGzL3knt5Ff/LopUcvKMAYKz7KziSLzTIltgUrPnUPRgE4kbyTBUFM+wNXXfDDyDO3CLdTJY8+gDDna4Wyxr2beohbs6/PhcyjMsFWiigAOZchFuH6UJxoIg8edTj+TOk0A0tn2r393VU67esIrVUnvzLlrldKX4aXYsU6VaM9CctxTx02cPxrPo+gVIhFTpFqNxNH5/YvFwSP9BsKMIK4a8uI4G7MArfRXYNoBhgvg6Tftz8LJ61XX4V1w14Z X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199021)(36840700001)(46966006)(40470700004)(55016003)(186003)(40480700001)(40460700003)(478600001)(86362001)(82310400005)(110136005)(7696005)(33656002)(2906002)(4001150100001)(5660300002)(52536014)(8676002)(8936002)(70206006)(6636002)(70586007)(4326008)(82740400003)(356005)(81166007)(41300700001)(316002)(53546011)(9686003)(6506007)(26005)(83380400001)(36860700001)(336012)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 10:17:24.7136 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef5ef677-c336-41e6-3208-08db52d214d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9581 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Christophe Lyon > Sent: Friday, May 12, 2023 10:39 AM > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > Richard Earnshaw ; Richard Sandiford > > Cc: Christophe Lyon > Subject: [PATCH 01/26] arm: [MVE intrinsics] add binary_widen_opt_n shape >=20 > This patch adds the binary_widen_opt_n shape description. This series is ok with one style nit fixed in this first patch... >=20 > 2022-12-12 Christophe Lyon >=20 > gcc/ > * config/arm/arm-mve-builtins-shapes.cc (binary_widen_opt_n): > New. > * config/arm/arm-mve-builtins-shapes.h (binary_widen_opt_n): New. > --- > gcc/config/arm/arm-mve-builtins-shapes.cc | 49 +++++++++++++++++++++++ > gcc/config/arm/arm-mve-builtins-shapes.h | 1 + > 2 files changed, 50 insertions(+) >=20 > diff --git a/gcc/config/arm/arm-mve-builtins-shapes.cc b/gcc/config/arm/a= rm- > mve-builtins-shapes.cc > index 5a299a272f5..ee4bc3f8ea4 100644 > --- a/gcc/config/arm/arm-mve-builtins-shapes.cc > +++ b/gcc/config/arm/arm-mve-builtins-shapes.cc > @@ -1098,6 +1098,55 @@ struct binary_widen_n_def : public > overloaded_base<0> > }; > SHAPE (binary_widen_n) >=20 > +/* _t vfoo[_t0](_t, _t) > + _t vfoo[_n_t0](_t, _t) > + > + Example: vqdmullbq. > + int32x4_t [__arm_]vqdmulltq[_n_s16](int16x8_t a, int16_t b) > + int32x4_t [__arm_]vqdmulltq_m[_n_s16](int32x4_t inactive, int16x8_t a= , > int16_t b, mve_pred16_t p) > + int32x4_t [__arm_]vqdmulltq[_s16](int16x8_t a, int16x8_t b) > + int32x4_t [__arm_]vqdmulltq_m[_s16](int32x4_t inactive, int16x8_t a, > int16x8_t b, mve_pred16_t p) */ > +struct binary_widen_opt_n_def : public overloaded_base<0> > +{ > + void > + build (function_builder &b, const function_group_info &group, > + bool preserve_user_namespace) const override > + { > + b.add_overloaded_functions (group, MODE_none, > preserve_user_namespace); > + build_all (b, "vw0,v0,v0", group, MODE_none, > preserve_user_namespace); > + build_all (b, "vw0,v0,s0", group, MODE_n, preserve_user_namespace); > + } > + > + tree > + resolve (function_resolver &r) const override > + { > + unsigned int i, nargs; > + type_suffix_index type; > + if (!r.check_gp_argument (2, i, nargs) > + || (type =3D r.infer_vector_type (i - 1)) =3D=3D NUM_TYPE_SUFFIXES) > + return error_mark_node; > + > + type_suffix_index wide_suffix > + =3D find_type_suffix (type_suffixes[type].tclass, > + type_suffixes[type].element_bits * 2); > + > + /* Skip last argument, may be scalar, will be checked below by > + finish_opt_n_resolution. */ > + unsigned int last_arg =3D i--; > + for (; i > 0; i--) > + if (!r.require_matching_vector_type (i, type)) > + return error_mark_node; > + > + /* Check the inactive argument has the wide type. */ > + if ((r.pred =3D=3D PRED_m) > + && (r.infer_vector_type (0) !=3D wide_suffix)) > + return r.report_no_such_form (type); Indentation is off here I think. Thanks, Kyrill > + > + return r.finish_opt_n_resolution (last_arg, 0, type); > + } > +}; > +SHAPE (binary_widen_opt_n) > + > /* Shape for comparison operations that operate on > uniform types. >=20 > diff --git a/gcc/config/arm/arm-mve-builtins-shapes.h b/gcc/config/arm/ar= m- > mve-builtins-shapes.h > index a28cd6a1547..07b12b4af68 100644 > --- a/gcc/config/arm/arm-mve-builtins-shapes.h > +++ b/gcc/config/arm/arm-mve-builtins-shapes.h > @@ -53,6 +53,7 @@ namespace arm_mve > extern const function_shape *const binary_rshift_narrow; > extern const function_shape *const binary_rshift_narrow_unsigned; > extern const function_shape *const binary_widen_n; > + extern const function_shape *const binary_widen_opt_n; > extern const function_shape *const cmp; > extern const function_shape *const create; > extern const function_shape *const inherent; > -- > 2.34.1