From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Subject: RE: [ARM] PR66791: Replace builtins in vld1
Date: Thu, 29 Jul 2021 14:49:36 +0000 [thread overview]
Message-ID: <PAXPR08MB692683F0006830B3BEF311F193EB9@PAXPR08MB6926.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAAgBjMncARWW-c6TVLJqNweTex8C28TFvTV=gzk7Ksjzq7jC0g@mail.gmail.com>
> -----Original Message-----
> From: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
> Sent: 29 July 2021 15:45
> To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> Cc: gcc Patches <gcc-patches@gcc.gnu.org>; Richard Earnshaw
> <Richard.Earnshaw@foss.arm.com>
> Subject: Re: [ARM] PR66791: Replace builtins in vld1
>
> On Thu, 29 Jul 2021 at 14:57, Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> wrote:
> >
> > Hi Prathamesh,
> >
> > > -----Original Message-----
> > > From: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
> > > Sent: 26 July 2021 22:24
> > > To: gcc Patches <gcc-patches@gcc.gnu.org>; Kyrylo Tkachov
> > > <Kyrylo.Tkachov@arm.com>; Richard Earnshaw
> > > <Richard.Earnshaw@foss.arm.com>
> > > Subject: [ARM] PR66791: Replace builtins in vld1
> > >
> > > Hi,
> > > Similar to aarch64, this patch replaces call to builtin by
> > > dereferencing __a in vld1_p64, vld1_s64 and vld1_u64.
> > >
> > > The patch changes code-gen for the intrinsic as follows:
> > > Before patch:
> > > vld1.64 {d16}, [r0:64]
> > > vmov r0, r1, d16 @ int
> > > bx lr
> > >
> > > After patch:
> > > ldrd r0, [r0]
> > > bx lr
> > >
> > > I assume the code-gen after patch is correct, since it loads two
> > > consecutive words from [r0] into r0 and r1 ?
> >
> > Yes, this looks correct.
> >
> > >
> > > Bootstrapped+tested on arm-linux-gnueabihf.
> > > OK to commit ?
> >
> > Ok. Can we now remove the vld1 builtin definition?
> Does the attached patch look OK ?
> I suppose we can only remove entry for di since the patch replaces
> calls to only __builtin_neon_vld1di ?
Yeah, we can just remove the DI entry.
Ok if this passes the usual testing.
Thanks,
Kyrill
>
> Thanks,
> Prathamesh
> > Thanks,
> > Kyrill
> >
> > >
> > > Thanks,
> > > Prathamesh
prev parent reply other threads:[~2021-07-29 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 21:24 Prathamesh Kulkarni
2021-07-29 9:27 ` Kyrylo Tkachov
2021-07-29 14:45 ` Prathamesh Kulkarni
2021-07-29 14:49 ` Kyrylo Tkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR08MB692683F0006830B3BEF311F193EB9@PAXPR08MB6926.eurprd08.prod.outlook.com \
--to=kyrylo.tkachov@arm.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=prathamesh.kulkarni@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).