From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) by sourceware.org (Postfix) with ESMTPS id 0C3B83858D20 for ; Mon, 12 Jun 2023 10:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C3B83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z32n01cXvKNK8G6qGQw6oJZahpctd5sZSPDU86e/7DE=; b=r6Qv3T1FSWVlwEpBgTkUqEhZZx4BsRQY6cckHlhly6oSPQZ+0QIc7M0yKYqzuZ7hNg3mBeNOxp+LEzWlHxFoC5yKP+9Q0d2p0jwqVknVpVWXzMLU9CuSs97eOR8FnUYoaQH5U65QDZgCtsYRnoeEfFMRQ5N5ujpTt7ENi46Fmks= Received: from FR3P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::11) by AS8PR08MB7717.eurprd08.prod.outlook.com (2603:10a6:20b:525::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.39; Mon, 12 Jun 2023 10:45:37 +0000 Received: from VI1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1c:cafe::d6) by FR3P281CA0021.outlook.office365.com (2603:10a6:d10:1c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.21 via Frontend Transport; Mon, 12 Jun 2023 10:45:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT033.mail.protection.outlook.com (100.127.144.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.21 via Frontend Transport; Mon, 12 Jun 2023 10:45:37 +0000 Received: ("Tessian outbound 5bb4c51d5a1f:v136"); Mon, 12 Jun 2023 10:45:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c84f03d3eb5f1b4 X-CR-MTA-TID: 64aa7808 Received: from d285a2aa1473.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4A23DAEB-43AC-4413-AC67-B151443C1A60.1; Mon, 12 Jun 2023 10:45:23 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d285a2aa1473.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 12 Jun 2023 10:45:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MC7sZ9gG8OJF7NzVIfvvLPiakLeJKlenHoR4FIngwuI5xLCLGU8iHTTy5H1FVpFVHHrD9q2IBJdr0wY5tApVt+wgvOaZG+AsnlsOgqoopqDcWUVlyyuDcvZ0AUVGFX3wAWe7BAgUQAJuN+NFY7PVqgrLkiA4sA/kvBA9xv7q5JAo8UADhuyPC5Qj1q31PMSVB2hVye4lytNibOXlGghomTqeY/hr9HVkNODDG00aicLExudnHktHeA+2Uy7NjKmGZ/JoR+YgKQZWwQY+0YSRfCZEZO23T90Pjj019/QouI0yeKUYakDnqKyMhXQ3DTjoHHlrxhURgyuEPz4KBbYPSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z32n01cXvKNK8G6qGQw6oJZahpctd5sZSPDU86e/7DE=; b=XTmTHyIryzXL/nz9WUVAdV++bztm3Fo/+ZrundKmLsiFAuWYB/Qz/26oZU2k46k1CJ47tqFekPtsp/ij6+Iw83ooidpTSCXqUdzqTsfU2IXsT17EDHo/Y1Tc+/nGlGoSBAaPGMJfngSkyKN2zmn07CZTzq77hcMFKNnpTD7VPD/QN8W+GXHS+4nGjXGIunxciK8gATFZ2YUUMWO74tsPreyuZk0i/q6spTteouMDb/xfN0BijO1PjwrfhokPhYxyxUR3Shu2R2CpfXKmlaJpaQeRZlbU7KsI1TUj0X0eW9DUBvYPkDcCVa4dwI9G/c1RT7Qr+J3MB95LP7s8Tllj0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z32n01cXvKNK8G6qGQw6oJZahpctd5sZSPDU86e/7DE=; b=r6Qv3T1FSWVlwEpBgTkUqEhZZx4BsRQY6cckHlhly6oSPQZ+0QIc7M0yKYqzuZ7hNg3mBeNOxp+LEzWlHxFoC5yKP+9Q0d2p0jwqVknVpVWXzMLU9CuSs97eOR8FnUYoaQH5U65QDZgCtsYRnoeEfFMRQ5N5ujpTt7ENi46Fmks= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Mon, 12 Jun 2023 10:45:21 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::2978:61ca:4677:30f8]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::2978:61ca:4677:30f8%5]) with mapi id 15.20.6477.028; Mon, 12 Jun 2023 10:45:21 +0000 From: Kyrylo Tkachov To: Richard Sandiford , Kyrylo Tkachov via Gcc-patches Subject: RE: [PATCH] simplify-rtx: Implement constant folding of SS_TRUNCATE, US_TRUNCATE Thread-Topic: [PATCH] simplify-rtx: Implement constant folding of SS_TRUNCATE, US_TRUNCATE Thread-Index: AdmaGWalzyEIbVKZRB+iDqhvZTnU+QA4/lmeAIdWZGA= Date: Mon, 12 Jun 2023 10:45:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|VE1PR08MB5696:EE_|VI1EUR03FT033:EE_|AS8PR08MB7717:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e842639-b46d-48ca-217c-08db6b322889 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kvEifsenGJRuN4FJhCq5oyBa6v2RAHA748Lf9aSKborQGz7mjQMZuDBjmm4CWJxqz6FE57evh7L4WDyAmnRtu39KeIZ1CQPJE2x+mnvr2tE5nrteL4SAp2Q/llYbpxAsPoqXhF0cnM/SzpyvSqz5ZZqCKI4Bg6k5qA0N7s0TxqzizJw5zADHqEM1fOFDFSmp/knK21MD8Ml+QqKt+NOdgYChdUMrtA2AW/eT9OR6QsMHYUDC7h+kNojLD9Z39vU2p/xI5bBTLinGUb1yCewOFKocEi8ZCL0qKNhplBjGCJQiux1J1zx2ZfT5lvdXYhtMVJeSknUxbuaPKU0NkvetGKC6B6CCGLjG6tewdl5W5aqeVXgebfBIFmJTdhoeUL3S/HvYs20YdSewcltf/1/ebcSiKdDsBLnEduYudbkPRt+6dhphb+4P9pNIUzA5pEJtRYURzDBzKqrCFXzyJWVL+6hDAOjp/gzuP+VdEyGZk/ahL9WGPK8BC6Zm8+LhO7GY3DXrrlCMUFPqoqdh34QondSou8tW/cv/LtZez/oRRYwFTxCgLlXXwCyCfUcokNsn1st1cUMJbapkv0baof4fJXLqONO3KE+LJ8BvQlJx9ZYDLSpc//Bn65N7EL87R9EF X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(39850400004)(136003)(376002)(346002)(451199021)(316002)(7696005)(41300700001)(2906002)(83380400001)(86362001)(53546011)(9686003)(26005)(6506007)(186003)(38070700005)(33656002)(99936003)(122000001)(38100700002)(55016003)(5660300002)(52536014)(8936002)(8676002)(110136005)(66476007)(66446008)(64756008)(76116006)(66556008)(66946007)(71200400001)(478600001);DIR:OUT;SFP:1101; Content-Type: multipart/mixed; boundary="_002_PAXPR08MB69268DE5D98F7A39A67F74FA9354APAXPR08MB6926eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5696 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 348161e9-31e2-4222-d3e6-08db6b321f10 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qts30EM6DrgpN8BZZzOlCYVNE9mN0yuEu8Tmp7k7lrGTxv6rHBKEupSRMw/zwYO6+AGEEUW6WLduDArHowqAM/N4hGhkoJyR6WRL9IIrFK+ehdueHrBYWNnCq1LYj2odlBdUELkeHW/vy/OS4wPNF+I2Q1aYyY5eKoSfonvfu4stzdsbDZVMi0R1O8H7upe8QwtzUREXSZ6A4qhLxbH8qohQi46G2TQBZTcs9c7VYJY5jijpkjbVJDQfcJJi0UpkxxM1oU3aXL4f4PNodnS9/FlBiBFtyDN7MzZdmPznbfpjNxJktqKCQ0seYyjru45m2NWjp3Mb+tp/EnNb5k7GkMxg2bpMeorLMII3duw6RY89lFu2XX4LbHSO5Ztb/NthQ7Hz1gqEzp96Yt0WxX34Ol43YMeePsoty96iThGzr9NatkHVjk7/Yg/I4JYR/8ORvs+TLQHRbpJ/WTKDLphTeE979V0gW8WniAc0rjUI1InwGxdtxS4EdDFov5gh4Jd2bCRTXeqE/AxIEq/gs7Mfs1b71nvYqxGwL95TGzNm/5M9k53+g5IGurb2QPNx4qn0otDMcCzvfnJ5REV3yFATQpGa3pVtvSGyYvFbSEXSSCnqCUuJhYBQvdxtTU5L8lJx9tEAoYXd9Y1FVNwCZB5wbsgI2hXwOlALSwtPSb0AxV4mBmJC1r4bzZ8Lh2cMfsKs9i1hwG2ZbF130kv8c+3wvbhvyeSEK3V+RjSes0nftYtpZnHHIDi7NvZyFTUkNzF2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(39860400002)(396003)(376002)(451199021)(36840700001)(40470700004)(46966006)(478600001)(82740400003)(81166007)(70586007)(356005)(70206006)(110136005)(8936002)(86362001)(55016003)(33656002)(99936003)(5660300002)(235185007)(52536014)(8676002)(2906002)(41300700001)(40480700001)(316002)(40460700003)(83380400001)(336012)(47076005)(26005)(53546011)(6506007)(9686003)(186003)(7696005)(36860700001)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 10:45:37.4732 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e842639-b46d-48ca-217c-08db6b322889 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7717 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --_002_PAXPR08MB69268DE5D98F7A39A67F74FA9354APAXPR08MB6926eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Richard, > -----Original Message----- > From: Richard Sandiford > Sent: Friday, June 9, 2023 7:08 PM > To: Kyrylo Tkachov via Gcc-patches > Cc: Kyrylo Tkachov > Subject: Re: [PATCH] simplify-rtx: Implement constant folding of > SS_TRUNCATE, US_TRUNCATE >=20 > Kyrylo Tkachov via Gcc-patches writes: > > Hi all, > > > > This patch implements RTL constant-folding for the SS_TRUNCATE and > US_TRUNCATE codes. > > The semantics are a clamping operation on the argument with the min and > max of the narrow mode, > > followed by a truncation. The signedness of the clamp and the min/max > extrema is derived from > > the signedness of the saturating operation. > > > > We have a number of instructions in aarch64 that use SS_TRUNCATE and > US_TRUNCATE to represent > > their operations and we have pretty thorough runtime tests in > gcc.target/aarch64/advsimd-intrinsics/vqmovn*.c. > > With this patch the instructions are folded away at optimisation levels= and > the correctness checks still > > pass. > > > > Bootstrapped and tested on aarch64-none-linux-gnu and aarch64_be-none- > elf. > > Ok for trunk? > > > > Thanks, > > Kyrill > > > > gcc/ChangeLog: > > > > * simplify-rtx.cc (simplify_const_unary_operation): > > Handle US_TRUNCATE, SS_TRUNCATE. > > > > diff --git a/gcc/simplify-rtx.cc b/gcc/simplify-rtx.cc > > index > 276be67aa67247dd46361ab9badc46ab089d6df0..5983a06e5a8ca89c717e864 > 8be410024147b16e6 100644 > > --- a/gcc/simplify-rtx.cc > > +++ b/gcc/simplify-rtx.cc > > @@ -2131,6 +2131,22 @@ simplify_const_unary_operation (enum > rtx_code code, machine_mode mode, > > result =3D wide_int::from (op0, width, UNSIGNED); > > break; > > > > + case US_TRUNCATE: > > + case SS_TRUNCATE: > > + { > > + signop sgn =3D code =3D=3D US_TRUNCATE ? UNSIGNED : SIGNED; > > + wide_int nmax > > + =3D wide_int::from (wi::max_value (width, sgn), > > + GET_MODE_PRECISION (imode), sgn); > > + wide_int nmin > > + =3D wide_int::from (wi::min_value (width, sgn), > > + GET_MODE_PRECISION (imode), sgn); > > + result > > + =3D wide_int::from (op0, GET_MODE_PRECISION (imode), sgn); > > + result =3D wi::min (wi::max (result, nmin, sgn), nmax, sgn); >=20 > FWIW, it looks like this could be: >=20 > result =3D wi::min (wi::max (op0, nmin, sgn), nmax, sgn); >=20 > without the first assignment to result. That feels more natural IMO, > since no conversion is being done on op0. Thanks, that works indeed. I'll push the attached patch to trunk once bootstrap and testing completes. Kyrill >=20 > Thanks, > Richard >=20 > > + result =3D wide_int::from (result, width, sgn); > > + break; > > + } > > case SIGN_EXTEND: > > result =3D wide_int::from (op0, width, SIGNED); > > break; --_002_PAXPR08MB69268DE5D98F7A39A67F74FA9354APAXPR08MB6926eurp_ Content-Type: application/octet-stream; name="sstrunc.patch" Content-Description: sstrunc.patch Content-Disposition: attachment; filename="sstrunc.patch"; size=908; creation-date="Mon, 12 Jun 2023 10:43:34 GMT"; modification-date="Mon, 12 Jun 2023 10:45:21 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9zaW1wbGlmeS1ydHguY2MgYi9nY2Mvc2ltcGxpZnktcnR4LmNjCmlu ZGV4IDI3NmJlNjdhYTY3MjQ3ZGQ0NjM2MWFiOWJhZGM0NmFiMDg5ZDZkZjAuLjIxYjdlYjQ4NGQw NTgxOGJiNTYzZTA4NmUwN2E2MTUyYTNhM2M2YjcgMTAwNjQ0Ci0tLSBhL2djYy9zaW1wbGlmeS1y dHguY2MKKysrIGIvZ2NjL3NpbXBsaWZ5LXJ0eC5jYwpAQCAtMjEzMSw2ICsyMTMxLDIwIEBAIHNp bXBsaWZ5X2NvbnN0X3VuYXJ5X29wZXJhdGlvbiAoZW51bSBydHhfY29kZSBjb2RlLCBtYWNoaW5l X21vZGUgbW9kZSwKIAkgIHJlc3VsdCA9IHdpZGVfaW50Ojpmcm9tIChvcDAsIHdpZHRoLCBVTlNJ R05FRCk7CiAJICBicmVhazsKIAorCWNhc2UgVVNfVFJVTkNBVEU6CisJY2FzZSBTU19UUlVOQ0FU RToKKwkgIHsKKwkgICAgc2lnbm9wIHNnbiA9IGNvZGUgPT0gVVNfVFJVTkNBVEUgPyBVTlNJR05F RCA6IFNJR05FRDsKKwkgICAgd2lkZV9pbnQgbm1heAorCSAgICAgID0gd2lkZV9pbnQ6OmZyb20g KHdpOjptYXhfdmFsdWUgKHdpZHRoLCBzZ24pLAorCQkJCUdFVF9NT0RFX1BSRUNJU0lPTiAoaW1v ZGUpLCBzZ24pOworCSAgICB3aWRlX2ludCBubWluCisJICAgICAgPSB3aWRlX2ludDo6ZnJvbSAo d2k6Om1pbl92YWx1ZSAod2lkdGgsIHNnbiksCisJCQkJR0VUX01PREVfUFJFQ0lTSU9OIChpbW9k ZSksIHNnbik7CisJICAgIHJlc3VsdCA9IHdpOjptaW4gKHdpOjptYXggKG9wMCwgbm1pbiwgc2du KSwgbm1heCwgc2duKTsKKwkgICAgcmVzdWx0ID0gd2lkZV9pbnQ6OmZyb20gKHJlc3VsdCwgd2lk dGgsIHNnbik7CisJICAgIGJyZWFrOworCSAgfQogCWNhc2UgU0lHTl9FWFRFTkQ6CiAJICByZXN1 bHQgPSB3aWRlX2ludDo6ZnJvbSAob3AwLCB3aWR0aCwgU0lHTkVEKTsKIAkgIGJyZWFrOwo= --_002_PAXPR08MB69268DE5D98F7A39A67F74FA9354APAXPR08MB6926eurp_--