public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: Saurabh Jha <Saurabh.Jha@arm.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	Richard Sandiford <Richard.Sandiford@arm.com>
Subject: RE: [PATCH] Add a REG_P check for inc and dec for Arm MVE
Date: Tue, 14 Nov 2023 14:51:21 +0000	[thread overview]
Message-ID: <PAXPR08MB69269CC86407B4A58FAD732093B2A@PAXPR08MB6926.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <6522a7d2-63a9-477a-a4b3-6069d83de0c0@arm.com>

Hi Saurabh,

> -----Original Message-----
> From: Saurabh Jha <saurabh.jha@arm.com>
> Sent: Thursday, November 9, 2023 10:12 AM
> To: gcc-patches@gcc.gnu.org; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; Richard Sandiford
> <Richard.Sandiford@arm.com>
> Subject: [PATCH] Add a REG_P check for inc and dec for Arm MVE
> 
> Hey,
> 
> This patch tightens mve_vector_mem_operand to reject non-register
> operands inside {PRE,POST}_{INC,DEC} addresses by introducing a REG_P
> check.
> 
> This patch fixes this ICE:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112337
> 
> Okay for trunk? I don't have trunk access so could someone please commit
> on my behalf?

Ok.

> 
> Regards,
> Saurabh
> 
> gcc/ChangeLog:
> 
> 	PR target/112337
> 	* config/arm/arm.cc (mve_vector_mem_operand): Add a REG_P
> check for INC
> 	and DEC operations
> 
> gcc/testsuite/ChangeLog:
> 
> 	PR target/112337
> 	* gcc.target/arm/mve/pr112337.c: Test for REG_P check for INC and
> DEC
> 	operations

ChangeLog entries should end with a full stop (the git commit hooks enforce it).
I've adjusted the ChangeLog and pushed this patch for you.
Thank you for the patch!
Kyrill


  reply	other threads:[~2023-11-14 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 10:12 Saurabh Jha
2023-11-14 14:51 ` Kyrylo Tkachov [this message]
2023-11-20 10:12   ` Christophe Lyon
2023-11-28 16:14     ` Saurabh Jha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR08MB69269CC86407B4A58FAD732093B2A@PAXPR08MB6926.eurprd08.prod.outlook.com \
    --to=kyrylo.tkachov@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Richard.Sandiford@arm.com \
    --cc=Saurabh.Jha@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).