From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) by sourceware.org (Postfix) with ESMTPS id B9D4B3858D37 for ; Mon, 27 Mar 2023 08:45:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9D4B3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fq4bhQuodrN4k7NVA3mi1ranNHeMRKZT4RE5m7QMH+c=; b=NUoz7hMga0gc4UCuEYRpSqnFiArgjXwmwDfr6d3Kh/b4DP7Q3GrUda9XUX89+B8W2+4X/bwampmPXdhrHxbI20J63dbP3J5bKSkO4inNJa96Gzvf9TUnJdK2oiHB80h6PR928VYU30J8y+EhD4I48CpCD+uwwElqhNcbGtiwX8s= Received: from DB3PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:8:1::24) by DU0PR08MB7414.eurprd08.prod.outlook.com (2603:10a6:10:352::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 27 Mar 2023 08:45:07 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::59) by DB3PR06CA0011.outlook.office365.com (2603:10a6:8:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.41 via Frontend Transport; Mon, 27 Mar 2023 08:45:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.22 via Frontend Transport; Mon, 27 Mar 2023 08:45:06 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Mon, 27 Mar 2023 08:45:06 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 689f5f45e54afd91 X-CR-MTA-TID: 64aa7808 Received: from a10062898cbe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 56DBAD0A-C05D-46C6-B00A-DD34E74C1360.1; Mon, 27 Mar 2023 08:45:00 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a10062898cbe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 27 Mar 2023 08:45:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ik78qCK/budN1ss6YiZbODN86lVWzgEiYd3/aih6hm73HMCkL+KrMw91ZS0FoHivVz+4IFP370CUVWvYBfB2VLx+3rHnbnizvr+PZWqqWetz3hQe0vgVdbs+yg8kBoHuvQUJs/9ulus/Ni0C6YFTjO9EYswr3/wbEuESjkVwGoAxlaARl8mhQlm10kPNJrVI6KXm5T9HN/47a8GLtn/7A1RIwacVbJiL+/7zI8f4VrAg/oK12++ZdEdhojGZKxwpzFW47dKdNlUD/Z87ENy6/ftBRp9tKkgqqrwV9YLg0V17BdzrNTtu0n0tbYqaZZ3GqesksNXx5oBZwCsXgmF3YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fq4bhQuodrN4k7NVA3mi1ranNHeMRKZT4RE5m7QMH+c=; b=mNTprBSRBqG7XmZS4sjh47CxK41rxfVS1zsW74gzqaAF8EAW55Aery6pJa0kedS0XmffXKg4Hck4hyyvkcq2zmBPnE+4X//ztMqcEPqQcRLcV/GWATC2fkj5nyWiSpC59y4PCr3sMNK8FDeIH5qLik6OrVe9NajEtNGIpgZZ3w+SSNPnTyyITA2ABD8amjyjh8In8IKwUfwU02tzTvx59OME97moLnPMToYy+SxeK/meTsJ/6NMuymJRVoBcskPXX853X3MWKUo+NfkmMf2fJWijOqMuyg+onFgiqInVDzKXrzfnItizurRDEOAAbEAdpuX2Z/LxsXYdMQaI81Zc9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fq4bhQuodrN4k7NVA3mi1ranNHeMRKZT4RE5m7QMH+c=; b=NUoz7hMga0gc4UCuEYRpSqnFiArgjXwmwDfr6d3Kh/b4DP7Q3GrUda9XUX89+B8W2+4X/bwampmPXdhrHxbI20J63dbP3J5bKSkO4inNJa96Gzvf9TUnJdK2oiHB80h6PR928VYU30J8y+EhD4I48CpCD+uwwElqhNcbGtiwX8s= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by PR3PR08MB5851.eurprd08.prod.outlook.com (2603:10a6:102:85::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.28; Mon, 27 Mar 2023 08:44:59 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::8bb3:2d4d:b99e:f10a]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::8bb3:2d4d:b99e:f10a%4]) with mapi id 15.20.6222.030; Mon, 27 Mar 2023 08:44:58 +0000 From: Kyrylo Tkachov To: Philipp Tomsich , "gcc-patches@gcc.gnu.org" CC: Richard Sandiford , Tamar Christina , Manolis Tsamis Subject: RE: [PATCH] aarch64: update ampere1 vectorization cost Thread-Topic: [PATCH] aarch64: update ampere1 vectorization cost Thread-Index: AQHZYIBymFZ8Z57t5k6qFZTrKdrTOq8OT1JA Date: Mon, 27 Mar 2023 08:44:58 +0000 Message-ID: References: <20230327074654.1126912-1-philipp.tomsich@vrull.eu> In-Reply-To: <20230327074654.1126912-1-philipp.tomsich@vrull.eu> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|PR3PR08MB5851:EE_|DBAEUR03FT039:EE_|DU0PR08MB7414:EE_ X-MS-Office365-Filtering-Correlation-Id: ea82f3dc-5153-4f92-9eb3-08db2e9f90d5 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ujQiaD7rLuGEFW9jrxxeiK8s+aaAWWiG+4A6tCw4whTQ6LoAE1Mg8+87p1ahOrIyNw0U5GOh7gg0KPQY6I+arISZITZGTsD3cMyQ6aOpoFogwcwIX7nnyswtB6t4IuXCLELGKb7hIEDPwS0ZWzSZTYYjFNEnThrdXYYjwaFeKh3grw444AlclqEqoieMJtEKr7CqgEx4ikJs5tUrPFgLHAx/+dMrZWkQPDh4e0gSg0s5pBUt1f6Ou95YMOIxS7kkMFKzu1Z75Oqk39Pd93x7JKsmboScnvyHVpsxAW63xy7PdYROgtPTjH/K+IUAEasidR6+DWHRIMkuqJCLcQkoWTgx7gFzcsbt0S810MZcRJ3FnY2rO9ZMvwzK0VTBltddj77hpy0VAtn9H2RCxyEQS+jV7xPa7+O0bgX6bj4ZANKRgVU6AH9CvAlNm7mQACUjtWHto6uiPxr9wkmnVKtl3E9hwgcwwSC8YUo5uVdS/3ozkKjwD+mOqG9HUU0iWowJEC473D3jn6bpa3mwMjwTrVDx+Rgs9KvAUOtvEYz+3swvI2dvsmeHRmRMnCjzbA92LNKWqE/n1NVsUxWm1RJQvYWWZq6q4XgeTfDxg1JKDsqp1Ve1+M2qF5fW6IRd0oG/ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199021)(83380400001)(52536014)(41300700001)(33656002)(86362001)(5660300002)(38100700002)(8936002)(122000001)(54906003)(478600001)(7696005)(71200400001)(76116006)(64756008)(8676002)(66946007)(66556008)(4326008)(66476007)(66446008)(2906002)(15650500001)(55016003)(38070700005)(186003)(6506007)(26005)(53546011)(9686003)(316002)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5851 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7b44266c-3a52-4321-40de-08db2e9f8c25 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NO+fAXsK0BMVp4+MR9Ba9HDlMiPb5ZN6OxYOsv+zN9G8648pabeDdI0hFWS6RoVQ2OetAIxoHAhLDbfIC+HZV+IG7A2Q5AQayMGt1QCGCyx5ssbY98COSEgSdHZk2TI3ohS1B4HwILqld1/ZxipOvIYMjZxPTkhVInFUKRN06yQHpKU8WjvPcrA8DM67OFTCiS4m1vs7R5xIh7d0Ju+P7vMz4ko+FVmZ3GP7fF+7gmtQqqUyIRniQn23NU8p7+x2G+56Z7QhE4B5mvE26dJyoV9QqmDi7L/HYr7uw7Cb25K5lMufcTbRs0yXL8116x8zp6Dv2H6Sk94UJSJz9NrSGJDFD5+MngTRsN+zFGkYmEfvrlTdWFIIhUJAf1o0g5nIMI0zihrzUAA1Z+ld+KC/8kP2GsO43JOYqfyb3QUXO4ewhLfbJQHfHk8Hbl2VGqRn4QkNAn1AbjrlPoNz9eRZhyVcvz3G2w+vTcsfDxOgJHNog3dY+Y4vt7rXrERPfR53j7OosrTFE+NPnjiCq1beS7BCgNMRB0sBYmuiURXSbr9ffsf5fSwqnFEZ4IJ8EwFXD4F/OmgZ2Uh9PATHyhcHUF4VSt4aLMqIfIPGtceI5yRTpVMz5qIhp0dOYnmMttGqEKuLCZL+HSaM4PMHh5CnCQlq0X/BbEtX7c98J5zX0EvaBIDUmpklaq2y4cxkPRfXrM8aw2zBxliWe0i31fyGLg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199021)(36840700001)(40470700004)(46966006)(107886003)(82310400005)(110136005)(83380400001)(15650500001)(82740400003)(2906002)(5660300002)(7696005)(9686003)(316002)(53546011)(478600001)(70206006)(186003)(336012)(8676002)(52536014)(8936002)(70586007)(40460700003)(41300700001)(33656002)(4326008)(6506007)(356005)(54906003)(86362001)(55016003)(26005)(40480700001)(81166007)(47076005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2023 08:45:06.7653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea82f3dc-5153-4f92-9eb3-08db2e9f90d5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7414 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Philipp, > -----Original Message----- > From: Gcc-patches bounces+kyrylo.tkachov=3Darm.com@gcc.gnu.org> On Behalf Of Philipp > Tomsich > Sent: Monday, March 27, 2023 8:47 AM > To: gcc-patches@gcc.gnu.org > Cc: Richard Sandiford ; Tamar Christina > ; Philipp Tomsich ; > Manolis Tsamis > Subject: [PATCH] aarch64: update ampere1 vectorization cost >=20 > The original submission of AmpereOne (-mcpu=3Dampere1) costs occurred > prior to exhaustive testing of vectorizable workloads against > hardware. >=20 > Adjust the vector costs to achieve the best results and more closely > match the underlying hardware. >=20 > gcc/ChangeLog: >=20 > * config/aarch64/aarch64.cc: Update vector costs for ampere1. >=20 > Co-Authored-By: Manolis Tsamis >=20 > Signed-off-by: Philipp Tomsich > --- > We would like to get this into GCC 13 to avoid having to backport at > the start of the next cycle. >=20 Given this affects only the ampere1 costs that sounds fine to me and fairly= low risk, you are being trusted that these costs are actually desirable an= d properly validated on the hardware involved. > OK for backports? This is ok for trunk (GCC 13). Do you also want to backport this to other b= ranches? Thanks, Kyrill >=20 > gcc/config/aarch64/aarch64.cc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.c= c > index b27f4354031..661fff65cea 100644 > --- a/gcc/config/aarch64/aarch64.cc > +++ b/gcc/config/aarch64/aarch64.cc > @@ -1132,7 +1132,7 @@ static const struct cpu_vector_cost > thunderx3t110_vector_cost =3D >=20 > static const advsimd_vec_cost ampere1_advsimd_vector_cost =3D > { > - 3, /* int_stmt_cost */ > + 1, /* int_stmt_cost */ > 3, /* fp_stmt_cost */ > 0, /* ld2_st2_permute_cost */ > 0, /* ld3_st3_permute_cost */ > @@ -1148,17 +1148,17 @@ static const advsimd_vec_cost > ampere1_advsimd_vector_cost =3D > 8, /* store_elt_extra_cost */ > 6, /* vec_to_scalar_cost */ > 7, /* scalar_to_vec_cost */ > - 5, /* align_load_cost */ > - 5, /* unalign_load_cost */ > - 2, /* unalign_store_cost */ > - 2 /* store_cost */ > + 4, /* align_load_cost */ > + 4, /* unalign_load_cost */ > + 1, /* unalign_store_cost */ > + 1 /* store_cost */ > }; >=20 > /* Ampere-1 costs for vector insn classes. */ > static const struct cpu_vector_cost ampere1_vector_cost =3D > { > 1, /* scalar_int_stmt_cost */ > - 1, /* scalar_fp_stmt_cost */ > + 3, /* scalar_fp_stmt_cost */ > 4, /* scalar_load_cost */ > 1, /* scalar_store_cost */ > 1, /* cond_taken_branch_cost */ > -- > 2.34.1