From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2048.outbound.protection.outlook.com [40.107.247.48]) by sourceware.org (Postfix) with ESMTPS id 01A9C3858D20 for ; Fri, 5 May 2023 10:48:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01A9C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ni5P7cSOPTy8fhCWCJRRJ1h2V50VJy7oPiwZTxu3Vwg=; b=DXNlEYKttaLhDI2pjoUKfZLzuO7zeeG62GB3v4F0RZiNE7u2ddma2sqZctFjb70rWHjAjGzPOYJj6Vg0iaBtn57fBUlyMAKnKPLAHVcp3VtTsvsAgHaaPQs8lf5FxmNgPIR3f2XG/0XwIk6nH1fXjQXMwTV0PaYuKAbs5MugtOk= Received: from AS9PR05CA0200.eurprd05.prod.outlook.com (2603:10a6:20b:495::24) by DU0PR08MB7488.eurprd08.prod.outlook.com (2603:10a6:10:358::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 10:48:30 +0000 Received: from AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:495:cafe::d5) by AS9PR05CA0200.outlook.office365.com (2603:10a6:20b:495::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 10:48:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT048.mail.protection.outlook.com (100.127.140.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27 via Frontend Transport; Fri, 5 May 2023 10:48:30 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Fri, 05 May 2023 10:48:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: dac30fc8c1afe631 X-CR-MTA-TID: 64aa7808 Received: from 20b74fe571de.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 57C94544-9E12-4B93-A785-91F1605605BE.1; Fri, 05 May 2023 10:48:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 20b74fe571de.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 05 May 2023 10:48:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRsdP3EWZXzMtx7Q+yaP0eCgRHKlwYyKhQU03yirUo7ssGzgT30G/awFzx2sLB6MwgHyPmFJs4/rpVd2zYCXzdFSjZUaJXP+RNxjwS+fJaetgv5CPd3xQ35HxszxLhLM9fxpVXRoB29L20dCJUmoZElKl5abCmoq2gDkcKRbel9jeXSw49dIGx3UKL7OzESjbsiannri50To4N9wBGGb9dBDTp9STdsMf+e8Zxeg+EYB4zcX37tRHP44Z/3uJ8T5BxkbiGsMbYxuKQttjesI7k8zcW4jk6IesIIKLdXEjfx7iS2nwaSSj9+Lf2gHOM00FWzfaRhSwMIibrXXF4LXuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ni5P7cSOPTy8fhCWCJRRJ1h2V50VJy7oPiwZTxu3Vwg=; b=QWTmh1bXdlyubgIA2IKpYiExvshZOBZzKXGjWwh9A2W5Nnc3fI5BU8pgsvohcabL6RYVVHeyj3LnCXST0j6d6nPxvIpbCktt0qDXobWdi9Gr49u9RQqSxCqZtaCNZvZGbbypkifE46xAHumTwZHxBE7MzVyS5S5UYqd5XVHN7fl9Hrz5ccRO10lpxlNxUczw66cH9FyXy3ehRiVYgugDKozRRojomjyncmwVKavaMggijzAn7X84F2CxoCnOaDciGGyNYHgFSiockBpu4l9X+jDlKchx821XywmQ5SeoQhRkusMAeaUa69F8lkv9yam3iEzyPWSME9+fF5fez/HDSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ni5P7cSOPTy8fhCWCJRRJ1h2V50VJy7oPiwZTxu3Vwg=; b=DXNlEYKttaLhDI2pjoUKfZLzuO7zeeG62GB3v4F0RZiNE7u2ddma2sqZctFjb70rWHjAjGzPOYJj6Vg0iaBtn57fBUlyMAKnKPLAHVcp3VtTsvsAgHaaPQs8lf5FxmNgPIR3f2XG/0XwIk6nH1fXjQXMwTV0PaYuKAbs5MugtOk= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by AS2PR08MB8573.eurprd08.prod.outlook.com (2603:10a6:20b:55c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 10:48:19 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1%3]) with mapi id 15.20.6363.027; Fri, 5 May 2023 10:48:19 +0000 From: Kyrylo Tkachov To: Christophe Lyon , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford CC: Christophe Lyon Subject: RE: [PATCH 06/23] arm: [MVE intrinsics] factorize vabdq Thread-Topic: [PATCH 06/23] arm: [MVE intrinsics] factorize vabdq Thread-Index: AQHZfy076/EBkZz040KOt5SaACTI2q9Lf8zA Date: Fri, 5 May 2023 10:48:18 +0000 Message-ID: References: <20230505083930.101210-1-christophe.lyon@arm.com> <20230505083930.101210-6-christophe.lyon@arm.com> In-Reply-To: <20230505083930.101210-6-christophe.lyon@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|AS2PR08MB8573:EE_|AM7EUR03FT048:EE_|DU0PR08MB7488:EE_ X-MS-Office365-Filtering-Correlation-Id: 43376f40-867b-49ad-4171-08db4d5643c8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FJ6zbCex1yChJG+kNxF4lBM4sNulaMBIOZGqbeFM0ivdS5v2DUvdxBqAdYJIQZBfW1uHepetFc3Mno7vTVQJhzBzwqYaALUktfsXFzCX25IRo5HOU0rXX59lJ5IGqAKVIRETgYZD2S9dBM8ZnvAomOqSy1GZhxkUruLAlRztOPQbf36GaMC3s7w8O5WnDVDRt9JgFKgLfwwQDRwsTxMN87gn25NlLmLTeyIn2cPovg5Ix94BmhBOmIrgQLOxS4V0dXDD58oMNTPFuOJ4qGFT+FEVzs203Y4+L7brl+kHqBFT6EJbwslKy5EdnyoZGfQiGM0u+Hf5n7UlgdmEBw+DS4jCvGXphN44DPXsH22XyPdsmFX0QJKyuYqEyAmOZTE46u7rLJZZKJ2LRUwdUedyC/Fu1ror3SOxXjTmChmw/dQaJfAR8egiDR/dvFKTACRDilstcM/plaq/zcaO9YNvIQ6EwyirioDbzhoTWnMI1alu/HBIBdvD5cUgawvcaANSTgaN8KUxBNAgrh7rIQu2c02GertfuuY/EFNNvlcYjEdtCyHzdwLlA/G4oczQAYWUzb31wzhixH0WJNbnP6Umr4WW4SjuXBo17U0QVf9MQUO7g9+1QaUwcbqV9fxjgZxn X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199021)(41300700001)(53546011)(71200400001)(2906002)(186003)(26005)(9686003)(6506007)(83380400001)(6636002)(64756008)(66446008)(7696005)(4326008)(66556008)(86362001)(76116006)(66476007)(66946007)(316002)(33656002)(38070700005)(110136005)(55016003)(52536014)(8936002)(478600001)(5660300002)(8676002)(122000001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8573 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 51197eae-cc90-4c0d-9f9f-08db4d563cf5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hXJk520qMuCEzskOiuXGr/UuXkA69rguEQ4/TVGpxI61PqrkzGQKsM7idhqUvkkZQeF+2leeyitQ/rjvOu8SsoONMeoGG5lxmJ24y/HfBCeszcIJnjJ3TU0aoaIWEyGbgASu5Tfi3B/dabLdmgLzSBwWAOu27pIA+gac6WUVTVl2B83DAfwN7UT2OLEfg+VrPwcU9w67fPLcBw8gmoCxOTh4kEJY/QOGYoCnlRp2tVjwfc06JuY3ofSKZpseZr12thz80c9dblVmpMV5EoUUiS2EVVQPoWfHxdbDLjNwcE2tHY43EXMct8IppT84XiKI5dI/YL6pLDdR9099gddw7qPstWsrj0p1VxoRNZmAZwfiltCAtK59YUjb2oBJ1O4szw6uhzARzbzckrJufMOEpenN2bWqFVscns0xstNRQe7DuBa8iiee0NlmuVa2e6oE5szc6u8BEyTR+VqZKGQZWqiQCR4azdiKQq3kGvwQ7Hv5nR1SLy3GMOIFkstVytS67A+KZH6X7MGduX6/494AzdZwFK5wkUGpmhl1y21Th8RB5C2TB3OqthirwuPiWv8Nf90Ub0+drtBBZqxqA8GtGaaVfGnmesRFjPnjGERb1cPQIhKpjQk7ivA49a5hQKR4xXowtF54BmsSASa/+TReVOyv7pS2MrkCWaI17e0+lF8xLfxk9Ud6bqVFLA+NFmL1Pm7BA+8Ugw5+qxPL3uD/d563VJZs+6eP0SlYnR2ANdI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199021)(40470700004)(36840700001)(46966006)(40460700003)(41300700001)(7696005)(82310400005)(336012)(86362001)(47076005)(6506007)(26005)(9686003)(83380400001)(186003)(53546011)(2906002)(33656002)(82740400003)(34020700004)(36860700001)(356005)(81166007)(40480700001)(55016003)(5660300002)(8676002)(52536014)(8936002)(6636002)(4326008)(110136005)(70586007)(70206006)(478600001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 10:48:30.2155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43376f40-867b-49ad-4171-08db4d5643c8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7488 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Christophe Lyon > Sent: Friday, May 5, 2023 9:39 AM > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > Richard Earnshaw ; Richard Sandiford > > Cc: Christophe Lyon > Subject: [PATCH 06/23] arm: [MVE intrinsics] factorize vabdq >=20 > 2022-09-08 Christophe Lyon >=20 > gcc/ > * config/arm/iterators.md (MVE_FP_M_BINARY): Add vabdq. > (MVE_FP_VABDQ_ONLY): New. > (mve_insn): Add vabd. > * config/arm/mve.md (mve_vabdq_f): Move into ... > (@mve_q_f): ... this. > (mve_vabdq_m_f): Remove. Ok. Thanks, Kyrill > --- > gcc/config/arm/iterators.md | 9 +++++++-- > gcc/config/arm/mve.md | 25 +++++-------------------- > 2 files changed, 12 insertions(+), 22 deletions(-) >=20 > diff --git a/gcc/config/arm/iterators.md b/gcc/config/arm/iterators.md > index c53b42a86e9..3133642ea82 100644 > --- a/gcc/config/arm/iterators.md > +++ b/gcc/config/arm/iterators.md > @@ -466,6 +466,7 @@ (define_int_iterator MVE_RSHIFT_N [ > ]) >=20 > (define_int_iterator MVE_FP_M_BINARY [ > + VABDQ_M_F > VADDQ_M_F > VMULQ_M_F > VSUBQ_M_F > @@ -490,6 +491,10 @@ (define_int_iterator MVE_FP_N_BINARY [ > VSUBQ_N_F > ]) >=20 > +(define_int_iterator MVE_FP_VABDQ_ONLY [ > + VABDQ_F > + ]) > + > (define_int_iterator MVE_FP_CREATE_ONLY [ > VCREATEQ_F > ]) > @@ -501,8 +506,8 @@ (define_code_attr mve_addsubmul [ > ]) >=20 > (define_int_attr mve_insn [ > - (VABDQ_M_S "vabd") (VABDQ_M_U "vabd") > - (VABDQ_S "vabd") (VABDQ_U "vabd") > + (VABDQ_M_S "vabd") (VABDQ_M_U "vabd") (VABDQ_M_F > "vabd") > + (VABDQ_S "vabd") (VABDQ_U "vabd") (VABDQ_F "vabd") > (VADDQ_M_N_S "vadd") (VADDQ_M_N_U "vadd") > (VADDQ_M_N_F "vadd") > (VADDQ_M_S "vadd") (VADDQ_M_U "vadd") (VADDQ_M_F > "vadd") > (VADDQ_N_S "vadd") (VADDQ_N_U "vadd") (VADDQ_N_F > "vadd") > diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md > index fb1076aef73..c8cb4e430ac 100644 > --- a/gcc/config/arm/mve.md > +++ b/gcc/config/arm/mve.md > @@ -1451,17 +1451,17 @@ (define_insn "mve_vrshrq_n_" > ]) >=20 > ;; > -;; [vabdq_f]) > +;; [vabdq_f] > ;; > -(define_insn "mve_vabdq_f" > +(define_insn "@mve_q_f" > [ > (set (match_operand:MVE_0 0 "s_register_operand" "=3Dw") > (unspec:MVE_0 [(match_operand:MVE_0 1 "s_register_operand" > "w") > (match_operand:MVE_0 2 "s_register_operand" "w")] > - VABDQ_F)) > + MVE_FP_VABDQ_ONLY)) > ] > "TARGET_HAVE_MVE && TARGET_HAVE_MVE_FLOAT" > - "vabd.f%# %q0, %q1, %q2" > + ".f%#\t%q0, %q1, %q2" > [(set_attr "type" "mve_move") > ]) >=20 > @@ -5483,24 +5483,9 @@ (define_insn "mve_vrmlsldavhaxq_p_sv4si" > "vpst\;vrmlsldavhaxt.s32\t%Q0, %R0, %q2, %q3" > [(set_attr "type" "mve_move") > (set_attr "length""8")]) > -;; > -;; [vabdq_m_f]) > -;; > -(define_insn "mve_vabdq_m_f" > - [ > - (set (match_operand:MVE_0 0 "s_register_operand" "=3Dw") > - (unspec:MVE_0 [(match_operand:MVE_0 1 "s_register_operand" "0") > - (match_operand:MVE_0 2 "s_register_operand" "w") > - (match_operand:MVE_0 3 "s_register_operand" "w") > - (match_operand: 4 > "vpr_register_operand" "Up")] > - VABDQ_M_F)) > - ] > - "TARGET_HAVE_MVE && TARGET_HAVE_MVE_FLOAT" > - "vpst\;vabdt.f%# %q0, %q2, %q3" > - [(set_attr "type" "mve_move") > - (set_attr "length""8")]) >=20 > ;; > +;; [vabdq_m_f] > ;; [vaddq_m_f] > ;; [vsubq_m_f] > ;; [vmulq_m_f] > -- > 2.34.1