From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2083.outbound.protection.outlook.com [40.107.13.83]) by sourceware.org (Postfix) with ESMTPS id 965023858C30 for ; Wed, 3 May 2023 08:49:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 965023858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIePAWfaV8Cc+DDnEvLV/MkGg5twXlTSJE+fANbmgVY=; b=yU3hmP8trN8U4zgYCTY6Pa5E8soJqrDqlHlZKhpXW9SNFJABcYQ/FXlkibXjgXxlxUyJCOA6SnQS/THFMTjMfxVIBshbwzG96LrI6X6mz6448QslnVKAjEmcSWk02ubNteo5sJRXUuLb8qDlBY28O65JD1uznwxQa1E1GfHMsVQ= Received: from AS4PR10CA0030.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::11) by AS8PR08MB9671.eurprd08.prod.outlook.com (2603:10a6:20b:615::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 08:49:43 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d8:cafe::44) by AS4PR10CA0030.outlook.office365.com (2603:10a6:20b:5d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22 via Frontend Transport; Wed, 3 May 2023 08:49:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20 via Frontend Transport; Wed, 3 May 2023 08:49:42 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Wed, 03 May 2023 08:49:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 478b7300fcc6d49b X-CR-MTA-TID: 64aa7808 Received: from c8e0fa23c75c.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 84447E0C-C0C4-402B-A2E6-C37DCF3445DA.1; Wed, 03 May 2023 08:49:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c8e0fa23c75c.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 May 2023 08:49:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BP8lkmQvhtW+NLJMurgGtLrwB3JtuajWceGfF0mnVcCYwqikE3ckdJyTaqtxxNgFBPRuhNae/oUwx7Mm7gjv+WZIeJ7JIuBu4/VZ4xluWDI0Q5DPlUgJHy1a4N0DRKP6GVY7O5Bl/TBPmBsvZRKbWvbR+p2R5/ZBLolqf7/LXrJZHZFSSQ5IIbHq3ODjcvHzBCsiL1R/2fWNpaY27F+/98k/E+443RWI9ds3yVFqWkPFAaEJf+VcpBdkPxhYFbMVVkl8t8qV0s5bFBCuh2kZNBQA6PTyOPsFUcLX7+a9OmBmnSSuQq+QDmWuoXoBhs8JZDNSSyX1fwDDawDQViJINQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gIePAWfaV8Cc+DDnEvLV/MkGg5twXlTSJE+fANbmgVY=; b=nc2BZ4BGxwumPPCgRNSdJHc5m1uNxO5DzCIHubgI11Wk5ip32lKKgz9mfLEmPcor+JE3gSDx8HVJi1q6mTRfHloX5Ne7Y6TKSo8jtJvXYXcBJekPxd4t4iBBfrRxpu0M9YCrhDnLpOayqjTuZTpNqG3iKZ1XeEd8Yy8o1Qia0SU0c4QhyGk//WO13knKkpvqk/lM41WrJnL8OfCpZP7Jllu/QwuYkHAm5vlWdXlRexthOsqvC4oQBIvP+gD+Ewoo50lbsUOI41R3q5LHmSu1O5yKMtc1Ymq9M1KqcvWvsRF7A63FrT8Ec33piI6C+cNucc0apRpvrQVP76K+ZryDwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIePAWfaV8Cc+DDnEvLV/MkGg5twXlTSJE+fANbmgVY=; b=yU3hmP8trN8U4zgYCTY6Pa5E8soJqrDqlHlZKhpXW9SNFJABcYQ/FXlkibXjgXxlxUyJCOA6SnQS/THFMTjMfxVIBshbwzG96LrI6X6mz6448QslnVKAjEmcSWk02ubNteo5sJRXUuLb8qDlBY28O65JD1uznwxQa1E1GfHMsVQ= Received: from PAXPR08MB6926.eurprd08.prod.outlook.com (2603:10a6:102:138::24) by DU0PR08MB8906.eurprd08.prod.outlook.com (2603:10a6:10:47e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 08:49:32 +0000 Received: from PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1]) by PAXPR08MB6926.eurprd08.prod.outlook.com ([fe80::db73:66ba:ae70:1ff1%3]) with mapi id 15.20.6363.022; Wed, 3 May 2023 08:49:32 +0000 From: Kyrylo Tkachov To: Christophe Lyon , "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford CC: Christophe Lyon Subject: RE: [PATCH 21/22] arm: [MVE intrinsics] factorize several binary operations Thread-Topic: [PATCH 21/22] arm: [MVE intrinsics] factorize several binary operations Thread-Index: AQHZcfxcY9lEJV5fW0yQSgEwILlBv69IVEyw Date: Wed, 3 May 2023 08:49:32 +0000 Message-ID: References: <20230418134608.244751-1-christophe.lyon@arm.com> <20230418134608.244751-22-christophe.lyon@arm.com> In-Reply-To: <20230418134608.244751-22-christophe.lyon@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAXPR08MB6926:EE_|DU0PR08MB8906:EE_|AM7EUR03FT052:EE_|AS8PR08MB9671:EE_ X-MS-Office365-Filtering-Correlation-Id: 5675c896-954a-4fdb-a053-08db4bb356bd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GtfzhBO2MIAbFX3ZTRMm7QwvxSNsDiRpqt/wqKZ4L9l+adEPeXILYyajhFVv7H6PXw3QrA1fzBNtZSfyj06TpOt0cAuRhCslaJ4P9zR/7CG9fDuHWuAzW9fer27LPWCCHBgrFTmLfyswMqZC05k9uHZjgNwYgho9tXmh40hsksshZXPDAVPNOMjOhrIMcZTQe4WhSeHSCcBGNAMUhjYZl5+G8K10HJJ/4QF7feJeKrh5BKkukrm/jAkNCsoEVKu2a92M+j91+2cgcKPywLLqHytPeW8f0wfceZnjDN3rStuUNl/OxhPZgbEpZ0U7vBzoebMMLpdFfjY0fsnpLQiI9o6L9ZhnCpgElETuyGd/QvxcpEM1nIZpphxIAP7fDm1qLmVBZeQw48GPzc0gqii7B4DYFzwSQv4p6bAju8d0NjH8QcfSPhYwYdnbVk+rCrZCpfv1R7hbzSR+eG6/PDmiZCF+5AQ64cepT0TptfFax7/bLcL2p0NzrDJ/KBRAx5ouAA0WDxc0A9BBLNLtDeJfe6Z/z6VZ5HbXudURjwrA2IScAYfAVVUt/TbW/Wj504fwc8OQ8CXQ9Q1EOWshl5eYyyRWyi69YpCty85SfJvwQEHrLKDAKgsP8Qgqyf4YBdWd X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6926.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(30864003)(6506007)(83380400001)(53546011)(26005)(186003)(2906002)(9686003)(4326008)(478600001)(64756008)(41300700001)(66476007)(66556008)(316002)(76116006)(66946007)(66446008)(110136005)(6636002)(71200400001)(52536014)(5660300002)(8676002)(7696005)(8936002)(55016003)(38070700005)(38100700002)(122000001)(86362001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8906 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6467e537-8071-412e-4967-08db4bb35091 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O5jt+VKzybJqPQt4X8G1MgsyOxBDCUtGdHwWRZWBhnodbe5T7oKBzObDEFrfq3Tga9rHmST+6pLpHgaKnc7HHiFlfxHs/WlHAQyWE35Op6uspPILMyXvQ6enJhE6bNDL5Dd3qtX3WeLO3SxO0BcsVaLHeuPFvvakcCIByws+XU/6SB57sFZ2GVOQ0yx+IYRwrfuOfsmx0P7lLnCRibTtfAbpL8EjlrVzfFf/ATtf75UgHQKJs1n1uWu+k5jlxFyieuoA7fiuYo5phm/70fa/xZP42NkO8o2di0HqFwHdysN8XSa4A6WqrR/9oquetF+1UAWcMDqoWl43yBaf018mRKtwP8mh2evyvCdcSeDgUvY3Qg2tpnm7ES1WW+zJzoNaenrgUftt/dcqcB36QXIb0nwadSKnPjupObiK8DKz1N5rHFEPpbVyb3WDnICO20TTIeUEXugj4KmGDnmN1SK/sv7r7eoxK2mZFgZe37UqAfGKEGYJ99+rVPR329+yP5z7FDCTe9VMeeT7cFfm0oRf8JzRGaYRuvvOFqK5tLoE8u6SqCV5Z133uBtEKgDcWtRVrRB67SJSAS8dv1jThwmWqMov19yEXw7CqtsHcLJ5A9wl/4x57Qh3s3TyqD1qhRrVrD0v4kdkO3GYPB4xMG1cPmV05BLeDt04+pZUt/JO7TSxiLd+yMEx1DzOiHiytX/2vZPoDkIFoF2GvBrW/ZJt+nuxO8SOAHP/vyFaC4UZCeg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(8676002)(8936002)(36860700001)(40480700001)(55016003)(82740400003)(41300700001)(356005)(82310400005)(81166007)(34020700004)(70206006)(33656002)(316002)(70586007)(86362001)(6636002)(4326008)(478600001)(110136005)(40460700003)(7696005)(2906002)(30864003)(336012)(52536014)(5660300002)(9686003)(53546011)(6506007)(26005)(186003)(47076005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 08:49:42.8773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5675c896-954a-4fdb-a053-08db4bb356bd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9671 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Christophe Lyon > Sent: Tuesday, April 18, 2023 2:46 PM > To: gcc-patches@gcc.gnu.org; Kyrylo Tkachov ; > Richard Earnshaw ; Richard Sandiford > > Cc: Christophe Lyon > Subject: [PATCH 21/22] arm: [MVE intrinsics] factorize several binary > operations >=20 > Factorize vabdq, vhaddq, vhsubq, vmulhq, vqaddq_u, vqdmulhq, > vqrdmulhq, vqrshlq, vqshlq, vqsubq_u, vrhaddq, vrmulhq, vrshlq > so that they use the same pattern. >=20 Ok, as before without the trailing ')'. Thanks, Kyrill > 2022-09-08 Christophe Lyon >=20 > gcc/ > * config/arm/iterators.md (MVE_INT_SU_BINARY): New. > (mve_insn): Add vabdq, vhaddq, vhsubq, vmulhq, vqaddq, vqdmulhq, > vqrdmulhq, vqrshlq, vqshlq, vqsubq, vrhaddq, vrmulhq, vrshlq. > (supf): Add VQDMULHQ_S, VQRDMULHQ_S. > * config/arm/mve.md (mve_vabdq_) > (@mve_vhaddq_, mve_vhsubq_) > (mve_vmulhq_, mve_vqaddq_) > (mve_vqdmulhq_s, mve_vqrdmulhq_s) > (mve_vqrshlq_, mve_vqshlq_) > (mve_vqsubq_, @mve_vrhaddq_) > (mve_vrmulhq_, mve_vrshlq_): Merge > into > ... > (@mve_q_): ... this. > * config/arm/vec-common.md (avg3_floor, > uavg3_floor) > (avg3_ceil, uavg3_ceil): Use gen_mve_q instead of > gen_mve_vhaddq / gen_mve_vrhaddq. > --- > gcc/config/arm/iterators.md | 31 ++++++ > gcc/config/arm/mve.md | 198 +++-------------------------------- > gcc/config/arm/vec-common.md | 8 +- > 3 files changed, 50 insertions(+), 187 deletions(-) >=20 > diff --git a/gcc/config/arm/iterators.md b/gcc/config/arm/iterators.md > index 60452cdefe3..068ae25e578 100644 > --- a/gcc/config/arm/iterators.md > +++ b/gcc/config/arm/iterators.md > @@ -414,6 +414,22 @@ (define_int_iterator MVE_INT_SU_N_BINARY [ > VQSUBQ_N_S VQSUBQ_N_U > ]) >=20 > +(define_int_iterator MVE_INT_SU_BINARY [ > + VABDQ_S VABDQ_U > + VHADDQ_S VHADDQ_U > + VHSUBQ_S VHSUBQ_U > + VMULHQ_S VMULHQ_U > + VQADDQ_S VQADDQ_U > + VQDMULHQ_S > + VQRDMULHQ_S > + VQRSHLQ_S VQRSHLQ_U > + VQSHLQ_S VQSHLQ_U > + VQSUBQ_S VQSUBQ_U > + VRHADDQ_S VRHADDQ_U > + VRMULHQ_S VRMULHQ_U > + VRSHLQ_S VRSHLQ_U > + ]) > + > (define_int_iterator MVE_INT_N_BINARY_LOGIC [ > VBICQ_N_S VBICQ_N_U > VORRQ_N_S VORRQ_N_U > @@ -456,6 +472,7 @@ (define_code_attr mve_addsubmul [ >=20 > (define_int_attr mve_insn [ > (VABDQ_M_S "vabd") (VABDQ_M_U "vabd") > + (VABDQ_S "vabd") (VABDQ_U "vabd") > (VADDQ_M_N_S "vadd") (VADDQ_M_N_U "vadd") > (VADDQ_M_N_F "vadd") > (VADDQ_M_S "vadd") (VADDQ_M_U "vadd") (VADDQ_M_F > "vadd") > (VADDQ_N_S "vadd") (VADDQ_N_U "vadd") (VADDQ_N_F > "vadd") > @@ -468,14 +485,17 @@ (define_int_attr mve_insn [ > (VHADDQ_M_N_S "vhadd") (VHADDQ_M_N_U "vhadd") > (VHADDQ_M_S "vhadd") (VHADDQ_M_U "vhadd") > (VHADDQ_N_S "vhadd") (VHADDQ_N_U "vhadd") > + (VHADDQ_S "vhadd") (VHADDQ_U "vhadd") > (VHSUBQ_M_N_S "vhsub") (VHSUBQ_M_N_U "vhsub") > (VHSUBQ_M_S "vhsub") (VHSUBQ_M_U "vhsub") > (VHSUBQ_N_S "vhsub") (VHSUBQ_N_U "vhsub") > + (VHSUBQ_S "vhsub") (VHSUBQ_U "vhsub") > (VMAXQ_M_S "vmax") (VMAXQ_M_U "vmax") > (VMINQ_M_S "vmin") (VMINQ_M_U "vmin") > (VMLAQ_M_N_S "vmla") (VMLAQ_M_N_U "vmla") > (VMLASQ_M_N_S "vmlas") (VMLASQ_M_N_U "vmlas") > (VMULHQ_M_S "vmulh") (VMULHQ_M_U "vmulh") > + (VMULHQ_S "vmulh") (VMULHQ_U "vmulh") > (VMULQ_M_N_S "vmul") (VMULQ_M_N_U "vmul") > (VMULQ_M_N_F "vmul") > (VMULQ_M_S "vmul") (VMULQ_M_U "vmul") (VMULQ_M_F > "vmul") > (VMULQ_N_S "vmul") (VMULQ_N_U "vmul") (VMULQ_N_F > "vmul") > @@ -485,6 +505,7 @@ (define_int_attr mve_insn [ > (VQADDQ_M_N_S "vqadd") (VQADDQ_M_N_U "vqadd") > (VQADDQ_M_S "vqadd") (VQADDQ_M_U "vqadd") > (VQADDQ_N_S "vqadd") (VQADDQ_N_U "vqadd") > + (VQADDQ_S "vqadd") (VQADDQ_U "vqadd") > (VQDMLADHQ_M_S "vqdmladh") > (VQDMLADHXQ_M_S "vqdmladhx") > (VQDMLAHQ_M_N_S "vqdmlah") > @@ -494,6 +515,7 @@ (define_int_attr mve_insn [ > (VQDMULHQ_M_N_S "vqdmulh") > (VQDMULHQ_M_S "vqdmulh") > (VQDMULHQ_N_S "vqdmulh") > + (VQDMULHQ_S "vqdmulh") > (VQRDMLADHQ_M_S "vqrdmladh") > (VQRDMLADHXQ_M_S "vqrdmladhx") > (VQRDMLAHQ_M_N_S "vqrdmlah") > @@ -503,14 +525,21 @@ (define_int_attr mve_insn [ > (VQRDMULHQ_M_N_S "vqrdmulh") > (VQRDMULHQ_M_S "vqrdmulh") > (VQRDMULHQ_N_S "vqrdmulh") > + (VQRDMULHQ_S "vqrdmulh") > (VQRSHLQ_M_S "vqrshl") (VQRSHLQ_M_U "vqrshl") > + (VQRSHLQ_S "vqrshl") (VQRSHLQ_U "vqrshl") > (VQSHLQ_M_S "vqshl") (VQSHLQ_M_U "vqshl") > + (VQSHLQ_S "vqshl") (VQSHLQ_U "vqshl") > (VQSUBQ_M_N_S "vqsub") (VQSUBQ_M_N_U "vqsub") > (VQSUBQ_M_S "vqsub") (VQSUBQ_M_U "vqsub") > (VQSUBQ_N_S "vqsub") (VQSUBQ_N_U "vqsub") > + (VQSUBQ_S "vqsub") (VQSUBQ_U "vqsub") > (VRHADDQ_M_S "vrhadd") (VRHADDQ_M_U "vrhadd") > + (VRHADDQ_S "vrhadd") (VRHADDQ_U "vrhadd") > (VRMULHQ_M_S "vrmulh") (VRMULHQ_M_U "vrmulh") > + (VRMULHQ_S "vrmulh") (VRMULHQ_U "vrmulh") > (VRSHLQ_M_S "vrshl") (VRSHLQ_M_U "vrshl") > + (VRSHLQ_S "vrshl") (VRSHLQ_U "vrshl") > (VSHLQ_M_S "vshl") (VSHLQ_M_U "vshl") > (VSUBQ_M_N_S "vsub") (VSUBQ_M_N_U "vsub") > (VSUBQ_M_N_F "vsub") > (VSUBQ_M_S "vsub") (VSUBQ_M_U "vsub") (VSUBQ_M_F > "vsub") > @@ -1669,6 +1698,8 @@ (define_int_attr supf [(VCVTQ_TO_F_S "s") > (VCVTQ_TO_F_U "u") (VREV16Q_S "s") > (VQRDMLASHQ_M_N_S "s") > (VQDMULHQ_M_N_S "s") > (VQRDMULHQ_M_N_S "s") > + (VQDMULHQ_S "s") > + (VQRDMULHQ_S "s") > ]) >=20 > ;; Both kinds of return insn. > diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md > index d14a04d5f82..b9126af2aa9 100644 > --- a/gcc/config/arm/mve.md > +++ b/gcc/config/arm/mve.md > @@ -841,16 +841,28 @@ (define_insn > "mve_vcmpq_n_" >=20 > ;; > ;; [vabdq_s, vabdq_u]) > +;; [vhaddq_s, vhaddq_u]) > +;; [vhsubq_s, vhsubq_u]) > +;; [vmulhq_s, vmulhq_u]) > +;; [vqaddq_u, vqaddq_s]) > +;; [vqdmulhq_s]) > +;; [vqrdmulhq_s]) > +;; [vqrshlq_s, vqrshlq_u]) > +;; [vqshlq_s, vqshlq_u]) > +;; [vqsubq_u, vqsubq_s]) > +;; [vrhaddq_s, vrhaddq_u]) > +;; [vrmulhq_s, vrmulhq_u]) > +;; [vrshlq_s, vrshlq_u]) > ;; > -(define_insn "mve_vabdq_" > +(define_insn "@mve_q_" > [ > (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > (match_operand:MVE_2 2 "s_register_operand" "w")] > - VABDQ)) > + MVE_INT_SU_BINARY)) > ] > "TARGET_HAVE_MVE" > - "vabd.%# %q0, %q1, %q2" > + ".%#\t%q0, %q1, %q2" > [(set_attr "type" "mve_move") > ]) >=20 > @@ -1033,21 +1045,6 @@ (define_insn > "@mve_q_n_" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vhaddq_s, vhaddq_u]) > -;; > -(define_insn "@mve_vhaddq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VHADDQ)) > - ] > - "TARGET_HAVE_MVE" > - "vhadd.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vhcaddq_rot270_s]) > ;; > @@ -1078,21 +1075,6 @@ (define_insn "mve_vhcaddq_rot90_s" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vhsubq_s, vhsubq_u]) > -;; > -(define_insn "mve_vhsubq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VHSUBQ)) > - ] > - "TARGET_HAVE_MVE" > - "vhsub.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vmaxaq_s]) > ;; > @@ -1293,21 +1275,6 @@ (define_insn "mve_vmlsdavxq_s" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vmulhq_s, vmulhq_u]) > -;; > -(define_insn "mve_vmulhq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VMULHQ)) > - ] > - "TARGET_HAVE_MVE" > - "vmulh.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vmullbq_int_u, vmullbq_int_s]) > ;; > @@ -1405,51 +1372,6 @@ (define_expand "mve_vorrq_u" > "TARGET_HAVE_MVE" > ) >=20 > -;; > -;; [vqaddq_u, vqaddq_s]) > -;; > -(define_insn "mve_vqaddq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VQADDQ)) > - ] > - "TARGET_HAVE_MVE" > - "vqadd.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > -;; > -;; [vqdmulhq_s]) > -;; > -(define_insn "mve_vqdmulhq_s" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VQDMULHQ_S)) > - ] > - "TARGET_HAVE_MVE" > - "vqdmulh.s%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > -;; > -;; [vqrdmulhq_s]) > -;; > -(define_insn "mve_vqrdmulhq_s" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VQRDMULHQ_S)) > - ] > - "TARGET_HAVE_MVE" > - "vqrdmulh.s%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vqrshlq_n_s, vqrshlq_n_u]) > ;; > @@ -1465,21 +1387,6 @@ (define_insn "mve_vqrshlq_n_" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vqrshlq_s, vqrshlq_u]) > -;; > -(define_insn "mve_vqrshlq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VQRSHLQ)) > - ] > - "TARGET_HAVE_MVE" > - "vqrshl.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vqshlq_n_s, vqshlq_n_u]) > ;; > @@ -1510,21 +1417,6 @@ (define_insn "mve_vqshlq_r_" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vqshlq_s, vqshlq_u]) > -;; > -(define_insn "mve_vqshlq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VQSHLQ)) > - ] > - "TARGET_HAVE_MVE" > - "vqshl.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vqshluq_n_s]) > ;; > @@ -1540,51 +1432,6 @@ (define_insn "mve_vqshluq_n_s" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vqsubq_u, vqsubq_s]) > -;; > -(define_insn "mve_vqsubq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VQSUBQ)) > - ] > - "TARGET_HAVE_MVE" > - "vqsub.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > -;; > -;; [vrhaddq_s, vrhaddq_u]) > -;; > -(define_insn "@mve_vrhaddq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VRHADDQ)) > - ] > - "TARGET_HAVE_MVE" > - "vrhadd.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > -;; > -;; [vrmulhq_s, vrmulhq_u]) > -;; > -(define_insn "mve_vrmulhq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VRMULHQ)) > - ] > - "TARGET_HAVE_MVE" > - "vrmulh.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vrshlq_n_u, vrshlq_n_s]) > ;; > @@ -1600,21 +1447,6 @@ (define_insn "mve_vrshlq_n_" > [(set_attr "type" "mve_move") > ]) >=20 > -;; > -;; [vrshlq_s, vrshlq_u]) > -;; > -(define_insn "mve_vrshlq_" > - [ > - (set (match_operand:MVE_2 0 "s_register_operand" "=3Dw") > - (unspec:MVE_2 [(match_operand:MVE_2 1 "s_register_operand" > "w") > - (match_operand:MVE_2 2 "s_register_operand" "w")] > - VRSHLQ)) > - ] > - "TARGET_HAVE_MVE" > - "vrshl.%#\t%q0, %q1, %q2" > - [(set_attr "type" "mve_move") > -]) > - > ;; > ;; [vrshrq_n_s, vrshrq_n_u]) > ;; > diff --git a/gcc/config/arm/vec-common.md b/gcc/config/arm/vec- > common.md > index f06df4db636..918338ca5c0 100644 > --- a/gcc/config/arm/vec-common.md > +++ b/gcc/config/arm/vec-common.md > @@ -573,7 +573,7 @@ (define_expand "avg3_floor" > "ARM_HAVE__ARITH" > { > if (TARGET_HAVE_MVE) > - emit_insn (gen_mve_vhaddq (VHADDQ_S, mode, > + emit_insn (gen_mve_q (VHADDQ_S, VHADDQ_S, mode, > operands[0], operands[1], operands[2])); > else > emit_insn (gen_neon_vhadd (UNSPEC_VHADD_S, UNSPEC_VHADD_S, > mode, > @@ -588,7 +588,7 @@ (define_expand "uavg3_floor" > "ARM_HAVE__ARITH" > { > if (TARGET_HAVE_MVE) > - emit_insn (gen_mve_vhaddq (VHADDQ_U, mode, > + emit_insn (gen_mve_q (VHADDQ_U, VHADDQ_U, mode, > operands[0], operands[1], operands[2])); > else > emit_insn (gen_neon_vhadd (UNSPEC_VHADD_U, UNSPEC_VHADD_U, > mode, > @@ -603,7 +603,7 @@ (define_expand "avg3_ceil" > "ARM_HAVE__ARITH" > { > if (TARGET_HAVE_MVE) > - emit_insn (gen_mve_vrhaddq (VRHADDQ_S, mode, > + emit_insn (gen_mve_q (VRHADDQ_S, VRHADDQ_S, mode, > operands[0], operands[1], operands[2])); > else > emit_insn (gen_neon_vhadd (UNSPEC_VRHADD_S, UNSPEC_VRHADD_S, > mode, > @@ -618,7 +618,7 @@ (define_expand "uavg3_ceil" > "ARM_HAVE__ARITH" > { > if (TARGET_HAVE_MVE) > - emit_insn (gen_mve_vrhaddq (VRHADDQ_U, mode, > + emit_insn (gen_mve_q (VRHADDQ_U, VRHADDQ_U, mode, > operands[0], operands[1], operands[2])); > else > emit_insn (gen_neon_vhadd (UNSPEC_VRHADD_U, UNSPEC_VRHADD_U, > mode, > -- > 2.34.1