From: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Sandiford <Richard.Sandiford@arm.com>,
Yvan ROUX <yvan.roux@foss.st.com>
Subject: RE: [PATCH] testsuite: Skip intrinsics test if arm
Date: Wed, 28 Sep 2022 08:51:08 +0000 [thread overview]
Message-ID: <PAXPR08MB6926F8CD51D4FE4C660EADBF93549@PAXPR08MB6926.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20220927144019.194796-1-torbjorn.svensson@foss.st.com>
> -----Original Message-----
> From: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> Sent: Tuesday, September 27, 2022 3:40 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>; Richard Sandiford
> <Richard.Sandiford@arm.com>; Torbjörn SVENSSON
> <torbjorn.svensson@foss.st.com>; Yvan ROUX <yvan.roux@foss.st.com>
> Subject: [PATCH] testsuite: Skip intrinsics test if arm
>
> In the test cases, it's clearly written that intrinsics are not
> implemented on arm*. A simple xfail does not help since there are
> link error and that would cause an UNRESOLVED testcase rather than
> XFAIL.
> By changing to dg-skip-if, the entire test case is omitted.
>
Ok.
Thanks,
Kyrill
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Rephrase
> to unimplemented.
> * gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vld1x4.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vst1x2.c: Replace
> dg-xfail-if with dg-skip-if.
> * gcc.target/aarch64/advsimd-intrinsics/vst1x3.c: Likewise.
> * gcc.target/aarch64/advsimd-intrinsics/vst1x4.c: Likewise.
>
> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
> ---
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> index f933102be47..0c45a2b227b 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> /* { dg-do run } */
> -/* { dg-skip-if "unsupported" { arm*-*-* } } */
> +/* { dg-skip-if "unimplemented" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> index b20dec061b5..4174dcd064a 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> /* { dg-do run } */
> -/* { dg-skip-if "unsupported" { arm*-*-* } } */
> +/* { dg-skip-if "unimplemented" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> index e59f845880e..89b289bb21d 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> /* { dg-do run } */
> -/* { dg-skip-if "unsupported" { arm*-*-* } } */
> +/* { dg-skip-if "unimplemented" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c
> index cb13da0caed..6d20a46b8b6 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> -/* { dg-xfail-if "" { arm*-*-* } } */
> /* { dg-do run } */
> +/* { dg-skip-if "unimplemented" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c
> index 3ce272a5007..87eae4d2f35 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> -/* { dg-xfail-if "" { arm*-*-* } } */
> /* { dg-do run } */
> +/* { dg-skip-if "unimplemented" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c
> index 1f17b5342de..829a18ddac0 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c
> @@ -1,6 +1,6 @@
> /* We haven't implemented these intrinsics for arm yet. */
> -/* { dg-xfail-if "" { arm*-*-* } } */
> /* { dg-do run } */
> +/* { dg-skip-if "unimplemented" { arm*-*-* } } */
> /* { dg-options "-O3" } */
>
> #include <arm_neon.h>
> --
> 2.25.1
next prev parent reply other threads:[~2022-09-28 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 14:40 Torbjörn SVENSSON
2022-09-28 8:51 ` Kyrylo Tkachov [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-19 16:16 Torbjörn SVENSSON
2023-01-12 15:03 ` Richard Earnshaw
2023-01-15 17:06 ` Torbjorn SVENSSON
2023-01-17 17:07 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR08MB6926F8CD51D4FE4C660EADBF93549@PAXPR08MB6926.eurprd08.prod.outlook.com \
--to=kyrylo.tkachov@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).