From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smarthost2.atos.net (smtppost.atos.net [193.56.114.177]) by sourceware.org (Postfix) with ESMTPS id 052A0395BC05 for ; Wed, 2 Dec 2020 16:19:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 052A0395BC05 IronPort-SDR: XHrOXZBkkNND7qOl9UqMdmAMuJwTnVQu9bho45vWprx49pVwwMRlaQ8Xv4ODAPiFZuD+VsTI7T GNVthTtK8TWLjH/5lEyrsQV0XPOPhvLSsiRm/m41GinV7nviPgEe/ZC/ao+ncNh2Uan0I1eX8y uIpagW5p9vXLfDun0Soj1NnnoRAl0ebo9wxJVN9OKW3KxvcU4zsIZY0BsVWL95H4UcBiC3qO3/ h1PrxcNNJQvIiSVQfO2Q1QhqasK8hRhQUvXFaoj+WIE0ZaHv5jIP7E+Jp0BGcsd4PpA6Vb2dZr cg9X2kL5PX1uRx0LnZRHP+V4 X-IronPort-AV: E=Sophos;i="5.78,387,1599516000"; d="go'?scan'208,217";a="129225562" X-MGA-submission: =?us-ascii?q?MDF9qXOxAbu8imbae+QmqsNn6vy/jTjkXHY9hB?= =?us-ascii?q?89RxAW3NlchoNSana+5IBPfxY3iXp/byC6RJZeNIBAc50I4H1howAfFG?= =?us-ascii?q?/QALnrjwpHyIpSH5IzcwRYNyLz0wnCvVrGNUa7Pi+dEI+HDZrN4JlrzJ?= =?us-ascii?q?ie?= Received: from unknown (HELO GITEXCPRDMB21.ww931.my-it-solutions.net) ([10.89.29.131]) by smarthost2.atos.net with ESMTP/TLS/AES256-GCM-SHA384; 02 Dec 2020 17:14:30 +0100 Received: from GITEXCPRDMB24.ww931.my-it-solutions.net (10.89.29.134) by GITEXCPRDMB21.ww931.my-it-solutions.net (10.89.29.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 2 Dec 2020 17:14:21 +0100 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (172.16.214.171) by GITEXCPRDMB24.ww931.my-it-solutions.net (10.89.29.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4 via Frontend Transport; Wed, 2 Dec 2020 17:14:21 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qx+luNJkbpL7WuwmD9H71sx2sYFOJGKRcWIReQUi2obDtEAveYntHEAVF2q0yXzBeoldmtgaMhiuKi6N2PfKEaGIwX469gyS7q0B4ObO1rPpKnw3z1M8SOz28M1dw3h2kXysZiet7zfVEWF7/Zaq7Ol6cRcN3hGzyj9EiINESJccGH8xPbrirQYSlUPB+o16lIejcZbgpsi3RRIMKI/rco1CFqr5Ejyoe/a2oCfzSy2TV92bYLD9lYkL5J9TdpsRNvPg/eoRLhWdslRS4j8UzUoVvd3zagGAE3yYUzGw7q0THXgbH59+U+HbPb8cfsseGcJ092mIGehxUL6+DDXMnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YoknHVbS07OZnzPaOq1GFksBqyWcv91Gx4p9bMIjaOs=; b=iwufD1du+rnpQJdF2FWAQRogGozRcOo++RpQkJaQJDHWzKwE1DcU7VvBG9JKFLhpdbCv/tkb/bkSInWmob6eJVkXQb4TQNVqCpTJ73PIG8PS8k7JOSeqJTdPdFzMPB+K5W92KWHsOuYIkAIafNEa95T4S+Aza65akwb4MfqRM9cjiKzGmP3S3LaUl6M+bhQ5gLh7AOk7JUiqBPQLcD6vYke9MvFHv5tqfgTnnSHu/DM34bBOgJxmStU5yDTB8PewCjnfpmP5q9Xm4Zib6BnVtu8peg4WBJkILnnSUn1aNEtAxo9dkmn/YE2drEbRLlWkJQIUV1U8IilSVl81eUBxAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atos.net; dmarc=pass action=none header.from=atos.net; dkim=pass header.d=atos.net; arc=none Received: from PR3PR02MB6380.eurprd02.prod.outlook.com (2603:10a6:102:71::15) by PA4PR02MB6814.eurprd02.prod.outlook.com (2603:10a6:102:d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Wed, 2 Dec 2020 16:14:20 +0000 Received: from PR3PR02MB6380.eurprd02.prod.outlook.com ([fe80::b546:a51:39c4:e95b]) by PR3PR02MB6380.eurprd02.prod.outlook.com ([fe80::b546:a51:39c4:e95b%5]) with mapi id 15.20.3611.023; Wed, 2 Dec 2020 16:14:20 +0000 From: "CHIGOT, CLEMENT" To: Ian Lance Taylor CC: "gcc-patches@gcc.gnu.org" , David Edelsohn Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation Thread-Topic: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation Thread-Index: AQHWyMQOmFOAjZ/bskKj4xmRGgBicqnj+W5b Date: Wed, 2 Dec 2020 16:14:20 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Enabled=True; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SiteId=33440fc6-b7c7-412c-bb73-0e70b0198d5a; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_SetDate=2020-12-02T16:14:19.956Z; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Name=Atos For Internal Use - All Employees; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_ContentBits=0; MSIP_Label_e463cba9-5f6c-478d-9329-7b2295e4e8ed_Method=Standard; x-originating-ip: [165.225.77.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94322258-94b8-4b5f-67ec-08d896dd5374 x-ms-traffictypediagnostic: PA4PR02MB6814: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8OWXkuzvCX+kPe/86W9fFBLvZLvcsLSF7WcwAqi0clC6wh/UDXErfYD0jC0WRAFwUgxrORAwbWjNoT52oH645u09UH6tSVPX/3Hjpr3W6zzJf8JALr9iBSrbuEBrfIPyCSNKn41vmNbnuuRzLUFBOoJOF52HykoH0MabawVLomcc3RTmzdK+bQip18/r3/2QyWPTPc7MJAcJJt7PbVrUFsRjWE/NDaUscXWW2e6ISwVekhCAqE0rKAGq5TwLDPiV9UP2d7pwHvFCyjk9o6iG8X/5RPzaAte9IGiNi7X7Mzy9a+qRY7bmC1ZApxzdkar9fsfBV6HRV5KV8XDX+bLWWstiiI8TslPos5YoiCpzS+N2DxKKjn8NUAL2+pyneOlltZpQzRh+jMVw4H6aMQasbA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR02MB6380.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(66476007)(99936003)(5660300002)(76116006)(52536014)(66446008)(64756008)(71200400001)(66556008)(9686003)(55016002)(66946007)(166002)(6916009)(33656002)(66616009)(54906003)(316002)(8676002)(6506007)(19627405001)(2906002)(66574015)(8936002)(83380400001)(53546011)(186003)(55236004)(26005)(7696005)(86362001)(45080400002)(966005)(4326008)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?sh1mQhQHwzKGvZE0StHzzsp9vP+DvxvAjei2b3OnWfsA5jFGlvz3cEYNfx?= =?iso-8859-1?Q?73ftdzbtxYeX3MC3HUGzJgXf/W2jEQHZwb+hvFORrwd4Q2HFAUUdbySM40?= =?iso-8859-1?Q?ftfusltFOXGFlkUFI6Kq5jteKEKvTvNprJ05iy+/Zl9PMC8gTWYKSjfcVl?= =?iso-8859-1?Q?nS/1+QxpoMNhqQoDgWCwztSyJUOGF7F0/kOFBuFZLW4tfgnVFf+UrPdHka?= =?iso-8859-1?Q?omTRZrtqnk8IwfR1P+vYcTojRe7JQpLRWYCyZAOo+jIqnaK/fJAmv8Iy1W?= =?iso-8859-1?Q?ws6XerZctkt3LmC/rGvUpSDLPbI3fOth/LBuLPrO0lEeJNtO8abczPiAk1?= =?iso-8859-1?Q?vbN6Sy/V2puuZOBQ0fRPRRw395Xb+EVF5Laqrzg/yUcxZWs9VS7rzxiiYJ?= =?iso-8859-1?Q?aknbCDfI4lehIXJjSVGM+2ZxRQkvn2byBEaC06MuGCXPvNX5NUzjUaBivx?= =?iso-8859-1?Q?XmHlNrwOxlvUUbfryqbLOMgPY3D9Nk9jKB/KnPfmjY2bGIV4117gFQiKJY?= =?iso-8859-1?Q?/CIR4r3kiHC7snNHMJ6IPp++75bUle033ERDNX+ReVgKhmD0Vblfjkd8Xe?= =?iso-8859-1?Q?YIlg1T11x807tsBWzp9HX5aSMpOWThfAQJurQYrpD8fFxZh1ciRtPlKZ14?= =?iso-8859-1?Q?0MsIq0W5zwmEoFoNjhTIoQsPEKnaHku4uGP0RYUmGzkgDQQQRWv+aqrA9P?= =?iso-8859-1?Q?HhSTMQhK9q5PXe/aA9bfXdQ4+iF8bh7bUXi4mF+w5atVIIusLWqNyG/mEx?= =?iso-8859-1?Q?RaFrriFObJKmAfEoNeUP028lKiJkltA1+ur7XZXnDRGqs+x47jdRcwPi9Z?= =?iso-8859-1?Q?YCb3YV4THRQ34oY+kLkR3ljS/gfx3AY/6rPgFcCtcsLdIwMVPENKWu9asO?= =?iso-8859-1?Q?W4rX2TIzti7AKiSZ1AcNj36SxyL+PnibZJdwvW+C0ysQqXJRwhw2YEVTH9?= =?iso-8859-1?Q?8CwoyvvNPwm6gpTR/g/QHkpppP/hZUlMw2pbM6EGg+kcRQ1/d7fBsROP/W?= =?iso-8859-1?Q?J+S4hagai2hp5pAHg=3D?= x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_004_PR3PR02MB638047A6453130A5D050D181EAF30PR3PR02MB6380eurp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PR3PR02MB6380.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94322258-94b8-4b5f-67ec-08d896dd5374 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2020 16:14:20.3747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 33440fc6-b7c7-412c-bb73-0e70b0198d5a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPW2jMVJ5N1Xd49RDPSJADKT/FeCod/sZBjuezv5hHdwNJJzinAwPQ7w6FuPBsZaF5EAZnTUNFvaLFEgpzY4Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR02MB6814 X-OriginatorOrg: atos.net X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_ABUSEAT, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 16:19:25 -0000 --_004_PR3PR02MB638047A6453130A5D050D181EAF30PR3PR02MB6380eurp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Ian, Here is the test case. If you're compiling with -gstabs you should have a line looking like: .stabs "type..struct{Type go.bug1.ObjectIdentifier;Value [][]go.bu= g1.Extension{asn1:"set"}}:G(0,7)=3DxsStructType:",32,0,0,0 As you can see the " around for "set" aren't escaped. I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and= I don't think it's a ppc-only bug. Cl=E9ment ________________________________ From: Ian Lance Taylor Sent: Wednesday, December 2, 2020 4:55 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org ; David Edelsohn Subject: Re: [PATCH] gcc: handle double quotes in symbol name during stabst= rings generation Caution! External email. Do not open attachments or click links, unless thi= s email comes from a known sender and you know the content is safe. On Wed, Dec 2, 2020 at 4:24 AM CHIGOT, CLEMENT wr= ote: > > Since the new gccgo mangling scheme, libgo compilation is broken on AIX (= or in Linux with -gstabs) because of a type symbol having a " in its name. = I've made a patch (see attachment) in order to fix stabstring generation, b= ecause, IMO, it should be handled anyway. > However, it happens only once in the whole libgo so I don't know if this = " is intended or not. The problematic type is there: https://eur01.safelink= s.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Fgolang%2Fgo%2Fbl= ob%2Fmaster%2Fsrc%2Fcrypto%2Fx509%2Fx509.go%23L2674&data=3D04%7C01%7Ccl= ement.chigot%40atos.net%7Ce85b8b57669c47db583508d896db2fc2%7C33440fc6b7c741= 2cbb730e70b0198d5a%7C0%7C0%7C637425215428486700%7CUnknown%7CTWFpbGZsb3d8eyJ= WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= sdata=3DaB6diiR9Tgo3FTKOm0vmqVVJ%2B5JlCwd9oM5WeUaTaF4%3D&reserved=3D0. = Other similar types don't trigger the bug though. > > I've a minimal test which might can be added if you wish, in Golang tests= or in Gcc Go tests or in both ? > > If the patch is okay, could you please apply it for me ? Could you show me the small test case? I don't think I understand the problem. In DWARF I don't see any symbol names with quotation marks. I'm not yet sure that your patch is the right fix. Thanks. Ian --_004_PR3PR02MB638047A6453130A5D050D181EAF30PR3PR02MB6380eurp_ Content-Type: application/octet-stream; name="bug_stabs.go" Content-Description: bug_stabs.go Content-Disposition: attachment; filename="bug_stabs.go"; size=491; creation-date="Wed, 02 Dec 2020 16:09:24 GMT"; modification-date="Wed, 02 Dec 2020 16:09:45 GMT" Content-Transfer-Encoding: base64 cGFja2FnZSBtYWluCgppbXBvcnQgKAoJImVuY29kaW5nL2FzbjEiCikKCnR5cGUgT2JqZWN0SWRl bnRpZmllciBbXWludAoKdHlwZSBFeHRlbnNpb24gc3RydWN0IHsKCUlkICAgICAgIGFzbjEuT2Jq ZWN0SWRlbnRpZmllcgoJQ3JpdGljYWwgYm9vbCBgYXNuMToib3B0aW9uYWwiYAoJVmFsdWUgICAg W11ieXRlCn0KCmZ1bmMgZnVuYzEobm90aGluZyBib29sLCB0eXAgT2JqZWN0SWRlbnRpZmllciwg ZXh0IFtdRXh0ZW5zaW9uKSB7CglpZiBub3RoaW5nIHsKCQlyZXR1cm4KCX0KCWF0dHIgOj0gc3Ry dWN0IHsKCQlUeXBlICBPYmplY3RJZGVudGlmaWVyCgkJVmFsdWUgW11bXUV4dGVuc2lvbiBgYXNu MToic2V0ImAKCX17CgkJVHlwZTogIHR5cCwKCQlWYWx1ZTogW11bXUV4dGVuc2lvbntleHR9LAoJ fQoKCWIsIF8gOj0gYXNuMS5NYXJzaGFsKGF0dHIpCglwcmludGxuKGIpCn0KCmZ1bmMgbWFpbigp IHsKCWZ1bmMxKGZhbHNlLCBbXWludHsxfSwgIG5pbCkKfQo= --_004_PR3PR02MB638047A6453130A5D050D181EAF30PR3PR02MB6380eurp_--