Re: Who approves write-after-approval folks?

Re: Who approves write-after-approval folks?

[Hans-Peter Nilsson]

On Thu, 18 Jul 2002, Joe Buck wrote:
> The SC has to approve assigning someone as the maintainer ...
[...]
>  We also let folks with global access
> approve write-after-approval status without going through the SC.

The paragraph below talks only about those who only have
write-after-approval, which was also what I asked about.
Anyway, I think that answered my question.

Ok to commit?

Index: cvswrite.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/cvswrite.html,v
retrieving revision 1.48
diff -p -c -r1.48 cvswrite.html
*** cvswrite.html	23 Jan 2002 15:42:20 -0000	1.48
--- cvswrite.html	19 Jul 2002 13:01:17 -0000
*************** developer to follow the appropriate poli
*** 123,129 ****
    fall into one of the two previous categories.  People with write
    after approval need to submit their patches to the list; once the
    patches have been approved by the appropriate maintainers the
!   patches may be checked into the GCC sources.</p></dd>
  </dl>

  <p>The list of folks with write access to the repository can be found
--- 123,132 ----
    fall into one of the two previous categories.  People with write
    after approval need to submit their patches to the list; once the
    patches have been approved by the appropriate maintainers the
!   patches may be checked into the GCC sources.  The steering committee
!   or a person with global write permission can <a href="#authenticated">
!   approve for write access</a> any person with GNU copyright assignment
!   papers in place and known to submit good patches.</p></dd>
  </dl>

  <p>The list of folks with write access to the repository can be found

brgds, H-P

Re: Who approves write-after-approval folks?

[Gerald Pfeifer]

On Thu, 18 Jul 2002, Joe Buck wrote:
> The SC has to approve assigning someone as the maintainer for some portion
> of the compiler (e.g. a backend, a language frontend, etc).  A maintainer
> has freedom to check in code on areas of the compiler s/he controls and
> has write-after-approval elsewhere.  We also let folks with global access
> approve write-after-approval status without going through the SC.

Actually, this hasn't been restricted to global write folks but to
well-established GCC maintainers, for the last couple of years.

(Note, I'm not making rules here, just describing the status quo.)

On Fri, 19 Jul 2002, Hans-Peter Nilsson wrote:
> Ok to commit?
>
> --- 123,132 ----
>     fall into one of the two previous categories.  People with write
>     after approval need to submit their patches to the list; once the
>     patches have been approved by the appropriate maintainers the
> !   patches may be checked into the GCC sources.  The steering committee
> !   or a person with global write permission can <a href="#authenticated">
> !   approve for write access</a> any person with GNU copyright assignment
> !   papers in place and known to submit good patches.</p></dd>

Accordingly, I'd change this to "...or a well-established GCC maintainer
(including, but not limited to global write maintainers)...".

Please commit your patch with this change.

Thanks for bringing this up!
Gerald
-- 
Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/