From: "Kaveh R. GHAZI" <ghazi@caip.rutgers.edu>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Joe.Buck@synopsys.com
Subject: Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r
Date: Wed, 23 May 2007 22:57:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.58.0705231839010.4450@caipclassic.rutgers.edu> (raw)
In-Reply-To: <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com>
On Wed, 23 May 2007, Richard Guenther wrote:
> On 5/19/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> > On Thu, 17 May 2007, Richard Guenther wrote:
> >
> > > > + /* Dereference the arg_sg pointer argument. */
> > > > + arg_sg = build_fold_indirect_ref (arg_sg);
> > > > + /* Proceed iff a valid pointer type was passed in. */
> > > > + if (TYPE_MAIN_VARIANT (TREE_TYPE (arg_sg)) == integer_type_node)
> > >
> > > This check should be done earlier based on the pointed to type of the
> > > argument. Ok with this change.
> >
> > Done. I installed the revised patch below. Thanks again for your
> > reviews.
>
> This:
>
> /* Expect failures at least until mpfr-2.3.0 is released. */
> /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */
>
> doesn't work. Or did you forget a testsuite/lib patch?
> Richard.
There was no testsuite patch involved, dg-xfail-if should work just fine.
Can you provide some more info as to what exactly doesn't work? Here are
some 4.3.0 testresults posted for the trunk dated 20070523 on various
platforms. None of them show builtin-math-4.c failing:
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01156.html
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01155.html
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01153.html
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01151.html
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01143.html
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01132.html
Ah! I found one from Joe Buck that doesn't pickup the xfail:
http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01149.html
But I can't explain why. Maybe he's using an outdated version of dejagnu?
Joe?
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu
next prev parent reply other threads:[~2007-05-23 22:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 16:04 Kaveh R. GHAZI
2007-05-17 10:15 ` Richard Guenther
2007-05-19 4:23 ` Kaveh R. GHAZI
2007-05-23 21:53 ` Richard Guenther
2007-05-23 22:57 ` Kaveh R. GHAZI [this message]
2007-05-24 8:15 ` Richard Guenther
2007-05-24 10:16 ` Richard Guenther
2007-05-24 16:59 ` Janis Johnson
2007-05-24 21:09 ` Kaveh R. GHAZI
2007-05-24 22:43 ` Janis Johnson
2007-05-24 16:46 ` Joe Buck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.58.0705231839010.4450@caipclassic.rutgers.edu \
--to=ghazi@caip.rutgers.edu \
--cc=Joe.Buck@synopsys.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).