From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20942 invoked by alias); 23 May 2007 22:57:42 -0000 Received: (qmail 20919 invoked by uid 22791); 23 May 2007 22:57:35 -0000 X-Spam-Check-By: sourceware.org Received: from caip.rutgers.edu (HELO caip.rutgers.edu) (128.6.236.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 May 2007 22:57:33 +0000 Received: from caipclassic.rutgers.edu (caipclassic.rutgers.edu [128.6.237.54]) by caip.rutgers.edu (8.13.8/8.13.5) with ESMTP id l4NMvTqZ024395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 May 2007 18:57:30 -0400 Date: Wed, 23 May 2007 22:57:00 -0000 From: "Kaveh R. GHAZI" To: Richard Guenther cc: gcc-patches@gcc.gnu.org, Joe.Buck@synopsys.com Subject: Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r In-Reply-To: <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com> Message-ID: References: <84fc9c000705170315g15b30422ga7884f0779c17003@mail.gmail.com> <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-05/txt/msg01586.txt.bz2 On Wed, 23 May 2007, Richard Guenther wrote: > On 5/19/07, Kaveh R. GHAZI wrote: > > On Thu, 17 May 2007, Richard Guenther wrote: > > > > > > + /* Dereference the arg_sg pointer argument. */ > > > > + arg_sg = build_fold_indirect_ref (arg_sg); > > > > + /* Proceed iff a valid pointer type was passed in. */ > > > > + if (TYPE_MAIN_VARIANT (TREE_TYPE (arg_sg)) == integer_type_node) > > > > > > This check should be done earlier based on the pointed to type of the > > > argument. Ok with this change. > > > > Done. I installed the revised patch below. Thanks again for your > > reviews. > > This: > > /* Expect failures at least until mpfr-2.3.0 is released. */ > /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */ > > doesn't work. Or did you forget a testsuite/lib patch? > Richard. There was no testsuite patch involved, dg-xfail-if should work just fine. Can you provide some more info as to what exactly doesn't work? Here are some 4.3.0 testresults posted for the trunk dated 20070523 on various platforms. None of them show builtin-math-4.c failing: http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01156.html http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01155.html http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01153.html http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01151.html http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01143.html http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01132.html Ah! I found one from Joe Buck that doesn't pickup the xfail: http://gcc.gnu.org/ml/gcc-testresults/2007-05/msg01149.html But I can't explain why. Maybe he's using an outdated version of dejagnu? Joe? Thanks, --Kaveh -- Kaveh R. Ghazi ghazi@caip.rutgers.edu