From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21078 invoked by alias); 24 May 2007 21:09:29 -0000 Received: (qmail 21060 invoked by uid 22791); 24 May 2007 21:09:25 -0000 X-Spam-Check-By: sourceware.org Received: from caip.rutgers.edu (HELO caip.rutgers.edu) (128.6.236.16) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 May 2007 21:09:21 +0000 Received: from caipclassic.rutgers.edu (caipclassic.rutgers.edu [128.6.237.54]) by caip.rutgers.edu (8.13.8/8.13.5) with ESMTP id l4OL9B5d003002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 May 2007 17:09:13 -0400 Date: Thu, 24 May 2007 21:09:00 -0000 From: "Kaveh R. GHAZI" To: Janis Johnson cc: Richard Guenther , gcc-patches@gcc.gnu.org, Joe.Buck@synopsys.com Subject: Re: [PATCH]: PR middle-end/30250, use MPFR for lgamma_r/gamma_r In-Reply-To: <20070524164644.GA4287@us.ibm.com> Message-ID: References: <84fc9c000705170315g15b30422ga7884f0779c17003@mail.gmail.com> <84fc9c000705231453n6a9eb602u6902032267cb386a@mail.gmail.com> <84fc9c000705240111t86aedf6r40023d76a1c8a0c5@mail.gmail.com> <84fc9c000705240115g84900bdgbcbdb1c5ae21b760@mail.gmail.com> <20070524164644.GA4287@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-05/txt/msg01652.txt.bz2 On Thu, 24 May 2007, Janis Johnson wrote: > On Thu, May 24, 2007 at 10:15:22AM +0200, Richard Guenther wrote: > > On 5/24/07, Richard Guenther wrote: > > >On 5/24/07, Kaveh R. GHAZI wrote: > > >> On Wed, 23 May 2007, Richard Guenther wrote: > > >> > > >> > This: > > >> > > > >> > /* Expect failures at least until mpfr-2.3.0 is released. */ > > >> > /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */ > > >> > > > >> > doesn't work. Or did you forget a testsuite/lib patch? > > This should be: > /* { dg-xfail-if "mpfr-2.3.0" { *-*-* } { "*" } { "" } } */ > The "mpfr-2.3.0" is a comment. The lists of included and excluded > options are not optional; I'm surprised it works. > > Updating to dejagnu 1.4.4 fixed it. Luckily that still works with old tcl > > ;) > Magic. > Janis Oh okay, I thought those flags were optional because I saw it like that somewhere else (and of course it passed my own testing). Search, search, search... ah, here's one: gcc.dg/Warray-bounds.c. Anyway, I'm happy to fix the one I introduced. I also made the comment more verbose to clarify that it is in fact a comment and not some magic pattern search for an mpfr version. Tested via "make check" using mpfr-2.2.1 and mpfr-2.3.0-svn. I still get XFAIL and XPASS respectively as desired. Okay for mainline? Thanks, --Kaveh 2007-05-24 Kaveh R. Ghazi * gcc.dg/torture/builtin-math-4.c: Fix dg-xfail-if. diff -rup orig/egcc-SVN20070523/gcc/testsuite/gcc.dg/torture/builtin-math-4.c egcc-SVN20070523/gcc/testsuite/gcc.dg/torture/builtin-math-4.c --- orig/egcc-SVN20070523/gcc/testsuite/gcc.dg/torture/builtin-math-4.c 2007-05-19 00:21:55.000000000 -0400 +++ egcc-SVN20070523/gcc/testsuite/gcc.dg/torture/builtin-math-4.c 2007-05-24 17:03:41.019767099 -0400 @@ -8,7 +8,7 @@ /* { dg-do link } */ /* Expect failures at least until mpfr-2.3.0 is released. */ -/* { dg-xfail-if "mpfr-2.3.0" { *-*-* } } */ +/* { dg-xfail-if "This test requires mpfr-2.3.0" { *-*-* } { "*" } { "" } } */ /* All references to link_error should go away at compile-time. */ extern void link_error(int);