Patch for warnings in new register allocator code (ra-*.c)

Patch for warnings in new register allocator code (ra-*.c)

[Kaveh R. Ghazi]

The patch below fixes these warnings:

 > ra-build.c:1072: warning: traditional C rejects automatic aggregate initialization
 > ra-build.c:1829:33: warning: traditional C rejects the "U" suffix
 > ra-build.c:1874:29: warning: traditional C rejects the "U" suffix
 > ra-build.c:2193: warning: `check_conflict_numbers' defined but not used
 > ra-build.c:2226: warning: unused variable `d'
 > ra-debug.c:718: warning: traditional C rejects string concatenation
 > ra-debug.c:874: warning: traditional C rejects string concatenation
 > ra-debug.c:927: warning: traditional C rejects automatic aggregate initialization
 > ra-debug.c:928: warning: traditional C rejects automatic aggregate initialization
 > ra-debug.c:929: warning: traditional C rejects automatic aggregate initialization
 > ra-debug.c:930: warning: traditional C rejects automatic aggregate initialization
 > ra-debug.c:931: warning: traditional C rejects automatic aggregate initialization
 > ra-debug.c:989: warning: int format, different type arg (arg 5)
 > ra-debug.c:991: warning: int format, different type arg (arg 5)
 > ra-debug.c:993: warning: int format, different type arg (arg 5)
 > ra-debug.c:995: warning: int format, different type arg (arg 5)
 > ra-debug.c:997: warning: int format, different type arg (arg 5)
 > ra-rewrite.c:1954: warning: traditional C rejects string concatenation
 > ra-rewrite.c:1956: warning: traditional C rejects string concatenation
 > ra-rewrite.c:1958: warning: traditional C rejects string concatenation
 > ra-rewrite.c:1961: warning: traditional C rejects string concatenation
 > ra-rewrite.c:1963: warning: traditional C rejects string concatenation
 > ra-rewrite.c:669: warning: traditional C rejects automatic aggregate initialization

Note: I added new hwint.h macros for HWI formatting widths on values
assumed to be an integer but which were really HWI.  See
ra-debug.c:dump_static_insn_cost.  We already use the asterisk
specifier in a bunch of places so there shouldn't be a question of
portability to any platforms actually in use.

Bootstrapped on sparc-sun-solaris2.7 --disable-checking --disable-nls.
Ok to install?

		Thanks,
		--Kaveh


2002-07-18  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

	* hwint.h (HOST_WIDE_INT_PRINT_DEC_SPACE,
	HOST_WIDE_INT_PRINT_UNSIGNED_SPACE,
	HOST_WIDEST_INT_PRINT_DEC_SPACE, HOST_WIDEST_INT_PRINT_DEC_SPACE):
	New formatting macros.

	* ra-build.c (check_conflict_numbers): Hide unused function.
	(livethrough_conflicts_bb): Avoid automatic aggregate
	initialization.
	(parts_to_webs_1): Avoid `U' integer constant modifier.
	(conflicts_between_webs): Wrap a variable in the macro controlling
	its usage.
	* ra-debug.c (ra_debug_msg): Use VA_OPEN/VA_CLOSE.
	(dump_igraph, dump_graph_cost): Avoid string concatenation
	(dump_static_insn_cost): Avoid automatic aggregate
	initialization.  Avoid string concatenation
	* ra-rewrite.c (insert_stores): Avoid automatic aggregate
	initialization.
	(dump_cost): Avoid string concatenation

diff -rup orig/egcc-CVS20020717/gcc/hwint.h egcc-CVS20020717/gcc/hwint.h
--- orig/egcc-CVS20020717/gcc/hwint.h	Mon Dec 10 07:30:29 2001
+++ egcc-CVS20020717/gcc/hwint.h	Thu Jul 18 10:17:42 2002
@@ -72,11 +72,14 @@
 #ifndef HOST_WIDE_INT_PRINT_DEC
 # if HOST_BITS_PER_WIDE_INT == HOST_BITS_PER_INT
 #  define HOST_WIDE_INT_PRINT_DEC "%d"
+#  define HOST_WIDE_INT_PRINT_DEC_SPACE "% *d"
 # else
 #  if HOST_BITS_PER_WIDE_INT == HOST_BITS_PER_LONG
 #   define HOST_WIDE_INT_PRINT_DEC "%ld"
+#   define HOST_WIDE_INT_PRINT_DEC_SPACE "% *ld"
 #  else
 #   define HOST_WIDE_INT_PRINT_DEC "%lld"
+#   define HOST_WIDE_INT_PRINT_DEC_SPACE "% *lld"
 #  endif
 # endif
 #endif /* ! HOST_WIDE_INT_PRINT_DEC */
@@ -84,11 +87,14 @@
 #ifndef HOST_WIDE_INT_PRINT_UNSIGNED
 # if HOST_BITS_PER_WIDE_INT == HOST_BITS_PER_INT
 #  define HOST_WIDE_INT_PRINT_UNSIGNED "%u"
+#  define HOST_WIDE_INT_PRINT_UNSIGNED_SPACE "% *u"
 # else
 #  if HOST_BITS_PER_WIDE_INT == HOST_BITS_PER_LONG
 #   define HOST_WIDE_INT_PRINT_UNSIGNED "%lu"
+#   define HOST_WIDE_INT_PRINT_UNSIGNED_SPACE "% *lu"
 #  else
 #   define HOST_WIDE_INT_PRINT_UNSIGNED "%llu"
+#   define HOST_WIDE_INT_PRINT_UNSIGNED_SPACE "% *llu"
 #  endif
 # endif
 #endif /* ! HOST_WIDE_INT_PRINT_UNSIGNED */
@@ -139,13 +145,17 @@
 #   define HOST_BITS_PER_WIDEST_INT HOST_BITS_PER_LONGLONG
 #   define HOST_WIDEST_INT long long
 #   define HOST_WIDEST_INT_PRINT_DEC "%lld"
+#   define HOST_WIDEST_INT_PRINT_DEC_SPACE "% *lld"
 #   define HOST_WIDEST_INT_PRINT_UNSIGNED "%llu"
+#   define HOST_WIDEST_INT_PRINT_UNSIGNED_SPACE "% *llu"
 #   define HOST_WIDEST_INT_PRINT_HEX "0x%llx"
 #  else
 #   define HOST_BITS_PER_WIDEST_INT HOST_BITS_PER_LONG
 #   define HOST_WIDEST_INT long
 #   define HOST_WIDEST_INT_PRINT_DEC "%ld"
+#   define HOST_WIDEST_INT_PRINT_DEC_SPACE "% *ld"
 #   define HOST_WIDEST_INT_PRINT_UNSIGNED "%lu"
+#   define HOST_WIDEST_INT_PRINT_UNSIGNED_SPACE "% *lu"
 #   define HOST_WIDEST_INT_PRINT_HEX "0x%lx"
 # endif /* long long wider than long */
 #endif /* ! HOST_WIDEST_INT */
diff -rup orig/egcc-CVS20020717/gcc/ra-build.c egcc-CVS20020717/gcc/ra-build.c
--- orig/egcc-CVS20020717/gcc/ra-build.c	Tue Jul 16 10:03:52 2002
+++ egcc-CVS20020717/gcc/ra-build.c	Thu Jul 18 09:59:38 2002
@@ -101,7 +101,9 @@ static unsigned int parts_to_webs_1 PARA
 					     struct df_link *));
 static void parts_to_webs PARAMS ((struct df *));
 static void reset_conflicts PARAMS ((void));
+#if 0
 static void check_conflict_numbers PARAMS ((void));
+#endif
 static void conflicts_between_webs PARAMS ((struct df *));
 static void remember_web_was_spilled PARAMS ((struct web *));
 static void detect_spill_temps PARAMS ((void));
@@ -1069,8 +1071,10 @@ livethrough_conflicts_bb (bb)
     {
       if (INSN_P (insn))
 	{
-	  struct ra_insn_info info = insn_df[INSN_UID (insn)];
 	  unsigned int n;
+	  struct ra_insn_info info;
+
+	  info = insn_df[INSN_UID (insn)];
 	  for (n = 0; n < info.num_defs; n++)
 	    bitmap_set_bit (all_defs, DF_REF_ID (info.defs[n]));
 	  if (TEST_BIT (insns_with_deaths, INSN_UID (insn)))
@@ -1826,7 +1830,7 @@ parts_to_webs_1 (df, copy_webs, all_refs
       if (! wp->uplink)
 	{
 	  /* If we have a web part root, create a new web.  */
-	  unsigned int newid = ~0U;
+	  unsigned int newid = ~(unsigned)0;
 	  unsigned int old_web = 0;
 
 	  /* In the first pass, there are no old webs, so unconditionally
@@ -1871,7 +1875,7 @@ parts_to_webs_1 (df, copy_webs, all_refs
 		    }
 		}
 	      /* The id is zeroed in init_one_web().  */
-	      if (newid == ~0U)
+	      if (newid == ~(unsigned)0)
 		newid = web->id;
 	      if (old_web)
 		reinit_one_web (web, GET_CODE (reg) == SUBREG
@@ -2188,6 +2192,7 @@ reset_conflicts ()
 /* For each web check it's num_conflicts member against that
    number, as calculated from scratch from all neighbors.  */
 
+#if 0
 static void
 check_conflict_numbers ()
 {
@@ -2204,6 +2209,7 @@ check_conflict_numbers ()
 	abort ();
     }
 }
+#endif
 
 /* Convert the conflicts between web parts to conflicts between full webs.
 
@@ -2223,7 +2229,9 @@ conflicts_between_webs (df)
      struct df *df;
 {
   unsigned int i;
+#ifdef STACK_REGS
   struct dlist *d;
+#endif
   bitmap ignore_defs = BITMAP_XMALLOC ();
   unsigned int have_ignored;
   unsigned int *pass_cache = (unsigned int *) xcalloc (num_webs, sizeof (int));
diff -rup orig/egcc-CVS20020717/gcc/ra-debug.c egcc-CVS20020717/gcc/ra-debug.c
--- orig/egcc-CVS20020717/gcc/ra-debug.c	Mon Jul 15 10:07:05 2002
+++ egcc-CVS20020717/gcc/ra-debug.c	Thu Jul 18 11:14:26 2002
@@ -47,22 +47,12 @@ static const char *const reg_class_names
 void
 ra_debug_msg VPARAMS ((unsigned int level, const char *format, ...))
 {
-#ifndef ANSI_PROTOTYPES
-  int level;
-  const char *format;
-#endif
-  va_list ap;
+  VA_OPEN (ap, format);
+  VA_FIXEDARG (ap, unsigned int, level);
+  VA_FIXEDARG (ap, const char *, format);
   if ((debug_new_regalloc & level) != 0 && rtl_dump_file != NULL)
-    {
-      VA_START (ap, format);
-
-#ifndef ANSI_PROTOTYPES
-      format = va_arg (ap, const char *);
-#endif
-
-      vfprintf (rtl_dump_file, format, ap);
-      va_end (ap);
-    }
+    vfprintf (rtl_dump_file, format, ap);
+  VA_CLOSE (ap);
 }
 
 
@@ -714,10 +704,10 @@ dump_igraph (df)
 	  ra_debug_msg (DUMP_WEBS, " sub %d", SUBREG_BYTE (web->orig_x));
 	  ra_debug_msg (DUMP_WEBS, " par %d", find_web_for_subweb (web)->id);
 	}
-      ra_debug_msg (DUMP_WEBS, " +%d (span %d, cost "
-		 HOST_WIDE_INT_PRINT_DEC ") (%s)",
-	         web->add_hardregs, web->span_deaths, web->spill_cost,
-	         reg_class_names[web->regclass]);
+      ra_debug_msg (DUMP_WEBS, " +%d (span %d, cost ",
+		    web->add_hardregs, web->span_deaths);
+      ra_debug_msg (DUMP_WEBS, HOST_WIDE_INT_PRINT_DEC, web->spill_cost);
+      ra_debug_msg (DUMP_WEBS, ") (%s)", reg_class_names[web->regclass]);
       if (web->spill_temp == 1)
 	ra_debug_msg (DUMP_WEBS, " (spilltemp)");
       else if (web->spill_temp == 2)
@@ -860,7 +850,6 @@ dump_graph_cost (level, msg)
 {
   unsigned int i;
   unsigned HOST_WIDE_INT cost;
-#define LU HOST_WIDE_INT_PRINT_UNSIGNED
   if (!rtl_dump_file || (debug_new_regalloc & level) == 0)
     return;
 
@@ -871,9 +860,9 @@ dump_graph_cost (level, msg)
       if (alias (web)->type == SPILLED)
 	cost += web->orig_spill_cost;
     }
-  ra_debug_msg (level, " spill cost of graph (%s) = " LU "\n",
-	     msg ? msg : "", cost);
-#undef LU
+  ra_debug_msg (level, " spill cost of graph (%s) = ", msg ? msg : "");
+  ra_debug_msg (level, HOST_WIDE_INT_PRINT_UNSIGNED, cost);
+  ra_debug_msg (level, "\n");
 }
 
 /* Dump the color assignment per web, the coalesced and spilled webs.  */
@@ -924,12 +913,13 @@ dump_static_insn_cost (file, message, pr
       unsigned HOST_WIDE_INT cost;
       unsigned int count;
     };
-  struct cost load = {0, 0};
-  struct cost store = {0, 0};
-  struct cost regcopy = {0, 0};
-  struct cost selfcopy = {0, 0};
-  struct cost overall = {0, 0};
   basic_block bb;
+  struct cost load, store, regcopy, selfcopy, overall;
+  memset (&load, 0, sizeof(load));
+  memset (&store, 0, sizeof(store));
+  memset (&regcopy, 0, sizeof(regcopy));
+  memset (&selfcopy, 0, sizeof(selfcopy));
+  memset (&overall, 0, sizeof(overall));
 
   if (!file)
     return;
@@ -985,16 +975,21 @@ dump_static_insn_cost (file, message, pr
   if (!prefix)
     prefix = "";
   fprintf (file, "static insn cost %s\n", message ? message : "");
-  fprintf (file, "  %soverall:\tnum=%6d\tcost=%8d\n", prefix, overall.count,
-	   overall.cost);
-  fprintf (file, "  %sloads:\tnum=%6d\tcost=%8d\n", prefix, load.count,
-	   load.cost);
-  fprintf (file, "  %sstores:\tnum=%6d\tcost=%8d\n", prefix,
-	   store.count, store.cost);
-  fprintf (file, "  %sregcopy:\tnum=%6d\tcost=%8d\n", prefix, regcopy.count,
-	   regcopy.cost);
-  fprintf (file, "  %sselfcpy:\tnum=%6d\tcost=%8d\n", prefix, selfcopy.count,
-	   selfcopy.cost);
+  fprintf (file, "  %soverall:\tnum=%6d\tcost=", prefix, overall.count);
+  fprintf (file, HOST_WIDE_INT_PRINT_DEC_SPACE, 8, overall.cost);
+  fprintf (file, "\n");
+  fprintf (file, "  %sloads:\tnum=%6d\tcost=", prefix, load.count);
+  fprintf (file, HOST_WIDE_INT_PRINT_DEC_SPACE, 8, load.cost);
+  fprintf (file, "\n");
+  fprintf (file, "  %sstores:\tnum=%6d\tcost=", prefix, store.count);
+  fprintf (file, HOST_WIDE_INT_PRINT_DEC_SPACE, 8, store.cost);
+  fprintf (file, "\n");
+  fprintf (file, "  %sregcopy:\tnum=%6d\tcost=", prefix, regcopy.count);
+  fprintf (file, HOST_WIDE_INT_PRINT_DEC_SPACE, 8, regcopy.cost);
+  fprintf (file, "\n");
+  fprintf (file, "  %sselfcpy:\tnum=%6d\tcost=", prefix, selfcopy.count);
+  fprintf (file, HOST_WIDE_INT_PRINT_DEC_SPACE, 8, selfcopy.cost);
+  fprintf (file, "\n");
 }
 
 /* Returns nonzero, if WEB1 and WEB2 have some possible
diff -rup orig/egcc-CVS20020717/gcc/ra-rewrite.c egcc-CVS20020717/gcc/ra-rewrite.c
--- orig/egcc-CVS20020717/gcc/ra-rewrite.c	Tue Jul 16 10:03:52 2002
+++ egcc-CVS20020717/gcc/ra-rewrite.c	Thu Jul 18 10:57:50 2002
@@ -666,9 +666,11 @@ insert_stores (new_deaths)
       if (uid < insn_df_max_uid)
 	{
 	  unsigned int n;
-	  struct ra_insn_info info = insn_df[uid];
 	  rtx following = NEXT_INSN (insn);
 	  basic_block bb = BLOCK_FOR_INSN (insn);
+	  struct ra_insn_info info;
+
+	  info = insn_df[uid];
 	  for (n = 0; n < info.num_defs; n++)
 	    {
 	      struct web *web = def2web[DF_REF_ID (info.defs[n])];
@@ -1949,20 +1951,18 @@ void
 dump_cost (level)
      unsigned int level;
 {
-#define LU HOST_WIDE_INT_PRINT_UNSIGNED
   ra_debug_msg (level, "Instructions for spilling\n added:\n");
-  ra_debug_msg (level, "  loads =%d cost=" LU "\n", emitted_spill_loads,
-	     spill_load_cost);
-  ra_debug_msg (level, "  stores=%d cost=" LU "\n", emitted_spill_stores,
-	     spill_store_cost);
-  ra_debug_msg (level, "  remat =%d cost=" LU "\n", emitted_remat,
-	     spill_remat_cost);
-  ra_debug_msg (level, " removed:\n");
-  ra_debug_msg (level, "  moves =%d cost=" LU "\n", deleted_move_insns,
-	     deleted_move_cost);
-  ra_debug_msg (level, "  others=%d cost=" LU "\n", deleted_def_insns,
-	     deleted_def_cost);
-#undef LU
+  ra_debug_msg (level, "  loads =%d cost=", emitted_spill_loads);
+  ra_debug_msg (level, HOST_WIDE_INT_PRINT_UNSIGNED, spill_load_cost);
+  ra_debug_msg (level, "\n  stores=%d cost=", emitted_spill_stores);
+  ra_debug_msg (level, HOST_WIDE_INT_PRINT_UNSIGNED, spill_store_cost);
+  ra_debug_msg (level, "\n  remat =%d cost=", emitted_remat);
+  ra_debug_msg (level, HOST_WIDE_INT_PRINT_UNSIGNED, spill_remat_cost);
+  ra_debug_msg (level, "\n removed:\n  moves =%d cost=", deleted_move_insns);
+  ra_debug_msg (level, HOST_WIDE_INT_PRINT_UNSIGNED, deleted_move_cost);
+  ra_debug_msg (level, "\n  others=%d cost=", deleted_def_insns);
+  ra_debug_msg (level, HOST_WIDE_INT_PRINT_UNSIGNED, deleted_def_cost);
+  ra_debug_msg (level, "\n");
 }
 
 /* Initialization of the rewrite phase.  */

Re: Patch for warnings in new register allocator code (ra-*.c)

[Michael Matz]

Hi,

On Thu, 18 Jul 2002, Kaveh R. Ghazi wrote:

> The patch below fixes these warnings:

Thank you very much.

> Ok to install?

I'm not sure I have any say here, but at least to me it would be.


Ciao,
Michael.

Re: Patch for warnings in new register allocator code (ra-*.c)

[David Edelsohn]

	For the ra* files, I think that you are the MAINTAINER.  That
probably is implicit in accepting your work: you need to continue to
maintain it.

David

Add myself to MAINTAINERS

[Michael Matz]

Hi,

On Thu, 18 Jul 2002, David Edelsohn wrote:

> 	For the ra* files, I think that you are the MAINTAINER.  That
> probably is implicit in accepting your work: you need to continue to
> maintain it.

Ok then, when someone OK's this patch I am ;)


Ciao,
Michael.
-- 
        * MAINTAINERS: Add myself as ra* maintainer.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.224
diff -u -p -r1.224 MAINTAINERS
--- MAINTAINERS 15 Jul 2002 21:17:51 -0000      1.224
+++ MAINTAINERS 19 Jul 2002 11:11:07 -0000
@@ -145,6 +145,7 @@ RTEMS Ports         Joel Sherrill
 predict.def            Jan Hubicka             jh@suse.cz
 contrib/regression     Geoff Keating           geoffk@redhat.com
 treelang                Tim Josling             tej@melbpc.org.au
+new regalloc (ra*)     Michael Matz            matz@suse.de

 Note individuals who maintain parts of the compiler need approval to check
 in changes outside of the parts of the compiler they maintain.

Re: Add myself to MAINTAINERS

[Richard Henderson]

On Fri, Jul 19, 2002 at 01:11:37PM +0200, Michael Matz wrote:
>         * MAINTAINERS: Add myself as ra* maintainer.

Ok.


r~

Re: Patch for warnings in new register allocator code (ra-*.c)

[Kaveh R. Ghazi]

 > From: Michael Matz <matz@suse.de>
 > 
 > Hi,
 > 
 > On Thu, 18 Jul 2002, Kaveh R. Ghazi wrote:
 > 
 > > Ok to install?
 > 
 > I'm not sure I have any say here, but at least to me it would be.
 > Michael.

Thanks, I think you should be the maintainer for the ra bits.  However
I'd still like to get approval for the hwint.h patch before it goes in.

--
Kaveh R. Ghazi			Director of Systems Architecture
ghazi@caip.rutgers.edu		Qwest Solutions

Re: Patch for warnings in new register allocator code (ra-*.c)

[Kaveh R. Ghazi]

 > From: "Kaveh R. Ghazi"
 > 
 >  > From: Michael Matz
 >  > 
 >  > Hi,
 >  > 
 >  > On Thu, 18 Jul 2002, Kaveh R. Ghazi wrote:
 >  > 
 >  > > Ok to install?
 >  > 
 >  > I'm not sure I have any say here, but at least to me it would be.
 >  > Michael.
 > 
 > Thanks, I think you should be the maintainer for the ra bits.  However
 > I'd still like to get approval for the hwint.h patch before it goes in.

I went ahead and installed the ra-* bits that didn't depend on the
hwint.h change.  I'll repost that separately.  Thanks for the review.

		--Kaveh
--
Kaveh R. Ghazi			Director of Systems Architecture
ghazi@caip.rutgers.edu		Qwest Solutions

Add myself to MAINTAINERS

[Adam Nemet]

Hi,

I've commited this one as my first check-in.

Adam

2002-11-04  Adam Nemet  <anemet@lnxw.com>

	* MAINTAINERS (Write After Approval): Add myself.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.243
diff -u -p -r1.243 -r1.244
--- MAINTAINERS	28 Oct 2002 09:26:58 -0000	1.243
+++ MAINTAINERS	5 Nov 2002 05:14:42 -0000
@@ -216,6 +216,7 @@ Adam Megacz					adam@xwt.org
 Alan Modra					amodra@bigpond.net.au
 Toon Moene					toon@moene.indiv.nluug.nl
 Catherine Moore					clm@redhat.com
+Adam Nemet					anemet@lnxw.com
 Nathanael Nerode				neroden@gcc.gnu.org
 Diego Novillo					dnovillo@redhat.com
 David O'Brien					obrien@FreeBSD.org

Add myself to MAINTAINERS

[Stuart Hastings]

2002-11-13 Stuart Hastings <stuart@apple.com>

	* MAINTAINERS: Add myself to write-after-approval list.

stuart hastings
Apple Computer

Index: gccx/MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.245
diff -c -d -c -3 -p -r1.245 MAINTAINERS
*** gccx/MAINTAINERS    11 Nov 2002 00:50:09 -0000      1.245
--- gccx/MAINTAINERS    13 Nov 2002 17:53:47 -0000
*************** Anthony Green                                   
green@redhat.com
*** 185,190 ****
--- 185,191 ----
   Stu Grossman                                  grossman@redhat.com
   Laurent Guerby                                        guerby@acm.org
   Andrew Haley                                  aph@redhat.com
+ Stuart Hastings                                       stuart@apple.com
   Aldy Hernandez                                        aldyh@redhat.com
   Matthew Hiller                                        
hiller@redhat.com
   Manfred Hollstein                             mhollstein@redhat.com

Re: Add myself to MAINTAINERS

[Mike Stump]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

On Thursday, November 14, 2002, at 09:34 AM, Stuart Hastings wrote:
>>> 	* MAINTAINERS: Add myself to write-after-approval list.
>>
>> Would you mind making this update on the 3.2-branch as well?

>> (Other Apple folks probably also should do that, so in case you meet 
>> them for
>> lunch...
>
> Devang & Matt: You've been asked to add yourselves to the 
> "gcc-3_2-branch" of the MAINTAINERS file.
>
> Mike & Geoff: In the 3.2 branch of the MAINTAINERS file, you're both 
> listed with previous email addresses.

:-(  I was tempted to just remerge the whole file!  Anyway, I remerged 
all the various apple people.


[-- Attachment #2: to-fsf-5.diffs --]
[-- Type: application/octet-stream, Size: 2835 bytes --]

Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.205.2.4.4.8
diff -u -p -u -r1.205.2.4.4.8 MAINTAINERS
--- MAINTAINERS	14 Nov 2002 18:30:35 -0000	1.205.2.4.4.8
+++ MAINTAINERS	14 Nov 2002 18:58:39 -0000
@@ -23,7 +23,7 @@ Maintainers
 John Carr					jfc@mit.edu
 Richard Earnshaw				rearnsha@arm.com
 Richard Henderson                               rth@redhat.com
-Geoffrey Keating				geoffk@redhat.com
+Geoffrey Keating				geoffk@geoffk.org
 Richard Kenner					kenner@nyu.edu
 Jeff Law					law@redhat.com
 Jason Merrill					jason@redhat.com
@@ -64,7 +64,7 @@ mmix port		Hans-Peter Nilsson	hp@bitrang
 mn10200 port		Jeff Law		law@redhat.com
 mn10300 port		Jeff Law		law@redhat.com
 mn10300 port		Alexandre Oliva		aoliva@redhat.com
-rs6000 port		Geoff Keating		geoffk@redhat.com
+rs6000 port		Geoff Keating		geoffk@geoffk.org
 rs6000 port		David Edelsohn		dje@watson.ibm.com
 s390 port		Hartmut Penner		hpenner@de.ibm.com
 s390 port		Ulrich Weigand		uweigand@de.ibm.com
@@ -77,7 +77,7 @@ v850 port		Nick Clifton		nickc@redhat.co
 v850 port		Michael Meissner	meissner@redhat.com
 vax port		Dave Anglin		dave.anglin@nrc.ca
 x86-64 port		Jan Hubicka		jh@suse.cz
-xstormy16 port		Geoffrey Keating	geoffk@redhat.com
+xstormy16 port		Geoffrey Keating	geoffk@geoffk.org
 xtensa port		Bob Wilson		bob.wilson@acm.org
 
 			OS Port Maintainers	(OS alphabetical order)
@@ -142,13 +142,15 @@ docs co-maintainer	Joseph Myers		jsm28@c
 Pico-Java port		Steve Chamberlain	sac@transmeta.com
 RTEMS Ports		Joel Sherrill
 predict.def		Jan Hubicka		jh@suse.cz
-contrib/regression	Geoff Keating		geoffk@redhat.com
+contrib/regression	Geoff Keating		geoffk@geoffk.org
 
 Note individuals who maintain parts of the compiler need approval to check
 in changes outside of the parts of the compiler they maintain.
 
 
 			Write After Approval	(last name alphabetical order)
+
+Matt Austern                                    austern@apple.com
 Scott Bambrough					scottb@netwinder.org
 Daniel Berlin					dan@dberlin.org
 David Billinghurst				David.Billinghurst@riotinto.com
@@ -208,6 +210,7 @@ David O'Brien					obrien@FreeBSD.org
 Turly O'Connor					turly@apple.com
 Jeffrey D. Oldham				oldham@codesourcery.com
 Rainer Orth					ro@TechFak.Uni-Bielefeld.DE
+Devang Patel					dpatel@apple.com
 Nicola Pero					n.pero@mi.flashnet.it
 Alexandre Petit-Bianco				apbianco@redhat.com
 Clinton Popetz					cpopetz@cpopetz.com
@@ -230,7 +233,7 @@ Danny Smith					dannysmith@users.sourcef
 Michael Sokolov					msokolov@ivan.Harhan.ORG
 Richard Stallman				rms@gnu.org
 Graham Stott					grahams@redhat.com
-Mike Stump					mrs@windriver.com
+Mike Stump					mrs@apple.com
 Ian Taylor					ian@zembu.com
 Michael Tiemann					tiemann@redhat.com
 Philipp Thomas					pthomas@suse.de

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]

Re: Add myself to MAINTAINERS

[Zack Weinberg]

Mike Stump <mrs@apple.com> writes:

> :-(  I was tempted to just remerge the whole file!  Anyway, I remerged
> all the various apple people.

It seems to me that this file should be identical in all active
branches.

zw

Re: Add myself to MAINTAINERS

[Gerald Pfeifer]

On Thu, 14 Nov 2002, Zack Weinberg wrote:
> It seems to me that this file should be identical in all active
> branches.

In principle, yes, though these active branches may well have some
differences (just consider removed ports, new ports, front ends,
passes,...).

Gerald
-- 
Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/

Add myself to MAINTAINERS

[Eric Botcazou]

2002-11-15  Eric Botcazou  <ebotcazou@libertysurf.fr>

	* MAINTAINERS (Write After Approval): Add myself.


Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.247
diff -u -r1.247 MAINTAINERS
--- MAINTAINERS 14 Nov 2002 18:07:31 -0000      1.247
+++ MAINTAINERS 15 Nov 2002 14:39:36 -0000
@@ -169,6 +169,7 @@
 Jim Blandy                                     jimb@redhat.com
 Phil Blundell                                  pb@futuretv.com
 Hans Boehm                                     hboehm@gcc.gnu.org
+Eric Botcazou                                  ebotcazou@libertysurf.fr
 Andrew Cagney                                  cagney@redhat.com
 Chandra Chavva                                 cchavva@redhat.com
 William Cohen                                  wcohen@redhat.com


-- 
Eric Botcazou

Add myself to MAINTAINERS

[Steven Bosscher]

Installed on mainline.

2003-02-24  Steven Bosscher  <steven@gcc.gnu.org>

	* MAINTAINERS (Write after approval): Add myself.

Greetz
Steven


Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.265
diff -c -3 -p -r1.265 MAINTAINERS
*** MAINTAINERS	22 Feb 2003 00:04:11 -0000	1.265
--- MAINTAINERS	24 Feb 2003 09:26:46 -0000
*************** Eric Blake					ericb@gcc.gnu.org
*** 170,175 ****
--- 170,176 ----
  Jim Blandy					jimb@redhat.com
  Phil Blundell					pb@futuretv.com
  Hans Boehm					hboehm@gcc.gnu.org
+ Steven Bosscher					steven@gcc.gnu.org
  Eric Botcazou					ebotcazou@libertysurf.fr
  Andrew Cagney					cagney@redhat.com
  Chandra Chavva					cchavva@redhat.com

Add myself to MAINTAINERS

[Daniel Jacobowitz]

I must have missed doing this when I got an account.  Since I can commit
this, it's obviously correct :)

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2004-01-15  Daniel Jacobowitz  <drow@mvista.com>

	* MAINTAINERS: Add myself to write-after-approval.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.331
diff -u -p -r1.331 MAINTAINERS
--- MAINTAINERS	15 Jan 2004 14:24:19 -0000	1.331
+++ MAINTAINERS	15 Jan 2004 22:54:05 -0000
@@ -213,6 +213,7 @@ Matthew Hiller					hiller@redhat.com
 Manfred Hollstein				mh@suse.com
 Falk Hueffner					falk@debian.org
 Bernardo Innocenti				bernie@develer.com
+Daniel Jacobowitz				dan@debian.org
 Andreas Jaeger					aj@suse.de
 Fariborz Jahanian				fjahanian@apple.com
 Dale Johannesen 				dalej@apple.com

Add myself to MAINTAINERS

[Kaz Kojima]

I've add myself to MAINTAINERS as sh libraries/configury maintainer.

Regards,
	kaz
--
2005-10-05  Kaz Kojima  <kkojima@gcc.gnu.org>

	* MAINTAINERS: Add self as sh libraries/configury maintainer.

Index: MAINTAINERS
===================================================================
RCS file: /cvs/gcc/gcc/MAINTAINERS,v
retrieving revision 1.438
diff -u -r1.438 MAINTAINERS
--- MAINTAINERS	16 Sep 2005 16:59:40 -0000	1.438
+++ MAINTAINERS	5 Oct 2005 13:42:58 -0000
@@ -76,6 +76,7 @@
 s390 port		Ulrich Weigand		uweigand@de.ibm.com
 sh port			Joern Rennecke		joern.rennecke@st.com
 sh port			Alexandre Oliva		aoliva@redhat.com
+sh libraries/configury	Kaz Kojima		kkojima@gcc.gnu.org
 sparc port		Richard Henderson	rth@redhat.com
 sparc port		David S. Miller		davem@redhat.com
 sparc port		Jakub Jelinek		jakub@redhat.com

Add myself to MAINTAINERS

[Mark Shinwell]

Committed as obvious.

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 113884)
+++ MAINTAINERS	(working copy)
@@ -335,6 +335,7 @@ Matthew Sachs					msachs@apple.com
  Alex Samuel					samuel@codesourcery.com
  Svein Seldal                                    svein@dev.seldal.com
  Thiemo Seufer					ths@networkno.de
+Mark Shinwell					shinwell@codesourcery.com
  Franz Sirl					franz.sirl-kernel@lauterbach.com
  Michael Sokolov					msokolov@ivan.Harhan.ORG
  Richard Stallman				rms@gnu.org

Re: Add myself to MAINTAINERS

[Mike Stump]

On May 18, 2006, at 4:52 AM, Mark Shinwell wrote:
> Committed as obvious.
>
> Index: MAINTAINERS

These are never obvious, this would have to be previously approved by  
someone, that someone should be named here.

Re: Add myself to MAINTAINERS

[Paul Brook]

On Thursday 18 May 2006 18:00, Mike Stump wrote:
> On May 18, 2006, at 4:52 AM, Mark Shinwell wrote:
> > Committed as obvious.
> >
> > Index: MAINTAINERS
>
> These are never obvious, this would have to be previously approved by
> someone, that someone should be named here.

I'd say the fact that someone has been granted write access to the repository 
counts as pre-approval.

From http://gcc.gnu.org/svnwrite.html#authenticated

"Once we have this information we will set up an account on gcc.gnu.org and 
inform you by mail. At this point you should be able to check out a tree with 
SVN and add yourself to the MAINTAINERS file to test write access, following 
the instructions below"

Admittedly "following instructions below" is somewhat vague, but I was under 
the impression that anyone with write-after-approval access should 
automatically add themselves to the MAINTAINERS file.

Paul

Re: Add myself to MAINTAINERS

[Mike Stump]

It would be nice to have the audit trail of who ultimately approved  
the change, as I don't think otherwise there is any indication on any  
of the gcc lists of who it was, that's all.

Also, not all people that have access have permission (last I knew).

Re: Add myself to MAINTAINERS

[Gerald Pfeifer]

On Thu, 18 May 2006, Paul Brook wrote:
> I'd say the fact that someone has been granted write access to the 
> repository counts as pre-approval.

Absolutely.

> From http://gcc.gnu.org/svnwrite.html#authenticated
> 
> "Once we have this information we will set up an account on gcc.gnu.org and 
> inform you by mail. At this point you should be able to check out a tree with 
> SVN and add yourself to the MAINTAINERS file to test write access, following 
> the instructions below"
> 
> Admittedly "following instructions below" is somewhat vague, but I was 
> under the impression that anyone with write-after-approval access should 
> automatically add themselves to the MAINTAINERS file.

Should as in RFC lingo, yes.  Do you have a proposal on how to improve
wording of this page, Paul (or Mark)?  We want our documentation to be
as clear as possible.

Gerald

Re: Add myself to MAINTAINERS

[Mark Shinwell]

Gerald Pfeifer wrote:
>> Admittedly "following instructions below" is somewhat vague, but I was 
>> under the impression that anyone with write-after-approval access should 
>> automatically add themselves to the MAINTAINERS file.
> 
> Should as in RFC lingo, yes.  Do you have a proposal on how to improve
> wording of this page, Paul (or Mark)?  We want our documentation to be
> as clear as possible.

How about:

"Once we have this information we will set up an account on
<code>gcc.gnu.org</code> and inform you by mail. At this point you should
check out a tree with SVN using the instructions below and add yourself
to the MAINTAINERS file.  Having done this, you should produce a diff to
this file and circulate it to the <code>gcc-patches<code> list, whilst also
checking in your change to test write access.  For all other changes, please
be sure to follow the write access policies below."

Mark

Re: Add myself to MAINTAINERS

[Gerald Pfeifer]

On Fri, 19 May 2006, Mark Shinwell wrote:
> How about:

Thanks for the proposal, Mark!

> "Once we have this information we will set up an account on
> <code>gcc.gnu.org</code> and inform you by mail. At this point you should
> check out a tree with SVN using the instructions below and add yourself
> to the MAINTAINERS file.  Having done this, you should produce a diff to
> this file and circulate it to the <code>gcc-patches<code> list, whilst also
> checking in your change to test write access.  For all other changes, please
> be sure to follow the write access policies below."

I like this.

I'd prefer to omit "with SVN" (which will make the migration easier in 
case we switch version control systems at some point in the future) and
would omit the two occurrences of "you should", but these are only two
minor nits.  Thanks for the patch!

Gerald

Re: Add myself to MAINTAINERS

[Mark Shinwell]

Gerald Pfeifer wrote:
>> "Once we have this information we will set up an account on
>> <code>gcc.gnu.org</code> and inform you by mail. At this point you should
>> check out a tree with SVN using the instructions below and add yourself
>> to the MAINTAINERS file.  Having done this, you should produce a diff to
>> this file and circulate it to the <code>gcc-patches<code> list, whilst also
>> checking in your change to test write access.  For all other changes, please
>> be sure to follow the write access policies below."
> 
> I like this.
> 
> I'd prefer to omit "with SVN" (which will make the migration easier in 
> case we switch version control systems at some point in the future) and
> would omit the two occurrences of "you should", but these are only two
> minor nits.  Thanks for the patch!

I've adjusted the wording a little; here is the exact patch.

OK to commit?

Mark


Index: svnwrite.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v
retrieving revision 1.11
diff -U3 -r1.11 svnwrite.html
--- svnwrite.html       18 May 2006 11:57:24 -0000      1.11
+++ svnwrite.html       24 May 2006 08:29:28 -0000
@@ -46,9 +46,14 @@
  <code>ssh-keygen</code> program) and other details.</p>

  <p>Once we have this information we will set up an account on
-gcc.gnu.org and inform you by mail.  At this point you
-should be able to check out a tree with SVN and add yourself to the
-MAINTAINERS file to test write access, following the instructions below.</p>
+<code>gcc.gnu.org</code> and inform you by mail. At this point,
+check out a tree using the instructions below and add yourself
+to the MAINTAINERS file.  Then produce a diff to
+that file and circulate it to the <code>gcc-patches</code> list, whilst also
+checking in your change to test write access (approval from the mailing
+list is not needed in this one case).  For all other changes, please
+be sure to follow the write access policies below.
+</p>

  <hr />
  <h2><a name="setup">Setting up your local SVN tree</a></h2>

Re: Add myself to MAINTAINERS

[Gerald Pfeifer]

On Wed, 24 May 2006, Mark Shinwell wrote:
> OK to commit?

Yes, thanks!

Gerald

Re: Add myself to MAINTAINERS

[Nathan Sidwell]

Mike Stump wrote:
> On May 18, 2006, at 4:52 AM, Mark Shinwell wrote:
> 
>> Committed as obvious.
>>
>> Index: MAINTAINERS
> 
> 
> These are never obvious, this would have to be previously approved by  
> someone, that someone should be named here.

It woz me wot dun it, guv

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Add myself to MAINTAINERS

[Fu, Chao-Ying]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hello,

  I added myself to MAINTAINERS.  Thanks!

Regards,
Chao-ying

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 117148)
+++ ChangeLog   (working copy)
@@ -1,3 +1,7 @@
+2006-09-22  Chao-ying Fu  <fu@mips.com>
+
+       * MAINTAINERS (Write After Approval): Add myself.
+
 2006-09-10  Joseph S. Myers  <joseph@codesourcery.com>

        * MAINTAINERS: Add self as soft-fp maintainer.

[-- Attachment #2: MAINTAINERS.diff --]
[-- Type: application/octet-stream, Size: 342 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 117148)
+++ MAINTAINERS	(working copy)
@@ -368,6 +368,7 @@
 Jie Zhang					jie.zhang@analog.com
 Jon Ziegler					jonz@apple.com
 Josef Zlomek					josef.zlomek@email.cz
+Chao-ying Fu					fu@mips.com
 
 Bug database only accounts
 

Add myself to MAINTAINERS.

[Dave Korn]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]



  I have been approved for WAA access, so ...


2007-04-02  Dave Korn  <dave.korn@artimi.com>

	* MAINTAINERS (Write After Approval): Add myself.

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

[-- Attachment #2: add-me.diff --]
[-- Type: application/octet-stream, Size: 478 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 123397)
+++ MAINTAINERS	(working copy)
@@ -306,6 +306,7 @@ Mumit Khan					khan@xraylith.wisc.edu
 Matthias Klose					doko@debian.org
 Jeff Knaggs					jknaggs@redhat.com
 Michael Koch					konqueror@gmx.de
+Dave Korn					dave.korn@artimi.com
 Matt Kraai					kraai@ftbfs.org
 Andreas Krebbel					krebbel1@de.ibm.com
 Maxim Kuvyrkov					mkuvyrkov@ispras.ru

add myself to MAINTAINERS

[Christian BRUEL]

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]

2007-04-04  Christian Bruel  <christian.bruel@st.com>

         * MAINTAINERS (Write After Approval): Add myself.

[-- Attachment #2: cb.patch --]
[-- Type: text/plain, Size: 462 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 123490)
+++ MAINTAINERS	(working copy)
@@ -258,6 +258,7 @@
 Robert Bowdidge                                 bowdidge@apple.com
 Joel Brobecker					brobecker@gnat.com
 Dave Brolley					brolley@redhat.com
+Christian Bruel					christian.bruel@st.com
 Kevin Buettner					kevinb@redhat.com
 Andrew Cagney					cagney@redhat.com
 John Carr					jfc@mit.edu

add myself to MAINTAINERS

[Thomas Neumann]

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

* MAINTAINERS (Write After Approval): Add myself.

[-- Attachment #2: maintainers.patch --]
[-- Type: text/x-diff, Size: 483 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 124707)
+++ MAINTAINERS	(working copy)
@@ -346,6 +346,7 @@ Alan Modra					amodra@bigpond.net.au
 Catherine Moore					clm@redhat.com
 Dirk Mueller					dmueller@suse.de
 Adam Nemet					anemet@caviumnetworks.com
+Thomas Neumann					tneumann@users.sourceforge.net
 Dan Nicolaescu					dann@ics.uci.edu
 Dorit Nuzman					dorit@il.ibm.com
 David O'Brien					obrien@FreeBSD.org

add myself to MAINTAINERS

[Ollie Wild]

[-- Attachment #1: Type: text/plain, Size: 99 bytes --]

2007-05-22  Ollie Wild  <aaw@google.com>

       * MAINTAINERS (Write After Approval): Add myself.

[-- Attachment #2: MAINTAINERS.patch --]
[-- Type: text/x-patch, Size: 455 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 124953)
+++ MAINTAINERS	(working copy)
@@ -395,6 +395,7 @@ John Wehle					john@feith.com
 Florian Weimer					fw@deneb.enyo.de
 Zack Weinberg					zackw@panix.com
 Mark Wielaard					mark@gcc.gnu.org
+Ollie Wild					aaw@google.com
 Carlo Wood					carlo@alinoe.com
 Canqun Yang					canqun@nudt.edu.cn
 Kenneth Zadeck					zadeck@naturalbridge.com

Add myself to MAINTAINERS

[Dan Hipschman]

In the write after approval section.  Committed as revision 126629.

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 126628)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2007-07-13  Dan Hipschman  <dsh@google.com>
+
+	* MAINTAINERS (Write After Approval): Add myself.
+
 2007-07-11  Nick Clifton  <nickc@redhat.com>
 
 	* Makefile.tpl (BUILD_EXPORTS): Escape the newline at the end of the
Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 126628)
+++ MAINTAINERS	(working copy)
@@ -316,6 +316,7 @@
 Olivier Hainque					hainque@act-europe.fr
 Stuart Hastings					stuart@apple.com
 Matthew Hiller					hiller@redhat.com
+Dan Hipschman					dsh@google.com
 Manfred Hollstein				mh@suse.com
 Falk Hueffner					falk@debian.org
 Andrew John Hughes				gnu_andrew@member.fsf.org

Add myself to MAINTAINERS

[Kai Tietz]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Hi,

ChangeLog:
2007-08-16  Kai Tietz   <kai.tietz@onevision.com>

        * MAINTAINERS: Add myself for Write After Approval.

Cheers,
 i.A. Kai Tietz



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-Straße 9 – 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: 
Ulrike Döhler, Manuela Kluger

[-- Attachment #2: add2MAINTAINERS.txt --]
[-- Type: text/plain, Size: 466 bytes --]

Index: gcc/MAINTAINERS
===================================================================
--- gcc.orig/MAINTAINERS
+++ gcc/MAINTAINERS
@@ -411,6 +411,7 @@ Jeff Sturm					jsturm@gcc.gnu.org
 Kresten Krab Thorup				krab@gcc.gnu.org
 Caroline Tice					ctice@apple.com
 Michael Tiemann					tiemann@redhat.com
+Kai Tietz					kai.tietz@onevision.com
 David Ung					davidu@mips.com
 Jonathan Wakely					redi@gcc.gnu.org
 Krister Walfridsson				cato@df.lth.se
=

Add myself to MAINTAINERS

[Pat Haugen]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]


ChangeLog:

2007-09-05  Pat Haugen  <pthaugen@us.ibm.com>

        * MAINTAINERS (Write After Approval): Add myself.


(See attached file: maintainers.diff.txt)

[-- Attachment #2: maintainers.diff.txt --]
[-- Type: application/octet-stream, Size: 507 bytes --]

Index: MAINTAINERS
===================================================================
*** MAINTAINERS	(revision 128140)
--- MAINTAINERS	(working copy)
*************** Laurent Guerby					laurent@guerby.net
*** 317,322 ****
--- 317,323 ----
  Mostafa Hagog					hagog@gcc.gnu.org
  Olivier Hainque					hainque@act-europe.fr
  Stuart Hastings					stuart@apple.com
+ Pat Haugen					pthaugen@us.ibm.com
  Matthew Hiller					hiller@redhat.com
  Dan Hipschman					dsh@google.com
  Manfred Hollstein				mh@suse.com

Add myself to maintainers

[Johannes Singler]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Committed to trunk. As approved by Benjamin Kosnik <bkoz@redhat.com>

Johannes



2007-09-17  Johannes Singler <singler@ira.uka.de>

        * MAINTAINERS (write-after-approval) add myself

[-- Attachment #2: johannes_singler_maintainer --]
[-- Type: text/plain, Size: 493 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 128511)
+++ MAINTAINERS	(working copy)
@@ -402,6 +402,7 @@
 Svein Seldal                                    svein@dev.seldal.com
 Thiemo Seufer					ths@networkno.de
 Mark Shinwell					shinwell@codesourcery.com
+Johannes Singler				singler@ira.uka.de
 Franz Sirl					franz.sirl-kernel@lauterbach.com
 Jan Sjodin					jan.sjodin@amd.com
 Michael Sokolov					msokolov@ivan.Harhan.ORG

add myself to MAINTAINERS

[Tomas Bily]

Hi,

Committed to trunk.

Greetings,
Tomas

2008-02-25  Tomas Bily  <tbily@suse.cz>

	* MAINTAINERS (Write After Approval): Add myself.

----
Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 132621)
+++ MAINTAINERS (working copy)
@@ -270,6 +270,7 @@ Andrey Belevantsev                      
 Peter Bergner                                  bergner@vnet.ibm.com
 Jan Beulich                                    jbeulich@novell.com
 David Billinghurst                             David.Billinghurst@riotinto.com
+Tomas Bily                                     tbily@suse.cz
 Laurynas Biveinis                              laurynas.biveinis@gmail.com
 Eric Blake                                     ericb@gcc.gnu.org
 Jim Blandy                                     jimb@codesourcery.com

Add myself to MAINTAINERS

[Andy H]

[-- Attachment #1: Type: text/plain, Size: 47 bytes --]

Add myself to MAINTAINERS. Committed  ok :-)



[-- Attachment #2: first.diff --]
[-- Type: text/plain, Size: 870 bytes --]

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 133916)
+++ ChangeLog   (working copy)
@@ -1,3 +1,7 @@
+2008-04-04  Andy Hutchinson  <hutchinsonandy@aim.com>
+
+   * MAINTAINERS (Write After Approval): Add myself.
+
 2008-04-04  Nick Clifton  <nickc@redhat.com>
 
    PR binutils/4334
Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 133916)
+++ MAINTAINERS (working copy)
@@ -330,6 +330,7 @@
 Manfred Hollstein              mh@suse.com
 Falk Hueffner                  falk@debian.org
 Andrew John Hughes             gnu_andrew@member.fsf.org
+Andy Hutchinson                    hutchinsonandy@aim.com
 Bernardo Innocenti             bernie@develer.com
 Daniel Jacobowitz              dan@debian.org
 Andreas Jaeger                 aj@suse.de

Add myself to MAINTAINERS

[Steven Bosscher]

Hi,

Gerald noticed that I'm not in MAINTAINERS even though I have write
access to the SVN repo.
So I've added myself in the "Write After Approval" section.

Gr.
Steven

Add myself to MAINTAINERS

[Nenad Vukicevic]

Added myself to MAINTAINERS.

Thanks.

2011-06-05  Nenad Vukicevic <nenad@intrepid.com>

         * MAINTAINERS (Write After Approval): Add myself.

Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 174678)
+++ MAINTAINERS (working copy)
@@ -498,6 +498,7 @@
  David Ung davidu@mips.com
  Neil Vachharajani nvachhar@gmail.com
  Kris Van Hees kris.van.hees@oracle.com
+Nenad Vukicevic nenad@intrepid.com
  Feng Wang fengwang@nudt.edu.cn
  Stephen M. Webb stephen.webb@bregmasoft.com
  John Wehle john@feith.com

Add myself to MAINTAINERS

[Lawrence Crowl]

Adding myself as write after approval.

Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 191941)
+++ MAINTAINERS (working copy)
@@ -342,6 +342,7 @@ R. Kelley Cook
 kcook@gcc.gnu.org
 Christian Cornelssen                           ccorn@cs.tu-berlin.de
 François-Xavier Coudert                                fxcoudert@gcc.gnu.org
 Cary Coutant                                   ccoutant@google.com
+Lawrence Crowl                                 crowl@google.com
 Ian Dall                                       ian@beware.dropbear.id.au
 David Daney                                    david.daney@caviumnetworks.com
 Bud Davis                                      jmdavis@link.com


-- 
Lawrence Crowl

Add myself to MAINTAINERS

[Sharad Singhai]

Added myself as write after approval maintainer in r192781.

Thanks,
Sharad

Index: ChangeLog
===================================================================
--- ChangeLog (revision 192779)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2012-10-24  Sharad Singhai  <singhai@google.com>
+
+ * MAINTAINERS (Write After Approval): Add myself.
+
 2012-10-24  Eric Christopher  <echristo@gmail.com>

  * MAINTAINERS: Update email address.
Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 192779)
+++ MAINTAINERS (working copy)
@@ -502,6 +502,7 @@ Dodji Seketeli dodji@gcc.gnu.org
 Svein Seldal svein@dev.seldal.com
 Thiemo Seufer ths@networkno.de
 Marcus Shawcroft marcus.shawcroft@arm.com
+Sharad Singhai singhai@google.com
 Johannes Singler singler@kit.edu
 Franz Sirl franz.sirl-kernel@lauterbach.com
 Jan Sjodin jan.sjodin@amd.com

Add myself to MAINTAINERS

[Gopalasubramanian, Ganesh]

Adding myself to the list of members in "write after approval".

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 192977)
+++ ChangeLog   (working copy)
@@ -1,3 +1,7 @@
+2012-10-30 Ganesh Gopalasubramanian  <Ganesh.Gopalasubramanian@amd.com>
+
+       * MAINTAINERS (Write After Approval): Add myself.
+
 2012-10-26  James Greenhalgh  <james.greenhalgh@arm.com>

        * MAINTAINERS (Write After Approval): Add myself.
Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 192977)
+++ MAINTAINERS (working copy)
@@ -372,6 +372,7 @@
 Chao-ying Fu                                   fu@mips.com
 Gary Funck                                     gary@intrepid.com
 Pompapathi V Gadad                             Pompapathi.V.Gadad@nsc.com
+Gopalasubramanian Ganesh                       Ganesh.Gopalasubramanian@amd.com
 Kaveh Ghazi                                    ghazi@gcc.gnu.org
 Matthew Gingell                                        gingell@gnat.com
 Tristan Gingold                                        gingold@adacore.com

Regards
Ganesh

Add myself to MAINTAINERS

[Tim Shen]

[-- Attachment #1: Type: text/plain, Size: 35 bytes --]

For libstdc++, regex.

--
Tim Shen

[-- Attachment #2: MAINTAINERS.patch --]
[-- Type: application/octet-stream, Size: 455 bytes --]

Index: MAINTAINERS
===================================================================
--- MAINTAINERS	(revision 200997)
+++ MAINTAINERS	(revision 200998)
@@ -512,6 +512,7 @@
 Svein Seldal					svein@dev.seldal.com
 Thiemo Seufer					ths@networkno.de
 Marcus Shawcroft				marcus.shawcroft@arm.com
+Tim Shen					timshen91@gmail.com
 Sharad Singhai					singhai@google.com
 Johannes Singler				singler@kit.edu
 Franz Sirl					franz.sirl-kernel@lauterbach.com