From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27713 invoked by alias); 17 Feb 2006 02:40:34 -0000 Received: (qmail 27505 invoked by uid 22791); 17 Feb 2006 02:40:32 -0000 X-Spam-Check-By: sourceware.org Received: from eyesopen.com (HELO www.eyesopen.com) (208.41.78.163) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Feb 2006 02:40:31 +0000 Received: from localhost (roger@localhost) by www.eyesopen.com (8.11.6/8.11.6) with ESMTP id k1H2Tr211142; Thu, 16 Feb 2006 19:29:53 -0700 Date: Fri, 17 Feb 2006 02:40:00 -0000 From: Roger Sayle To: Zdenek Dvorak cc: gcc-patches@gcc.gnu.org Subject: Re: Patch ping In-Reply-To: <20060216155808.GA7757@atrey.karlin.mff.cuni.cz> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-02/txt/msg01383.txt.bz2 On Thu, 16 Feb 2006, Zdenek Dvorak wrote: > http://gcc.gnu.org/ml/gcc-patches/2006-01/msg00676.html > -- patch to improve the functions to work affine combinations; this > patch blocks further ivopts cleanups (in particular, it keeps > decl_rtl_to_reset alive -- I would really like to get rid of this > ugly hack). I'm a bit uncomfortable with the code duplication introduced by your new double_int structure. Similar double word arithmetic routines are already duplicated in the tree-ssa optimizers. The middle-end handling of TREE_OVERFLOW/TREE_CONSTANT_OVERFLOW and representation of INTEGER_CST, REAL_CST, CONST_INT and CONST_DOUBLE in trees and RTL are already "weeping sores" in GCC's infrastructure. Rather than add another set of hacks, or get embroiled in the inevitable clean-up, might I recommend using HOST_WIDE_INT pairs for the time being? Entangling your iv-opts clean-ups with the nightmare of GCC's multi-precision integer handling might result in delaying your changes until 4.3 or later :-( For example it isn't clear whether your new structure is a constructive step in the right direction. Roger --