Patch to sourcebuild.texi

Patch to sourcebuild.texi

[Joseph S. Myers]

More places where front ends may require changes to core GCC were
missing from the documentation (as shown by the now fixed bugs of
--enable-shared=ada and --with-gmp not being documented).  Fixed thus.
It passes "make info" and "make dvi".  Applied to mainline and 3.4
branch.

Still not listed are the make distclean line in gcc/Makefile.in

	-rmdir ada cp f java objc fixinc intl po testsuite 2>/dev/null

(which I'd favour removing, it doesn't serve a useful purpose) and the
list in install.texi of which directories use which auto* versions
(should be temporary until all use the current versions).  Also, the
QMTest targets for G++ are still in a subideal place (gcc/Makefile.in
rather than gcc/cp/Make-lang.in,
cf. <http://gcc.gnu.org/ml/gcc-patches/2003-06/msg00438.html>) and
nothing is documented about how front ends should support QMTest.

2004-06-10  Joseph S. Myers  <jsm@polyomino.org.uk>

	* doc/sourcebuild.texi (Front End): Add details of more
	installation documentation required.

--- sourcebuild.texi.orig	2004-05-14 08:41:27.000000000 +0000
+++ sourcebuild.texi	2004-06-10 21:56:57.000000000 +0000
@@ -463,6 +463,13 @@
 A mention of the language in the list of supported languages in
 @file{gcc/doc/install.texi}.
 @item
+A mention of the name under which the language's runtime library is
+recognized by @option{--enable-shared=@var{package}} in the
+documentation of that option in @file{gcc/doc/install.texi}.
+@item
+A mention of any special prerequisites for building the front end in
+the documentation of prerequisites in @file{gcc/doc/install.texi}.
+@item
 Details of contributors to that front end in
 @file{gcc/doc/contrib.texi}.  If the details are in that front end's
 own manual then there should be a link to that manual's list in

-- 
Joseph S. Myers
jsm@polyomino.org.uk

Re: Patch to sourcebuild.texi

[Joseph S. Myers]

On Mon, 5 Jul 2004, Phil Edwards wrote:

> Seeing how
> 
>     a)  bootstraps are killed without it
>     b)  it merely reflects current reality (after the @comma patch)
>     c)  it's straightforward
> 
> I'd say either check this in and let us get back to building, or revert
> the original change and let us get back to building.

Though I reverted the original patch pending a review of this one, I don't
think there's any general rule that you can first check in a patch you
have authority to check in, then check in one you don't have authority to
check in to fix breakage caused by the first patch.  It would be a
remarkably convenient way of doing lots of changes without review - change
the parts of the compiler you maintain, and avoid the bother of objections
to the design of your changes to the rest of the compiler that go along
with them by noting they are needed to avoid breakage - if it were so :-).

It's actually the original change that might plausibly fit under the
"obvious rule" as a fix for the gccint onlinedocs generation breakage.  
But gccadmin has only 2 subscribers, and manuals no longer getting
generated don't disappear from onlinedocs until the 15th of each month, so
the onlinedocs breakage may not have been immediately obvious.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: Patch to sourcebuild.texi

[Phil Edwards]

On Mon, Jul 05, 2004 at 07:39:50PM +0000, Joseph S. Myers wrote:
> <http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00361.html> is waiting for
> review.

Seeing how

    a)  bootstraps are killed without it
    b)  it merely reflects current reality (after the @comma patch)
    c)  it's straightforward

I'd say either check this in and let us get back to building, or revert
the original change and let us get back to building.


-- 
Behind everything some further thing is found, forever; thus the tree behind
the bird, stone beneath soil, the sun behind Urth.  Behind our efforts, let
there be found our efforts.
              - Ascian saying, as related by Loyal to the Group of Seventeen

Re: Patch to sourcebuild.texi

[Joseph S. Myers]

On Mon, 5 Jul 2004, Diego Novillo wrote:

> On Mon, 2004-07-05 at 15:39, Joseph S. Myers wrote:
> > <http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00361.html> is waiting for
> > review.  The original patch *was* tested with "make info" and "make dvi"  
> > even if I forgot to mention it, but with Texinfo 4.7, and the Texinfo
> > manual doesn't mention the versions features were added in, that's only in
> > the NEWS file.
> >
> Hmph, well I've got texinfo 4.5.  Is this @comma thing really so
> essential?

The previous sourcebuild.texi broke last night's regeneration of the
internals manual <http://gcc.gnu.org/ml/gccadmin/2004-q3/msg00011.html>.
The section title looks like it really should best have the commas in
rather than having them removed or replaced by semicolons to work around
tool limitations.  The precedent for increasing the version requirement in
such circumstances is
<http://gcc.gnu.org/ml/gcc-patches/2002-03/msg00173.html> (in that case,
one day after the release of the relevant Texinfo version).

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: Patch to sourcebuild.texi

[Diego Novillo]

On Mon, 2004-07-05 at 15:39, Joseph S. Myers wrote:
> <http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00361.html> is waiting for
> review.  The original patch *was* tested with "make info" and "make dvi"  
> even if I forgot to mention it, but with Texinfo 4.7, and the Texinfo
> manual doesn't mention the versions features were added in, that's only in
> the NEWS file.
>
Hmph, well I've got texinfo 4.5.  Is this @comma thing really so
essential?


Diego.

Re: Patch to sourcebuild.texi

[Joseph S. Myers]

<http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00361.html> is waiting for
review.  The original patch *was* tested with "make info" and "make dvi"  
even if I forgot to mention it, but with Texinfo 4.7, and the Texinfo
manual doesn't mention the versions features were added in, that's only in
the NEWS file.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: Patch to sourcebuild.texi

[Diego Novillo]

On Mon, 2004-07-05 at 10:50, Joseph S. Myers wrote:
> sourcebuild.texi contains a cross-reference to a section with commas in
> its long title, which gives a somewhat misleading error message with
> makeinfo --html in texinfo 4.7 (but not makeinfo when generating info).
> Fixed thus.  Applied to mainline, queued for 3.4 branch when it reopens.
> 3.3 branch doesn't have this problem.  Fortunately the 3.4.1 onlinedocs
> were generated before gcc.gnu.org was upgraded to 4.7.
> 
> 2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>
> 
> 	* sourcebuild.texi (Config Fragments): Use @comma{} in
> 	cross-reference to section title.
>
This patch has broken bootstraps for me.  I'm getting:

if [ xinfo = xinfo ]; then \
        makeinfo --no-split -I /home/cygnus/dnovillo/gcc.replace-dom/src/gcc/doc \
                -I /home/cygnus/dnovillo/gcc.replace-dom/src/gcc/doc/include -o doc/gccint.info /home/cygnus/dnovillo/gcc.replace-dom/src/gcc/doc/gccint.texi; \fi
gcc/doc/sourcebuild.texi:215: Unknown command `comma'.
gcc/doc/sourcebuild.texi:215: Misplaced {.
gcc/doc/sourcebuild.texi:215: Misplaced }.
gcc/doc/sourcebuild.texi:215: Unknown command `comma'.
gcc/doc/sourcebuild.texi:215: Misplaced {.
gcc/doc/sourcebuild.texi:215: Misplaced }.
makeinfo: Removing output file `doc/gccint.info' due to errors; use --force to preserve.
make[2]: *** [doc/gccint.info] Error 2


Thanks.  Diego.

Patch to sourcebuild.texi

[Joseph S. Myers]

sourcebuild.texi contains a cross-reference to a section with commas in
its long title, which gives a somewhat misleading error message with
makeinfo --html in texinfo 4.7 (but not makeinfo when generating info).
Fixed thus.  Applied to mainline, queued for 3.4 branch when it reopens.
3.3 branch doesn't have this problem.  Fortunately the 3.4.1 onlinedocs
were generated before gcc.gnu.org was upgraded to 4.7.

2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>

	* sourcebuild.texi (Config Fragments): Use @comma{} in
	cross-reference to section title.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

--- sourcebuild.texi.orig	2004-07-01 21:59:50.000000000 +0000
+++ sourcebuild.texi	2004-07-05 14:39:34.000000000 +0000
@@ -211,7 +211,7 @@
 configuration specific to the particular host machine.  (In general,
 these should only be used for features that cannot reasonably be tested in
 Autoconf feature tests.)
-@xref{System Config, , The @file{config.build}, @file{config.host},
+@xref{System Config, , The @file{config.build}@comma{} @file{config.host}@comma{}
 and @file{config.gcc} Files}, for details of the contents of these files.
 
 @item Each language subdirectory has a file