Re: Gcc mainline failed to build with texinfo 4.6

Re: Gcc mainline failed to build with texinfo 4.6

[Joseph S. Myers]

On Mon, 5 Jul 2004, H. J. Lu wrote:

> Ater this patch
> 
> 2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>
> 
>         * sourcebuild.texi (Config Fragments): Use @comma{} in
>         cross-reference to section title.
> 
> with texinfo 4.6, I got

It seems we need to increase the makeinfo version requirement (I think
that section title is best with commas in, and considered repunctuating it
before going for @comma{}).  OK to commit the following to mainline, and
3.4 branch after it reopens?

2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>

	* configure.ac, doc/install.texi: Increase required makeinfo
	version to 4.7.
	* configure: Regenerate.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


--- configure.ac.orig	2004-07-05 08:54:58.000000000 +0000
+++ configure.ac	2004-07-05 16:53:53.000000000 +0000
@@ -760,7 +760,7 @@
   # that we can use it.
   gcc_AC_CHECK_PROG_VER(MAKEINFO, makeinfo, --version,
   [GNU texinfo.* \([0-9][0-9.]*\)],
-  [4.[2-9]*])
+  [4.[7-9]*])
 fi
 
 if test $gcc_cv_prog_makeinfo_modern = no; then
--- doc/install.texi.orig	2004-07-02 23:47:25.000000000 +0000
+++ doc/install.texi	2004-07-05 16:54:25.000000000 +0000
@@ -366,7 +366,7 @@
 files are not included in the CVS repository.  They are included in
 releases.
 
-@item Texinfo version 4.2 (or later)
+@item Texinfo version 4.7 (or later)
 
 Necessary for running @command{makeinfo} when modifying @file{*.texi}
 files to test your changes.
@@ -1418,7 +1418,7 @@
 not need Bison installed to build them.
 
 When building from CVS or snapshots, or if you modify Texinfo
-documentation, you need version 4.2 or later of Texinfo installed if you
+documentation, you need version 4.7 or later of Texinfo installed if you
 want Info documentation to be regenerated.  Releases contain Info
 documentation pre-built for the unmodified documentation in the release.
 
@@ -1987,7 +1987,7 @@
 @uref{../bugs.html,,bug reporting guidelines}.
 
 If you want to print the GCC manuals, do @samp{cd @var{objdir}; make
-dvi}.  You will need to have @command{texi2dvi} (version at least 4.2)
+dvi}.  You will need to have @command{texi2dvi} (version at least 4.7)
 and @TeX{} installed.  This creates a number of @file{.dvi} files in
 subdirectories of @file{@var{objdir}}; these may be converted for
 printing with programs such as @command{dvips}.  You can also
@@ -3328,7 +3328,7 @@
 @end html
 @heading @anchor{powerpc-*-netbsd*}powerpc-*-netbsd*
 PowerPC system in big endian mode running NetBSD@.  To build the
-documentation you will need Texinfo version 4.2 (NetBSD 1.5.1 included
+documentation you will need Texinfo version 4.7 (NetBSD 1.5.1 included
 Texinfo version 3.12).
 
 @html

Re: Gcc mainline failed to build with texinfo 4.6

[Joseph S. Myers]

On Mon, 5 Jul 2004, Joseph S. Myers wrote:

> 2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>
> 
> 	* configure.ac, doc/install.texi: Increase required makeinfo
> 	version to 4.7.
> 	* configure: Regenerate.

While this patch is pending review, I've reverted the previous one as
requested on IRC.  Onlinedocs generation for gccint will be broken again.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: Gcc mainline failed to build with texinfo 4.6

[Bryce McKinlay]

Most current linux distributions still ship TexInfo 4.5 or 4.6. Fedora 
core 2, for example, only has 4.6. Is this small change worth the hassle 
for everyone to manually update their TexInfo? Unless this is a 
compelling/essential feature that we really need, I'd prefer if we could 
maintain the version requirement as-is, until current OS's have caught up.

Regards

Bryce

Joseph S. Myers wrote:

>On Mon, 5 Jul 2004, H. J. Lu wrote:
>
>  
>
>>Ater this patch
>>
>>2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>
>>
>>        * sourcebuild.texi (Config Fragments): Use @comma{} in
>>        cross-reference to section title.
>>
>>with texinfo 4.6, I got
>>    
>>
>
>It seems we need to increase the makeinfo version requirement (I think
>that section title is best with commas in, and considered repunctuating it
>before going for @comma{}).  OK to commit the following to mainline, and
>3.4 branch after it reopens?
>
>2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>
>
>	* configure.ac, doc/install.texi: Increase required makeinfo
>	version to 4.7.
>	* configure: Regenerate.
>
>  
>

Re: Gcc mainline failed to build with texinfo 4.6

[Diego Novillo]

On Mon, 2004-07-05 at 16:25, Joseph S. Myers wrote:
> On Mon, 5 Jul 2004, Joseph S. Myers wrote:
> 
> > 2004-07-05  Joseph S. Myers  <jsm@polyomino.org.uk>
> > 
> > 	* configure.ac, doc/install.texi: Increase required makeinfo
> > 	version to 4.7.
> > 	* configure: Regenerate.
> 
> While this patch is pending review, I've reverted the previous one as
> requested on IRC.  Onlinedocs generation for gccint will be broken again.
>
Thanks!


Diego.

Re: Gcc mainline failed to build with texinfo 4.6

[Mark Mitchell]

Bryce McKinlay wrote:

> Most current linux distributions still ship TexInfo 4.5 or 4.6. Fedora 
> core 2, for example, only has 4.6. Is this small change worth the 
> hassle for everyone to manually update their TexInfo? Unless this is a 
> compelling/essential feature that we really need, I'd prefer if we 
> could maintain the version requirement as-is, until current OS's have 
> caught up.

Me too.

-- 
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com

Re: Gcc mainline failed to build with texinfo 4.6

[Joseph S. Myers]

On Tue, 6 Jul 2004, Mark Mitchell wrote:

> >What then would you like as the fix or workaround for the onlinedocs
> >generation breakage (which will become immediately visible on the 15th)?
> >Renaming the section to an uglier title?  Downgrading texinfo on
> >gcc.gnu.org?  Note that the upgrade of gcc.gnu.org to 4.7 which showed up
> >this problem was itself to fix a bug (bug 15263).
> >  
> >
> Personally, I would prefer the uglier title.

I have applied the following to mainline and 3.4 branch.  I'll hopefully
repropose the version requirement increase for mainline only in a few
months.

2004-07-06  Joseph S. Myers  <jsm@polyomino.org.uk>

	* doc/sourcebuild.texi: Use semicolons instead of commas in
	section title.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

--- sourcebuild.texi.orig	2004-07-05 20:21:59.000000000 +0000
+++ sourcebuild.texi	2004-07-06 23:08:29.000000000 +0000
@@ -211,7 +211,7 @@
 configuration specific to the particular host machine.  (In general,
 these should only be used for features that cannot reasonably be tested in
 Autoconf feature tests.)
-@xref{System Config, , The @file{config.build}, @file{config.host},
+@xref{System Config, , The @file{config.build}; @file{config.host};
 and @file{config.gcc} Files}, for details of the contents of these files.
 
 @item Each language subdirectory has a file
@@ -224,7 +224,7 @@
 @end itemize
 
 @node System Config
-@subsubsection The @file{config.build}, @file{config.host}, and @file{config.gcc} Files
+@subsubsection The @file{config.build}; @file{config.host}; and @file{config.gcc} Files
 
 The @file{config.build} file contains specific rules for particular systems
 which GCC is built on.  This should be used as rarely as possible, as the

Re: Gcc mainline failed to build with texinfo 4.6

[Mark Mitchell]

Joseph S. Myers wrote:

>On Tue, 6 Jul 2004, Mark Mitchell wrote:
>
>  
>
>>>What then would you like as the fix or workaround for the onlinedocs
>>>generation breakage (which will become immediately visible on the 15th)?
>>>Renaming the section to an uglier title?  Downgrading texinfo on
>>>gcc.gnu.org?  Note that the upgrade of gcc.gnu.org to 4.7 which showed up
>>>this problem was itself to fix a bug (bug 15263).
>>> 
>>>
>>>      
>>>
>>Personally, I would prefer the uglier title.
>>    
>>
>
>I have applied the following to mainline and 3.4 branch.  I'll hopefully
>repropose the version requirement increase for mainline only in a few
>months.
>  
>
Thank you.

-- 
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com

Re: Gcc mainline failed to build with texinfo 4.6

[Gerald Pfeifer]

On Tue, 6 Jul 2004, Joseph S. Myers wrote:
> 2004-07-06  Joseph S. Myers  <jsm@polyomino.org.uk>
>
> 	* doc/sourcebuild.texi: Use semicolons instead of commas in
> 	section title.

Thank you!  (I just removed a mail to suggest using semicolons or slashes
from my draft folder. ;-) )

I agree that commas would like nicer here, but I think the price would
have been too high, at least for the time being.

Gerald
-- 
Gerald Pfeifer (Jerry)   gerald@pfeifer.com   http://www.pfeifer.com/gerald/

Re: Gcc mainline failed to build with texinfo 4.6

[Jonathan Lennox]

Joseph S. Myers writes:
> I have applied the following to mainline and 3.4 branch.  I'll hopefully
> repropose the version requirement increase for mainline only in a few
> months.

Would it work to just put the texinfo commands

@unmacro comma
@macro comma
,
@end comma

somewhere in the header of sourcebuild.texi?  It seems like that should work
both for <=4.6 and for 4.7, from my reading of the 4.6 texinfo manual.

-- 
Jonathan Lennox
lennox@cs.columbia.edu

Re: Gcc mainline failed to build with texinfo 4.6

[Joseph S. Myers]

On Wed, 7 Jul 2004, Jonathan Lennox wrote:

> Would it work to just put the texinfo commands
> 
> @unmacro comma
> @macro comma
> ,
> @end comma
> 
> somewhere in the header of sourcebuild.texi?  It seems like that should work
> both for <=4.6 and for 4.7, from my reading of the 4.6 texinfo manual.

Maybe.  Given the warning in the manual

   * It is not advisable to redefine any TeX primitive, plain, or
     Texinfo command name as a macro. Unfortunately this is a very large
     set of names, and the possible resulting errors are completely
     random.

I think doing so is best avoided.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

Re: Gcc mainline failed to build with texinfo 4.6

[Daniel Jacobowitz]

On Wed, Jul 07, 2004 at 07:12:23PM +0000, Joseph S. Myers wrote:
> On Wed, 7 Jul 2004, Jonathan Lennox wrote:
> 
> > Would it work to just put the texinfo commands
> > 
> > @unmacro comma
> > @macro comma
> > ,
> > @end comma
> > 
> > somewhere in the header of sourcebuild.texi?  It seems like that should work
> > both for <=4.6 and for 4.7, from my reading of the 4.6 texinfo manual.
> 
> Maybe.  Given the warning in the manual
> 
>    * It is not advisable to redefine any TeX primitive, plain, or
>      Texinfo command name as a macro. Unfortunately this is a very large
>      set of names, and the possible resulting errors are completely
>      random.
> 
> I think doing so is best avoided.

So use @macro gcccomma?

-- 
Daniel Jacobowitz

Re: Gcc mainline failed to build with texinfo 4.6

[Joseph S. Myers]

On Wed, 7 Jul 2004, Daniel Jacobowitz wrote:

> > Maybe.  Given the warning in the manual
> > 
> >    * It is not advisable to redefine any TeX primitive, plain, or
> >      Texinfo command name as a macro. Unfortunately this is a very large
> >      set of names, and the possible resulting errors are completely
> >      random.
> > 
> > I think doing so is best avoided.
> 
> So use @macro gcccomma?

It might work.  The macros we have have been a bit fragile (note that one
has different implementations for TeX and makeinfo), and given there are
three different macro implementations to work with (TeX, eTeX as used by
texi2dvi >= 4.7 and makeinfo) I'd be wary of adding macros as an
alternative to requiring a makeinfo version that avoids the need for those
macros.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)