From: "Joseph S. Myers" <jsm@polyomino.org.uk>
To: Steven Bosscher <stevenb@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: New C parser [patch]
Date: Sat, 23 Oct 2004 04:15:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61.0410230042470.30813@digraph.polyomino.org.uk> (raw)
In-Reply-To: <200410230240.19708.stevenb@suse.de>
On Sat, 23 Oct 2004, Steven Bosscher wrote:
> > + /* Parse old-style parameter declarations. */
> > + while (c_lexer_next_token_is_not (parser->lexer, CPP_EOF)
> > + && c_lexer_next_token_is_not (parser->lexer, CPP_OPEN_BRACE))
> > + c_parser_declaration_or_fndef (parser, false, false, true, false);
> > + DECL_SOURCE_LOCATION (current_function_decl) = input_location;
>
> Don't you want to make the location of current_function_decl the first
> line where the function definition starts (or the location of the first
> token even)?
This does make it the location of the open brace. This is a direct
translation of
old_style_parm_decls save_location
{ DECL_SOURCE_LOCATION (current_function_decl) = $6;
from the old grammar - and unlike on some places, both the old and new
parsers have done the one token lookahead at this point so there isn't a
difference arising and I didn't need to fix this place up to get
diagnostic locations to agree between the parsers.
Yes, referring to the location of a token explicitly is better than using
input_location to get it implicitly when location handling is cleaned up
generally later; just not needed to replace one parser with another.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)
next prev parent reply other threads:[~2004-10-23 1:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-23 1:25 Joseph S. Myers
2004-10-23 2:39 ` Steven Bosscher
2004-10-23 4:15 ` Joseph S. Myers [this message]
2004-10-23 5:44 ` Scott Robert Ladd
2004-10-24 22:49 ` Joseph S. Myers
2004-10-26 0:32 ` Zack Weinberg
2004-10-26 1:03 ` Andrew Pinski
2004-10-26 1:03 ` Zack Weinberg
2004-10-26 1:11 ` Joseph S. Myers
2004-10-26 8:23 ` Zack Weinberg
2004-10-26 1:30 ` Gabriel Dos Reis
2004-10-26 1:06 ` Joseph S. Myers
2004-10-26 2:47 ` Joseph S. Myers
2004-10-26 3:48 ` Mark Mitchell
2004-10-26 12:21 ` Kyuupi
2004-10-26 12:32 ` Joseph S. Myers
2004-10-26 11:42 ` Joseph S. Myers
2004-10-27 19:04 ` Richard Henderson
2004-10-27 19:11 ` Richard Guenther
2004-10-27 19:41 ` Zack Weinberg
2004-10-27 19:31 ` Zack Weinberg
2004-10-27 21:31 ` Richard Henderson
2004-10-28 7:38 ` Alan Modra
2004-10-27 20:25 ` Joseph S. Myers
2004-10-25 22:33 ` Ziemowit Laski
2004-10-25 22:51 ` Joseph S. Myers
2004-10-25 23:45 ` Ziemowit Laski
2004-10-25 23:53 ` Scott Robert Ladd
2004-10-26 0:03 ` Unified front end for C and C++ (was Re: New C parser [patch]) Matt Austern
2004-10-26 1:26 ` Scott Robert Ladd
2004-10-26 1:43 ` Gabriel Dos Reis
2004-10-26 2:01 ` Scott Robert Ladd
2004-10-26 15:38 ` Gabriel Dos Reis
2004-10-26 0:28 ` New C parser [patch] Ziemowit Laski
2004-10-26 1:20 ` Scott Robert Ladd
2004-10-26 6:08 ` Unified C and C++ front end (was Re: New C parser [patch]) Matt Austern
2004-10-26 11:14 ` Joseph S. Myers
2004-10-26 16:04 ` Gabriel Dos Reis
2004-10-26 16:51 ` Joseph S. Myers
2004-10-26 0:37 ` New C parser [patch] Joseph S. Myers
2004-10-26 0:03 ` Stan Shebs
2004-10-26 1:46 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0410230042470.30813@digraph.polyomino.org.uk \
--to=jsm@polyomino.org.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).