From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28630 invoked by alias); 26 Oct 2004 10:46:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28622 invoked from network); 26 Oct 2004 10:46:13 -0000 Received: from unknown (HELO lon-mail-1.gradwell.net) (193.111.201.125) by sourceware.org with SMTP; 26 Oct 2004 10:46:13 -0000 Received: from digraph.polyomino.org.uk [81.187.227.50] (user: postmaster6815c918op3.polyomino.org.uk) by lon-mail-1.gradwell.net with esmtp (Gradwell gwh-smtpd 1.148) id 417e2af1.92a0.72; Tue, 26 Oct 2004 11:46:09 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.42) id 1CMOq9-0003QY-9i; Tue, 26 Oct 2004 10:46:09 +0000 Date: Tue, 26 Oct 2004 11:42:00 -0000 From: "Joseph S. Myers" X-X-Sender: jsm28@digraph.polyomino.org.uk To: Zack Weinberg cc: gcc-patches@gcc.gnu.org Subject: Re: New C parser [patch] In-Reply-To: <873c02e46k.fsf@codesourcery.com> Message-ID: References: <873c02e46k.fsf@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2004-10/txt/msg02171.txt.bz2 On Mon, 25 Oct 2004, Zack Weinberg wrote: > Unlike C++, the lexer abstraction seems superfluous. By folding this > into the parser structure, you would avoid an extra pointer > dereference on every lexer operation. On consideration I'll fold it in and search-and-replace c_lexer_* (parser->lexer) with c_parser_* (parser). If it then becomes useful to use the C++ lexer abstraction, these c_parser_* can become one-line inline functions redirecting to the c_lexer_* functions (and we can get a clearer notion of any performance differences involved by using the more efficient arrangement for C now). -- Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/ jsm@polyomino.org.uk (personal mail) joseph@codesourcery.com (CodeSourcery mail) jsm28@gcc.gnu.org (Bugzilla assignments and CCs)