From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15466 invoked by alias); 18 May 2007 19:02:39 -0000 Received: (qmail 15444 invoked by uid 22791); 18 May 2007 19:02:38 -0000 X-Spam-Check-By: sourceware.org Received: from uanet.vostok.net (HELO vostok.net) (80.77.40.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 18 May 2007 19:02:31 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost (Postfix) with ESMTP id 55D7F5A0009; Fri, 18 May 2007 22:02:27 +0300 (EEST) Received: from vostok.net ([127.0.0.1]) by localhost (uanet.vostok.net [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id 2PttJRBzght0; Fri, 18 May 2007 22:02:27 +0300 (EEST) Received: by vostok.net (Postfix, from userid 5180) id 077515A0007; Fri, 18 May 2007 22:02:27 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by vostok.net (Postfix) with ESMTP id 057B75A8002; Fri, 18 May 2007 22:02:27 +0300 (EEST) Date: Fri, 18 May 2007 19:02:00 -0000 From: Sergiy Vyshnevetskiy To: gcc-patches@gcc.gnu.org cc: gerald@pfeifer.com, tromey@gcc.gnu.org Subject: [PATCH][BUGFIX][PR 31932] cpp: Remove useless HAVE_ICONV_H [1/2] In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1297089064-541129855-1179514946=:2122" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-05/txt/msg01233.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1297089064-541129855-1179514946=:2122 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Content-length: 972 Parts of cpp are compiled without libiconv when it's present in the system in a non-default location and --with-libiconv-prefix specified correctly. The reason for this is usage of HAVE_ICONV_H macro in libcpp/internal.h 1. The check for iconv.h in libcpp/configure does not use the value of --with-libiconv-prefix option. 2. HAVE_ICONV_H is useless because check for libiconv in libcpp/configure uses iconv.h anyway. 3. HAVE_ICONV is changed in libcpp/internal.h like this: #ifndef HAVE_ICONV_H #undef HAVE_ICONV #endif which is inherently incorrect in and of itself: any information produced by configure must not be changed in the source code. If configure tests don't work right - fix them, but all source code must be compiled with the same global settings. Solution: get rid of HAVE_ICONV_H in libcpp/internal.h. 2007-05-18 Sergiy Vyshnevetskiy PR propocessor/31932 * internal.h: Remove unnecessary usage of HAVE_ICONV_H --1297089064-541129855-1179514946=:2122 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=patch-cpp-have_iconv_h-1 Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=patch-cpp-have_iconv_h-1 Content-length: 375 LS0tIGxpYmNwcC9pbnRlcm5hbC5oLm9yaWcJRnJpIE9jdCAyMSAyMDo1NDoy MCAyMDA1DQorKysgbGliY3BwL2ludGVybmFsLmgJU2F0IE1heSAxMiAyMTo0 NzoxMSAyMDA3DQpAQCAtMjYsMTAgKzI2LDYgQEANCiAjaW5jbHVkZSAic3lt dGFiLmgiDQogI2luY2x1ZGUgImNwcC1pZC1kYXRhLmgiDQogDQotI2lmbmRl ZiBIQVZFX0lDT05WX0gNCi0jdW5kZWYgSEFWRV9JQ09OVg0KLSNlbmRpZg0K LQ0KICNpZiBIQVZFX0lDT05WDQogI2luY2x1ZGUgPGljb252Lmg+DQogI2Vs c2UNCg== --1297089064-541129855-1179514946=:2122--