From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18690 invoked by alias); 20 Aug 2007 11:11:49 -0000 Received: (qmail 18572 invoked by uid 22791); 20 Aug 2007 11:11:48 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Aug 2007 11:11:36 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 77F46214FF; Mon, 20 Aug 2007 13:11:33 +0200 (CEST) Date: Mon, 20 Aug 2007 11:18:00 -0000 From: Richard Guenther To: Mark Mitchell Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][C++/Java] Get rid of the walk_subtrees langhook In-Reply-To: <46B66A3E.8050403@codesourcery.com> Message-ID: References: <46B66A3E.8050403@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg01257.txt.bz2 On Sun, 5 Aug 2007, Mark Mitchell wrote: > Richard Guenther wrote: > > > 2007-07-26 Richard Guenther > > > > * tree.c (WALK_SUBTREE): Call walk_tree_1. > > (walk_type_fields): Take lh parameter. > > This is OK, with one change: I don't think "walk_tree_lh" is a mnemonic > name for the type of the supplemental walker function. Perhaps > "walk_subtree_fn", like "walk_tree_fn", is better. In any case, the > typedef should have a comment saying what the varios parameters are. walk_subtree_fn isn't any better I think (walk_tree_lh was supposed to mean _langhook ;)). The walk_tree_lh function has the same signature as the (old) walk_tree function, so walk_tree_fn would be a match, but that is already used... Initially I didn't expose the signature with a typedef, but writing the long prototype everywhere isn't any better. I added a comment before the typedef and left the name in place (I volunteer to change it to sth else if anyone has a good idea as a followup). > With those changes, the patch is fine, thanks! Thanks, Richard. -- Richard Guenther Novell / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex