From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Danny Backx <danny.backx@scarlet.be>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Debug info path remapping
Date: Wed, 29 Aug 2007 17:30:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0708291713570.15715@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1183664360.1075.239.camel@dannypc>
On Thu, 5 Jul 2007, Danny Backx wrote:
> This looks remarkably like a patch I sent in on May 16 to do something
> similar for gcov. The reason for my patch is cross-compilers which
> target Windows CE systems, on which the original source path doesn't
> exist.
>
> Maybe the two patches should be considered together.
>
> See http://gcc.gnu.org/ml/gcc-patches/2007-05/msg01087.html for mine.
I think you need to keep pinging your patch until it gets reviewed. It's
also around the size where you may need to get the FSF copyright
assignment in first before it can be committed.
The new option needs documenting in invoke.texi as well as gcov.texi.
"xstrdup(arg)" should have a space: "xstrdup (arg)". As you noted in your
original submission, I think it would also be a good idea to separate the
Windows CE patch to libgcov.c from the rest of the patch so they can be
considered separately; it helps for patches to be submitted in minimal
indivisible units.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2007-08-29 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 5:02 Joseph S. Myers
2007-07-05 20:04 ` Danny Backx
2007-08-29 17:30 ` Joseph S. Myers [this message]
2007-08-11 23:51 ` Ping " Joseph S. Myers
2007-08-15 7:11 ` Mark Mitchell
[not found] ` <Pine.LNX.4.64.0708171450040.23946@digraph.polyomino.org.uk>
[not found] ` <20070824135238.GA6629@caradoc.them.org>
2007-08-25 20:21 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708291713570.15715@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=danny.backx@scarlet.be \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).