From: Gerald Pfeifer <gerald@pfeifer.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
Alexandre Oliva <aoliva@redhat.com>,
DJ Delorie <dj@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [wwwdocs] codingconventions.html: autotools update
Date: Mon, 10 Sep 2007 19:06:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0709102044110.11229@acrux.dbai.tuwien.ac.at> (raw)
In-Reply-To: <46E4EEB3.4060208@lu.unisi.ch>
On Mon, 10 Sep 2007, Paolo Bonzini wrote:
> Good. I'd add a note that ltgcc.m4 is *not* imported from upstream.
Good catch! I added such a note and committed the revised patch
below. Thanks for the review (and especially thanks to Ralf)!
Gerald
Index: codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.51
diff -u -3 -p -r1.51 codingconventions.html
--- codingconventions.html 27 Jul 2007 04:50:47 -0000 1.51
+++ codingconventions.html 10 Sep 2007 18:39:54 -0000
@@ -446,20 +446,24 @@ installed in the GCC source tree, so tha
meaningful and unique. Don't install the patch, install the whole
file.</li>
-<li>ltconfig, ltmain.sh, libtool.m4, ltcf-c.sh, ltcf-cxx.sh,
+<li>ltmain.sh, libtool.m4, ltoptions.m4, ltsugar.m4, ltversion.m4,
+lt~obsolete.m4, and formerly also ltconfig, ltcf-c.sh, ltcf-cxx.sh,
ltcf-gcj.sh: The master copy of these files is the CVS repository of
<a href="http://www.gnu.org/software/libtool/libtool.html">GNU
libtool</a>. Patches should be posted to <a
href="mailto:libtool-patches@gnu.org">libtool-patches@gnu.org</a>.
Only after the change makes it to the libtool CVS tree should the new
-files be installed in the GCC source tree. ltconfig and ltmain.sh are
-generated files from ltconfig.in and ltmain.in, respectively, so, when
-you post the patch, make sure you're patching the source file, not the
-generated one. When you update these generated files in the GCC
-repository, make sure they report the same timestamp and version number,
-and note this version number in the ChangeLog.</li>
+files be installed in the GCC source tree.<br />
+ltgcc.m4 is not imported from upstream.<br />
+ltconfig and ltmain.sh are generated files from ltconfig.in and
+ltmain.in, respectively, and with libtool 2.1, the latter is generated
+from ltmain.m4sh, so, when you post the patch, make sure you're
+patching the source file, not the generated one. When you update
+these generated files in the GCC repository, make sure they report the
+same timestamp and version number, and note this version number in the
+ChangeLog.</li>
-<li>Top-level configure.in, configure, Makefile.in, config-ml.in,
+<li>Top-level configure.ac, configure, Makefile.in, config-ml.in,
config.if and most other top-level shell-scripts: Please try to keep
these files in sync with the corresponding files in the src repository
at sourceware.org. Some people hope to eventually merge these
prev parent reply other threads:[~2007-09-10 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 20:19 Ralf Wildenhues
2007-09-09 22:32 ` Gerald Pfeifer
2007-09-10 7:31 ` Paolo Bonzini
2007-09-10 19:06 ` Gerald Pfeifer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709102044110.11229@acrux.dbai.tuwien.ac.at \
--to=gerald@pfeifer.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=aoliva@redhat.com \
--cc=bonzini@gnu.org \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).