From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Dan Hipschman <dsh@google.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH: Add format string suggestions to -Wformat warnings
Date: Thu, 13 Sep 2007 23:20:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0709132237100.17895@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20070821222124.GE11055@google.com>
On Tue, 21 Aug 2007, Dan Hipschman wrote:
> > dg-excess-errors should only be used very sparingly with xfail. When
> > there are specific diagnostics expected on specific lines, you should
> > update the tests to match each new diagnostic individually rather than
> > using dg-excess-errors to match them all together.
>
> OK, I've done this, too.
We're moving away from having dg-* as regular expressions to match
multiple messages on one line to having a separate dg-* for each
diagnostic (that way, you know if only some of the expected diagnostics on
a line have disappeared).
Thus, rather than changing the existing dg-warning to dg-message with
regular expressions, you should leave them alone and add new dg-message
lines for the new diagnostics (which use line numbers to identify the line
on which the diagnostic is expected, { dg-message "regexp" "description" {
target *-*-* } line-number }) (the description serves to make the PASS or
FAIL lines unique when multiple diagnostics are expected on the same line
and would otherwise get identical PASS or FAIL lines).
The revised C front-end changes look good to me but I can't reach a final
conclusion on them without seeing the tests revised to avoid matching
multiple diagnostics with a single regexp.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2007-09-13 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 23:51 Dan Hipschman
2007-08-15 0:00 ` Andrew Pinski
2007-08-15 0:39 ` Joseph S. Myers
2007-08-21 22:58 ` Dan Hipschman
2007-09-13 23:20 ` Joseph S. Myers [this message]
2007-09-14 1:30 ` Ollie Wild
2007-09-14 3:51 ` Joseph S. Myers
2008-08-14 19:43 ` Dan Hipschman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709132237100.17895@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dsh@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).