[PATCH] Avoid ssa-fre-4.c FAIL on many arches (PR tree-optimization/33757)

[PATCH] Avoid ssa-fre-4.c FAIL on many arches (PR tree-optimization/33757)

[Jakub Jelinek]

Hi!

This test assumes TARGET_PROMOTE_PROTOTYPES returns true, but that's not the
case on many targets.
Rather than adding e.g.
s390*-*-* ia64-*-* alpha*-*-* avr*-*-* c4x*-*-* crx*-*-* frv*-*-*
powerpc*-*-* spu*-*-* m32c*-*-*
sparc*-*-* && lp64
some arm*-*-*
some sh*-*-* (hitachi or renesas types)
to the dg-skip-if, it is IMHO better just to run the test on selected
few arches which are known to TARGET_PROMOTE_PROTOTYPES true.
See various gcc-testresults mails for these failures.

Ok for trunk?

2007-10-29  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/33757
	* gcc.dg/tree-ssa/ssa-fre-4.c: Run on selected TARGET_PROMOTE_PROTOTYPES
	true architectures instead of having a big dg-skip-if.

--- gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c.jj	2007-09-11 12:43:31.000000000 +0200
+++ gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c	2007-10-29 15:36:36.000000000 +0100
@@ -1,7 +1,6 @@
-/* { dg-do compile } */
 /* If the target returns false for TARGET_PROMOTE_PROTOTYPES, then there
    will be no casts for FRE to eliminate and the test will fail.  */
-/* { dg-skip-if "no promotion to eliminate" { cris-*-* mmix-*-* } { "*" } { "" } } */
+/* { dg-do compile { target i?86-*-* x86_64-*-* hppa*-*-* mips*-*-* m68k*-*-* } } */
 /* { dg-options "-O -fdump-tree-fre-details" } */
 
 /* From PR21608.  */

	Jakub

Re: [PATCH] Avoid ssa-fre-4.c FAIL on many arches (PR tree-optimization/33757)

[Richard Guenther]

On Mon, 29 Oct 2007, Jakub Jelinek wrote:

> Hi!
> 
> This test assumes TARGET_PROMOTE_PROTOTYPES returns true, but that's not the
> case on many targets.
> Rather than adding e.g.
> s390*-*-* ia64-*-* alpha*-*-* avr*-*-* c4x*-*-* crx*-*-* frv*-*-*
> powerpc*-*-* spu*-*-* m32c*-*-*
> sparc*-*-* && lp64
> some arm*-*-*
> some sh*-*-* (hitachi or renesas types)
> to the dg-skip-if, it is IMHO better just to run the test on selected
> few arches which are known to TARGET_PROMOTE_PROTOTYPES true.
> See various gcc-testresults mails for these failures.
> 
> Ok for trunk?

Ok.

Thanks,
Richard.

> 
> 2007-10-29  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR tree-optimization/33757
> 	* gcc.dg/tree-ssa/ssa-fre-4.c: Run on selected TARGET_PROMOTE_PROTOTYPES
> 	true architectures instead of having a big dg-skip-if.
> 
> --- gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c.jj	2007-09-11 12:43:31.000000000 +0200
> +++ gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c	2007-10-29 15:36:36.000000000 +0100
> @@ -1,7 +1,6 @@
> -/* { dg-do compile } */
>  /* If the target returns false for TARGET_PROMOTE_PROTOTYPES, then there
>     will be no casts for FRE to eliminate and the test will fail.  */
> -/* { dg-skip-if "no promotion to eliminate" { cris-*-* mmix-*-* } { "*" } { "" } } */
> +/* { dg-do compile { target i?86-*-* x86_64-*-* hppa*-*-* mips*-*-* m68k*-*-* } } */
>  /* { dg-options "-O -fdump-tree-fre-details" } */
>  
>  /* From PR21608.  */
> 
> 	Jakub
> 
> 

-- 
Richard Guenther <rguenther@suse.de>
Novell / SUSE Labs
SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex