From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8385 invoked by alias); 8 Jan 2008 16:52:19 -0000 Received: (qmail 8377 invoked by uid 22791); 8 Jan 2008 16:52:19 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Jan 2008 16:52:01 +0000 Received: (qmail 20321 invoked from network); 8 Jan 2008 16:51:59 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Jan 2008 16:51:59 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.68) (envelope-from ) id 1JCHgE-0002Qn-87; Tue, 08 Jan 2008 16:51:58 +0000 Date: Tue, 08 Jan 2008 18:18:00 -0000 From: "Joseph S. Myers" To: Kai Tietz cc: Danny Smith , GCC Patches , NightStrike Subject: Re: Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-01/txt/msg00313.txt.bz2 On Tue, 8 Jan 2008, Kai Tietz wrote: > * gcc/testsuite/gcc.dg/format/format.h: Add for mingw the gnu > style printf prototypes. > > Do you think it is ok for apply ? The general approach is plausible, but the patch still needs full test coverage for the MinGW formats before it's ready for review. Every C90, C99, X/Open or GNU format feature not present on Windows should have a MinGW-specific test assertion added to the testsuite that the use of that feature is diagnosed, which every such feature present on Windows should have a MinGW-specific test assertion added that the feature is not diagnosed. (The effect should be that every entry in the MinGW format datastructures is tested, and every difference from the GNU format datastructures.) When you have a patch ready with such tests, please confirm that all the format tests pass cleanly with it applied for both MinGW and non-MinGW targets; then it will be ready for review. -- Joseph S. Myers joseph@codesourcery.com