Re: Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c

["Joseph S. Myers" <joseph@codesourcery.com>]

On Tue, 19 Feb 2008, Kai Tietz wrote:

>         * gcc/c-format.h: Add structure target_ovr_attr to hold
>         system specific formatter names.

No "gcc/" in ChangeLog entries.  Also note the proper style

	* file (part of file): Message.

so "c-format.h (target_ovr_attr): New structure." (for example).

The use of "formatter" still needs changing to "format" throughout the 
patch.

> +  if (attr_name == NULL || *attr_name == 0 || strncmp (attr_name, "gcc_", 4) == 0)

Please ensure source lines are under 80 columns wide.

> +  for (i = 0; gnu_target_overrides_format_attributes[i].named_attr_src != NULL; ++i)

Likewise.


> +  /* Name of the single-character length modifier. If prefixed by
> +     a zero character, it discribes a multi character length

"describes".

> +     modifier, lile I64, I32, etc.  */

"like".

> +/* Contains a pointer to type target_ovr_attr defining the target specific
> +   overrides of formatter attributs.  See format.h for structure definition.  */

"attributes", and I think you mean c-format.h.

> Index: gcc/gcc/config/i386/msformat-c.c

Note that this part of the patch will need reviewing by a MinGW 
maintainer.

>  The parameter @var{archetype} determines how the format string is
> -interpreted, and should be @code{printf}, @code{scanf}, @code{strftime}
> -or @code{strfmon}.  (You can also use @code{__printf__},
> -@code{__scanf__}, @code{__strftime__} or @code{__strfmon__}.)  The
> -parameter @var{string-index} specifies which argument is the format
> -string argument (starting from 1), while @var{first-to-check} is the
> -number of the first argument to check against the format string.  For
> -functions where the arguments are not available to be checked (such as
> +interpreted, and should be @code{printf}, @code{scanf}, @code{strftime},
> +@code{gnu_printf}, @code{gnu_scanf}, @code{gnu_strftime} or
> +@code{strfmon}.  (You can also use @code{__printf__},
> +@code{__scanf__}, @code{__strftime__} or @code{__strfmon__}.)  On
> +mingw targets there is also @code{ms_printf}, @code{ms_scanf}, and

"MinGW".  And I think it's actually "Microsoft Windows targets", since 
these appear to be available on Cygwin as well, judging by the config.gcc 
patch.

> +@code{ms_strftime} present. The none target specific formatters are
> +always the variant of the system.  The parameter @var{string-index}

"@var{archtype} values such as @code{printf} refer to the formats accepted 
by the system's C run-time library, while @code{gnu_} values always refer 
to the formats accepted by the GNU C Library.  On Microsoft Windows 
targets, @code{ms_} values refer to the formats accepted by the 
@file{msvcrt.dll} library."

-- 
Joseph S. Myers
joseph@codesourcery.com