From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22753 invoked by alias); 9 Mar 2008 18:16:43 -0000 Received: (qmail 22744 invoked by uid 22791); 9 Mar 2008 18:16:42 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 09 Mar 2008 18:16:19 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 99B4E34D2A; Sun, 9 Mar 2008 19:16:16 +0100 (CET) Date: Sun, 09 Mar 2008 18:16:00 -0000 From: Richard Guenther To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][mem-ref] Adjust some testsuite patterns In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00593.txt.bz2 On Sun, 9 Mar 2008, Andrew Pinski wrote: > Hi, > Some comments/questions. > > > ! /* { dg-final { scan-tree-dump-times "MEM > ! /* { dg-final { scan-tree-dump-times "\\\&a \\\+ 4" 1 "optimized" } } */ > > /* { dg-final { cleanup-tree-dump "optimized" } } */ > > We should not be taking the address of a here. This is not a false > positive at all. REALPART_EXPR/IMAGPART_EXPR should not require the > address of the variable taken. Right? If you do now, then I think > you need to think that as we really don't want extra addressable > variables on the rtl level. Now if we don't fold it to > REALPART_EXPR/IMAGPART_EXPR, then something is really wrong and the > testcase should not be changed at all. You are right, I have reverted that change. Thanks for noticing. I also deleted the two foldaddr testcases. Richard.