[PATCH] [Bug target/35504] incorrect code generated on i386 for C++ multiple inheritance, large return structures and regparm or fastcall calling conventions

[PATCH] [Bug target/35504] incorrect code generated on i386 for C++ multiple inheritance, large return structures and regparm or fastcall calling conventions

[Mikulas Patocka]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 504 bytes --]

Hi

This is a proposed patch for bug 35504. The testcase is in bugzilla.

Mikulas

> ------- Comment #3 from rguenth at gcc dot gnu dot org  2008-03-08 10:58 -------
> Interesting ;)
> 
> Please send patches to gcc-patches@gcc.gnu.org indicating how you tested it.
>            Keywords|                            |ABI, wrong-code
> 
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35504
> 
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
> 

[-- Attachment #2: c++-thunks.patch --]
[-- Type: TEXT/x-diff, Size: 370 bytes --]

\x1f‹\b\0\0\0\0\0\0\x03QŰn‚0\x18ž–§ř慁`ľâaˆqĂMłxa˛¨KśŤ†!\x10"\x02’¸,žű
ŹnŃ,Y/ú÷đú—\x10‚Ŕuťn\x12űaĐ\rű樚:.k\x18”š„ö	5A‡–1´č°Cĺ€N{”*şŽ˙Áż ÷\rŤ\x7f{Eˇm\x10Ă\x18\r\x06í1ôzŃ^[Ăś\x15(\0B\x1fjx4GĚ/b—‡IĚ2/Hě\0•\x7f¤^^[ň\Ă\x1d(Z-Üä|çd\x01Kk„Ś•2Ŕ§BŞŠ0ć\x10\x1aq‚)fŻl˝xš(úĹŐ¤ćÔöQ’ě‹”9œgá{Á=¨MßÉšëDQłíŰó‚ÍśŰőňáeťŘHSM!\réň(]Î'N\x10d¸Çźş€őƒ¨]˝(÷äşLŽ7p\x1dšQ§+Ľ´j'‘ĺčů/´|Ď?Ű9˘W
‹ĐźČb\x04ž\0ó#[-VP7ËC˛\x13đ4*r&>>çŽč*Šťgi"\x1aée%şŚIű“¨'ŮŮ\vŐ˛\x0fgŐ*˝öý	‚Ą|\x01AX”„Ł\x02\0\0

Re: [PATCH] [Bug target/35504] incorrect code generated on i386 for C++ multiple inheritance, large return structures and regparm or fastcall calling conventions

[Mikulas Patocka]

Hi

> Hello!
> 
> > This is a proposed patch for bug 35504. The testcase is in bugzilla.
> 
> Huh, the attachment is scrambled. See [1].

Hmm, I see, I don't know why. So use the attachment in bugzilla, there is 
also a testcase.

I am not a gcc developer, you can take it and commit it to gcc.

> Please add the testcase to the patch. Also, send a ChangeLog entry for
> gcc/ChangeLog and gcc/patches/ChangeLog, separate from the patch. It
> would be nice, if you describe the rationale for the thange together
> with the patch submission (Your comment #0 from PR will do). Please
> read http://gcc.gnu.org/contribute.html (Submitting Patches section in
> particular) for further instructions.
> 
> You didn't say how you test the patch. At least you should bootstrap
> gcc with your patch and run the testsuite for defult languages. I can
> help you with this step if you are unable to do it.

Bootstrap doesn't use non-standard calling conventions in C++, so the 
patch should have no effect on it. The testcase is in bugzilla. You can 
add it to your regression testsuite.

> [1] http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00610.html
> 
> Thanks for your contribution,
> Uros.

Mikulas

Re: [PATCH] [Bug target/35504] incorrect code generated on i386 for C++ multiple inheritance, large return structures and regparm or fastcall calling conventions

[Uros Bizjak]

Hello!

> This is a proposed patch for bug 35504. The testcase is in bugzilla.

Huh, the attachment is scrambled. See [1].

Please add the testcase to the patch. Also, send a ChangeLog entry for
gcc/ChangeLog and gcc/patches/ChangeLog, separate from the patch. It
would be nice, if you describe the rationale for the thange together
with the patch submission (Your comment #0 from PR will do). Please
read http://gcc.gnu.org/contribute.html (Submitting Patches section in
particular) for further instructions.

You didn't say how you test the patch. At least you should bootstrap
gcc with your patch and run the testsuite for defult languages. I can
help you with this step if you are unable to do it.

[1] http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00610.html

Thanks for your contribution,
Uros.