From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3657 invoked by alias); 18 Mar 2008 04:08:50 -0000 Received: (qmail 3646 invoked by uid 22791); 18 Mar 2008 04:08:50 -0000 X-Spam-Check-By: sourceware.org Received: from artax.karlin.mff.cuni.cz (HELO artax.karlin.mff.cuni.cz) (195.113.31.125) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Mar 2008 04:08:18 +0000 Received: by artax.karlin.mff.cuni.cz (Postfix, from userid 17421) id 263AA98082; Tue, 18 Mar 2008 05:08:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by artax.karlin.mff.cuni.cz (Postfix) with ESMTP id 245449803C; Tue, 18 Mar 2008 05:08:16 +0100 (CET) Date: Tue, 18 Mar 2008 05:31:00 -0000 From: Mikulas Patocka To: Uros Bizjak cc: gcc patches , Richard Guenther Subject: Re: [PATCH] [Bug target/35504] incorrect code generated on i386 for C++ multiple inheritance, large return structures and regparm or fastcall calling conventions In-Reply-To: <5787cf470803100017s9e6a81cv7bd9376ff63af467@mail.gmail.com> Message-ID: References: <5787cf470803100017s9e6a81cv7bd9376ff63af467@mail.gmail.com> X-Personality-Disorder: Schizoid MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg01031.txt.bz2 Hi > Hello! > > > This is a proposed patch for bug 35504. The testcase is in bugzilla. > > Huh, the attachment is scrambled. See [1]. Hmm, I see, I don't know why. So use the attachment in bugzilla, there is also a testcase. I am not a gcc developer, you can take it and commit it to gcc. > Please add the testcase to the patch. Also, send a ChangeLog entry for > gcc/ChangeLog and gcc/patches/ChangeLog, separate from the patch. It > would be nice, if you describe the rationale for the thange together > with the patch submission (Your comment #0 from PR will do). Please > read http://gcc.gnu.org/contribute.html (Submitting Patches section in > particular) for further instructions. > > You didn't say how you test the patch. At least you should bootstrap > gcc with your patch and run the testsuite for defult languages. I can > help you with this step if you are unable to do it. Bootstrap doesn't use non-standard calling conventions in C++, so the patch should have no effect on it. The testcase is in bugzilla. You can add it to your regression testsuite. > [1] http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00610.html > > Thanks for your contribution, > Uros. Mikulas