Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build

["Joseph S. Myers" <joseph@codesourcery.com>]

On Fri, 5 Sep 2008, Kai Tietz wrote:

> Hi Joseph,
> 
> "Joseph S. Myers" <joseph@codesourcery.com> wrote on 05.09.2008 15:48:48:
> 
> > On Fri, 5 Sep 2008, Kai Tietz wrote:
> > 
> > > I tested this patch for x86_64-pc-mingw32. Is this patch ok for apply?
> > 
> > Could you then explain how it passed testing with a single reference to 
> > "warn_pedantice_ms_format" that appears to be a type?
> 
> Please see mingw.opt. It is an autogenerated variable (no type ?!).

The code uses both "warn_pedantic_ms_format" and 
"warn_pedantice_ms_format", and it's the latter that's the typo (sorry).  
I must suspect that your testing did not compile that part of the code at 
all.  I also don't see why you need any of the code involving prev_value.

> > It doesn't document the new option, and doesn't add any testcases, so 
> > isn't ready for review anyway, and the patch should not change the 
> > existing defaults for any warnings.
> Well, about the place of the documentation of the option, I was uncertain. 
> Maybe you could give me a hint to which .texi file it should be added.
> The default value, altered in the attached patch.

Command-line options are documented in invoke.texi.

-- 
Joseph S. Myers
joseph@codesourcery.com