From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Kai Tietz <Kai.Tietz@onevision.com>
Cc: "Aaron W. LaFramboise" <aaronavay62@aaronwl.com>,
Danny Smith <dansmister@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Kai Tietz <ktietz70@googlemail.com>,
NightStrike <nightstrike@gmail.com>
Subject: Re: [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build
Date: Fri, 05 Sep 2008 14:07:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0809051359040.3576@digraph.polyomino.org.uk> (raw)
In-Reply-To: <OFD552269D.FDB25148-ONC12574BB.004C349F-C12574BB.004C93E8@onevision.de>
On Fri, 5 Sep 2008, Kai Tietz wrote:
> Hi Joseph,
>
> "Joseph S. Myers" <joseph@codesourcery.com> wrote on 05.09.2008 15:48:48:
>
> > On Fri, 5 Sep 2008, Kai Tietz wrote:
> >
> > > I tested this patch for x86_64-pc-mingw32. Is this patch ok for apply?
> >
> > Could you then explain how it passed testing with a single reference to
> > "warn_pedantice_ms_format" that appears to be a type?
>
> Please see mingw.opt. It is an autogenerated variable (no type ?!).
The code uses both "warn_pedantic_ms_format" and
"warn_pedantice_ms_format", and it's the latter that's the typo (sorry).
I must suspect that your testing did not compile that part of the code at
all. I also don't see why you need any of the code involving prev_value.
> > It doesn't document the new option, and doesn't add any testcases, so
> > isn't ready for review anyway, and the patch should not change the
> > existing defaults for any warnings.
> Well, about the place of the documentation of the option, I was uncertain.
> Maybe you could give me a hint to which .texi file it should be added.
> The default value, altered in the attached patch.
Command-line options are documented in invoke.texi.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2008-09-05 14:02 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 19:08 [PATCH] Build libgcc_s on Windows Aaron W. LaFramboise
2008-08-19 5:16 ` Danny Smith
2008-08-20 14:30 ` Aaron W. LaFramboise
2008-08-21 5:15 ` Danny Smith
2008-08-28 4:15 ` Dave Korn
2008-08-28 9:15 ` Danny Smith
2008-08-28 9:35 ` Brian Dessent
2008-08-19 8:05 ` Paolo Bonzini
2008-08-19 13:20 ` Aaron W. LaFramboise
2008-08-19 16:17 ` Paolo Bonzini
2008-09-02 6:40 ` NightStrike
2008-09-02 12:03 ` Kai Tietz
2008-09-02 16:30 ` NightStrike
2008-09-03 9:51 ` Kai Tietz
2008-09-03 18:03 ` NightStrike
2008-09-04 3:52 ` Danny Smith
2008-09-04 6:25 ` NightStrike
2008-09-04 8:00 ` Danny Smith
2008-09-04 10:48 ` [patch i386]: Adjust DWARF_OFFSET_SIZE for w64 Kai Tietz
2008-09-04 16:30 ` NightStrike
2008-09-09 21:18 ` Richard Henderson
2008-09-10 8:20 ` Kai Tietz
2008-09-05 11:21 ` [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build Kai Tietz
2008-09-05 13:57 ` Joseph S. Myers
2008-09-05 14:02 ` Kai Tietz
2008-09-05 14:07 ` Joseph S. Myers [this message]
2008-09-05 16:28 ` Kai Tietz
2008-09-05 20:18 ` Joseph S. Myers
2008-09-08 10:54 ` Kai Tietz
2008-09-08 12:28 ` Joseph S. Myers
2008-09-08 12:42 ` Kai Tietz
2008-09-08 15:44 ` Joseph S. Myers
2008-09-09 0:12 ` Aaron W. LaFramboise
2008-09-09 5:42 ` Danny Smith
2008-09-09 6:01 ` Kai Tietz
2008-09-12 15:33 ` Kai Tietz
2008-09-12 15:40 ` Aaron W. LaFramboise
2008-09-12 16:04 ` NightStrike
2008-09-12 16:38 ` NightStrike
2008-09-12 21:42 ` Danny Smith
2008-10-10 12:14 ` Kai Tietz
2008-10-11 10:27 ` Danny Smith
2008-10-11 15:34 ` Kai Tietz
2008-10-12 9:48 ` Danny Smith
2008-10-13 11:36 ` Kai Tietz
2008-09-15 8:18 ` Aaron W. LaFramboise
2008-09-04 8:31 ` [PATCH] Build libgcc_s on Windows Kai Tietz
2008-09-09 19:57 ` lkcl
2008-09-10 8:49 ` lkcl
2008-09-10 9:11 ` Brian Dessent
2008-09-10 9:26 ` lkcl
2008-09-10 12:32 ` lkcl
2008-09-10 9:19 ` lkcl
[not found] <1221035558.13510.ezmlm@gcc.gnu.org>
2008-09-10 9:09 ` Jay
2008-09-10 9:43 ` lkcl
[not found] <OFB5BC0CC2.0ADC574F-ONC12574E1.0039EBC2-C12574E1.0039FBF6@LocalDomain>
2008-11-21 14:09 ` [patch]: Fix bootstrap/PR 25502: I64d format Werror problem in build Kai Tietz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0809051359040.3576@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Kai.Tietz@onevision.com \
--cc=aaronavay62@aaronwl.com \
--cc=dansmister@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
--cc=nightstrike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).