test_summary: Only include LAST_UPDATED if it exists.

test_summary: Only include LAST_UPDATED if it exists.

[Gerald Pfeifer]

I got sufficiently annoyed by the error message of my nightly tester
complaining about LAST_UPDATED not existing that I brushed up my AWK
a bit a whipped up the patch below.

Tested by running the script as is and using a filename that exists
on my system.

Unless someone has any issue with this, or a suggestion I plan on
committing this in some two days.

Gerald

2009-04-05  Gerald Pfeifer  <gerald@pfeifer.com>

	* test_summary: Only include LAST_UPDATED if it exists.
	Complete copyright years.

Index: test_summary
===================================================================
--- test_summary	(revision 145616)
+++ test_summary	(working copy)
@@ -1,6 +1,7 @@
 #! /bin/sh
 
-# (C) 1998, 1999, 2000, 2002 Free Software Foundation
+# (C) 1998, 1999, 2000, 2002, 2003, 2004, 2003, 2004, 2007, 2009
+# Free Software Foundation
 # Originally by Alexandre Oliva <oliva@dcc.unicamp.br>
 
 # This script is Free Software, and it can be copied, distributed and
@@ -106,9 +107,11 @@
     sub(/^s,@TOPLEVEL_CONFIGURE_ARGUMENTS@,/, "", configflags);
     srcdir = configflags;
     sub(/\/configure .*/, "", srcdir);
-    printf "LAST_UPDATED: ";
-    system("tail -1 " srcdir "/LAST_UPDATED");
-    print "";
+    if ( system("test -f " srcdir "/LAST_UPDATED") == 0 ) {
+        printf "LAST_UPDATED: ";
+        system("tail -1 " srcdir "/LAST_UPDATED");
+        print "";
+    }
 
     sub(/^[^ ]*\/configure */, " ", configflags);
     sub(/,;t t $/, " ", configflags);

Re: test_summary: Only include LAST_UPDATED if it exists.

[Hans-Peter Nilsson]

On Tue, 7 Apr 2009, Gerald Pfeifer wrote:

> I got sufficiently annoyed by the error message of my nightly tester
> complaining about LAST_UPDATED not existing that I brushed up my AWK
> a bit a whipped up the patch below.

> Unless someone has any issue with this, or a suggestion I plan on
> committing this in some two days.

No issue with the patch as such (for one, it sounds like the
right thing for e.g. releases), just curious: how come there's
no LAST_UPDATED in your source tree?

From the above it sounds like you're checking out sources from
svn.  If you use contrib/gcc_update for that (or with --touch
later) you'd have a LAST_UPDATED.  If you don't, you can get
the file time-stamps in a twist, causing spurious test-failures
in some cases; regenerated files in others.

brgds, H-P

Re: test_summary: Only include LAST_UPDATED if it exists.

[Joseph S. Myers]

On Tue, 7 Apr 2009, Gerald Pfeifer wrote:

> -# (C) 1998, 1999, 2000, 2002 Free Software Foundation
> +# (C) 1998, 1999, 2000, 2002, 2003, 2004, 2003, 2004, 2007, 2009

This now has "2003, 2004" duplicated.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: test_summary: Only include LAST_UPDATED if it exists.

[Gerald Pfeifer]

On Tue, 7 Apr 2009, Hans-Peter Nilsson wrote:
> No issue with the patch as such (for one, it sounds like the
> right thing for e.g. releases), just curious: how come there's
> no LAST_UPDATED in your source tree?
> 
> From the above it sounds like you're checking out sources from
> svn.  If you use contrib/gcc_update for that (or with --touch
> later) you'd have a LAST_UPDATED.

My nightly bootstrap basically has been doing

  $SVN update --accept working 2>&1
  $SVN status 2>&1
  contrib/gcc_update --touch

for the last couple of years,without problems.  I had a look at the 
source of gcc_update and don't see --touch modify LAST_UPDATED.  And
I don't think it should?

On Wed, 8 Apr 2009, Joseph S. Myers wrote:
>> -# (C) 1998, 1999, 2000, 2002 Free Software Foundation
>> +# (C) 1998, 1999, 2000, 2002, 2003, 2004, 2003, 2004, 2007, 2009
> This now has "2003, 2004" duplicated.

Good catch, Joseph.  From none to twice was a bit over eager. :-)

I applied the slightly updated patch below.

Gerald

2009-04-25  Gerald Pfeifer  <gerald@pfeifer.com>

	* test_summary: Only include LAST_UPDATED if it exists.
	Complete copyright years.

Index: test_summary
===================================================================
--- test_summary	(revision 146777)
+++ test_summary	(working copy)
@@ -1,6 +1,7 @@
 #! /bin/sh
 
-# (C) 1998, 1999, 2000, 2002 Free Software Foundation
+# (C) 1998, 1999, 2000, 2002, 2003, 2004, 2007, 2009
+# Free Software Foundation
 # Originally by Alexandre Oliva <oliva@dcc.unicamp.br>
 
 # This script is Free Software, and it can be copied, distributed and
@@ -106,9 +107,11 @@
     sub(/^s,@TOPLEVEL_CONFIGURE_ARGUMENTS@,/, "", configflags);
     srcdir = configflags;
     sub(/\/configure .*/, "", srcdir);
-    printf "LAST_UPDATED: ";
-    system("tail -1 " srcdir "/LAST_UPDATED");
-    print "";
+    if ( system("test -f " srcdir "/LAST_UPDATED") == 0 ) {
+        printf "LAST_UPDATED: ";
+        system("tail -1 " srcdir "/LAST_UPDATED");
+        print "";
+    }
 
     sub(/^[^ ]*\/configure */, " ", configflags);
     sub(/,;t t $/, " ", configflags);

Re: test_summary: Only include LAST_UPDATED if it exists.

[Hans-Peter Nilsson]

On Sat, 25 Apr 2009, Gerald Pfeifer wrote:
> I had a look at the
> source of gcc_update and don't see --touch modify LAST_UPDATED.

You're right, I missed the early returns there; all option uses
return early.

>  And
> I don't think it should?

I'd think 'svn update' + 'gcc_update --touch' = 'gcc_update'
so you can e.g. do an initial checkout and a 'gcc_update --touch'
and be all set for the initial run (using "gcc_update' for
subsequent updates).  But that might be just me.

brgds, H-P