From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12457 invoked by alias); 26 Apr 2009 20:21:11 -0000 Received: (qmail 12448 invoked by uid 22791); 26 Apr 2009 20:21:10 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Apr 2009 20:21:05 +0000 Received: from Relay2.suse.de (relay-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 1B1CC5FC9F; Sun, 26 Apr 2009 22:21:02 +0200 (CEST) Date: Sun, 26 Apr 2009 20:27:00 -0000 From: Michael Matz To: Andrew MacLeod Cc: gcc-patches@gcc.gnu.org, Andrey Belevantsev Subject: Re: [RFA] expand from SSA form (1/2) In-Reply-To: <49F07B6B.8040404@redhat.com> Message-ID: References: <49EE0F0C.1090101@redhat.com> <49F07B6B.8040404@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-04/txt/msg02054.txt.bz2 Hi, On Thu, 23 Apr 2009, Andrew MacLeod wrote: > Looks good to me. It's now in. > I do think this should be fixed in commit_edge_insertions and the common > code factored out and called from here, but that can be done separately. > Then commit_one_edge_insertion() could return to being a static function > as well. Yes, I plan to do that. There are also some other cleanups on the plate. > Im guessing current_ir_type() is not IR_RTL_CFGLAYOUT, or you could just > call commit_edge_insertions directly... No, unfortunately it's not. Ciao, Michael.