From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Cary Coutant <ccoutant@google.com>
Cc: Rafael Espindola <espindola@google.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Diego Novillo <dnovillo@google.com>
Subject: Re: [patch] Use LDPL_FATAL instead of assert
Date: Thu, 15 Oct 2009 21:54:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0910152144070.11613@digraph.polyomino.org.uk> (raw)
In-Reply-To: <c17be2b30910151441r62d348aes1da10d3300d86f6b@mail.gmail.com>
On Thu, 15 Oct 2009, Cary Coutant wrote:
> I was going to say that perhaps we should follow gold's standards for
> diagnostics instead, but this API is not intended to be specific to
> one particular host application, so it probably does make sense to
> conform to the same coding standards as the compiler itself.
And if gold is intended to be part of the GNU system, it should also be
following the standard formats, so "ld: error" or "ld:object-file: error"
or similar; when building a program, the diagnostics from compiler,
assembler and linker should all be following the uniform style. I'm
presuming that gold will add the "ld: " or similar part to the message
passed in from the plugin. (When the callback is missing, perhaps the
plugin should say "lto-plugin: " when sending the message to stderr
itself.)
Just looking at the gold source code, I don't see any obvious deviations
from the GNU style there, so there may not be a conflict of standards
anyway.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2009-10-15 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 18:41 Rafael Espindola
2009-10-15 21:10 ` Joseph S. Myers
2009-10-15 21:50 ` Cary Coutant
2009-10-15 21:54 ` Joseph S. Myers [this message]
2009-10-17 1:22 ` Ian Lance Taylor
2009-10-16 15:53 ` Rafael Espindola
2009-10-15 21:58 ` Cary Coutant
2009-10-15 23:24 ` Cary Coutant
2009-10-16 5:15 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0910152144070.11613@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=ccoutant@google.com \
--cc=dnovillo@google.com \
--cc=espindola@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).