From: Michael Matz <matz@suse.de>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Richard Guenther <richard.guenther@gmail.com>,
Ian Lance Taylor <iant@google.com>,
Uros Bizjak <ubizjak@gmail.com>,
gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: PATCH: PR target/40838: gcc shouldn't assume that the stack is aligned
Date: Tue, 20 Oct 2009 01:12:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0910200242370.15566@wotan.suse.de> (raw)
In-Reply-To: <6dc9ffc80910190921v60b58affw7d4c31fab4896648@mail.gmail.com>
Hi,
On Mon, 19 Oct 2009, H.J. Lu wrote:
> The issues are
>
> 1. The incoming stack alignment can't be changed after RTL expansion
> starts.
And that's the thing. Just move the prologue expansion to after the body
expansion (see cfgexpand.c) and you should be set. No doubt you'll hit
some ugly obstacles, but that should be the way forward.
> 2. When -mstackrealign is used, we want to use 4 byte incoming stack
> alignment on functions which use SSE vector insns.
> 3. SSE vector insns may be generated by intrinsics, vectorizer and
> vector operations.
All of these will be automatically taken care off when (1) is solved. I
really think it would be worth it. Fiddling with stack alignment in the
vectorizer (though that's the first alignment requirers you'll hit) is not
going to fly in the long run.
Ciao,
Michael.
next prev parent reply other threads:[~2009-10-20 0:48 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 21:42 H.J. Lu
2009-08-06 22:26 ` Jakub Jelinek
2009-08-06 22:52 ` H.J. Lu
2009-10-15 15:58 ` H.J. Lu
2009-10-15 18:45 ` Uros Bizjak
2009-10-15 19:22 ` H.J. Lu
2009-10-15 19:32 ` Uros Bizjak
2009-10-15 19:43 ` H.J. Lu
2009-10-15 19:48 ` Jakub Jelinek
2009-10-15 20:11 ` H.J. Lu
2009-10-15 19:53 ` Uros Bizjak
2009-10-15 21:01 ` H.J. Lu
2009-10-15 21:41 ` Uros Bizjak
2009-10-16 20:27 ` H.J. Lu
2009-10-17 1:03 ` Ian Lance Taylor
2009-10-17 18:22 ` H.J. Lu
2009-10-17 19:02 ` Richard Guenther
2009-10-17 19:21 ` H.J. Lu
2009-10-17 19:29 ` Richard Guenther
2009-10-17 19:35 ` H.J. Lu
2009-10-17 19:46 ` Richard Guenther
2009-10-17 20:01 ` H.J. Lu
2009-10-17 20:59 ` Richard Guenther
2009-10-18 19:21 ` Michael Matz
2009-10-18 19:45 ` Richard Guenther
2009-10-19 16:36 ` H.J. Lu
2009-10-20 1:12 ` Michael Matz [this message]
2009-10-20 19:10 ` H.J. Lu
2009-10-19 16:38 ` H.J. Lu
2009-10-19 17:08 ` Ian Lance Taylor
2009-10-19 17:26 ` H.J. Lu
2009-10-19 17:33 ` Ian Lance Taylor
2009-10-19 17:46 ` H.J. Lu
2009-10-19 17:55 ` Ian Lance Taylor
2009-10-19 19:16 ` H.J. Lu
2009-10-19 21:15 ` Ian Lance Taylor
2009-10-20 19:00 ` H.J. Lu
2009-10-20 1:23 ` Michael Matz
2009-10-20 19:12 ` H.J. Lu
2009-10-20 1:53 ` Michael Matz
2009-10-20 21:15 ` H.J. Lu
2009-10-21 1:10 ` H.J. Lu
2009-10-21 9:54 ` Michael Matz
2009-10-21 16:56 ` H.J. Lu
2009-10-30 10:08 ` Richard Guenther
2009-10-17 7:09 ` Uros Bizjak
2009-08-07 0:54 Mikulas Patocka
2009-08-07 7:13 ` Jakub Jelinek
2009-08-07 12:53 ` H.J. Lu
2009-08-07 22:30 ` H.J. Lu
2009-08-08 17:35 ` Mikulas Patocka
2009-08-16 21:25 ` H.J. Lu
2009-08-24 17:39 ` H.J. Lu
2009-09-12 23:32 ` Mikulas Patocka
2009-09-12 23:42 ` Mikulas Patocka
2009-09-13 1:55 ` H.J. Lu
2009-09-13 14:10 ` Mikulas Patocka
2009-08-07 21:08 ` Mikulas Patocka
2009-08-07 21:25 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0910200242370.15566@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=iant@google.com \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).