[gccgo] Use -static-libstdc++ when building the Go compiler

[gccgo] Use -static-libstdc++ when building the Go compiler

[Ian Lance Taylor]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

When bootstrapping gccgo, the Go compiler winds up being built with
the current version of libstdc++.  That makes it a pain to run if the
current version of libstdc++ is newer than the system version.
Fortunately I introduced the -static-libstdc++ option to avoid just
this issue for the build-with-cxx branch.  This patch uses the option,
if it is supported, when building the Go compiler.  Committed to gccgo
branch.

Ian



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: -static-libstdc++ --]
[-- Type: text/x-diff, Size: 1730 bytes --]

Index: go/Make-lang.in
===================================================================
--- go/Make-lang.in	(revision 154350)
+++ go/Make-lang.in	(working copy)
@@ -66,7 +66,7 @@ GO_OBJS = \
 	go/unsafe.o
 
 go1$(exeext): $(GO_OBJS) attribs.o $(BACKEND) $(LIBDEPS)
-	$(CXX) $(ALL_CXXFLAGS) $(LDFLAGS) -o $@ \
+	$(CXX) $(STATIC_LIBSTDCXX) $(ALL_CXXFLAGS) $(LDFLAGS) -o $@ \
 	      $(GO_OBJS) attribs.o $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 # Build hooks.
Index: configure.ac
===================================================================
--- configure.ac	(revision 154350)
+++ configure.ac	(working copy)
@@ -4118,6 +4118,22 @@ done
 # UNSORTED
 # --------
 
+# Test whether $CXX supports -static-libstdc++
+AC_CACHE_CHECK([whether $CXX supports -static-libstdc++],
+	gcc_cv_cxx_supports_static_libstdcxx,
+	[if $CXX -static-libstdc++ >/dev/null 2>&1 | 
+	    grep 'unrecognized option' >/dev/null; then
+	   gcc_cv_cxx_supports_static_libstdcxx=no
+	 else
+	   gcc_cv_cxx_supports_static_libstdcxx=yes
+	 fi])
+if test "$gcc_cv_cxx_supports_static_libstdcxx" = yes; then
+  STATIC_LIBSTDCXX=-static-libstdc++
+else
+  STATIC_LIBSTDCXX=
+fi
+AC_SUBST(STATIC_LIBSTDCXX)
+
 # Create .gdbinit.
 
 echo "dir ." > .gdbinit
Index: Makefile.in
===================================================================
--- Makefile.in	(revision 154350)
+++ Makefile.in	(working copy)
@@ -220,6 +220,10 @@ LINKER = $(CXX)
 LINKER_FLAGS = $(CXXFLAGS)
 endif
 
+# This is set by the configure script to be -static-libstdc++ if
+# $(CXX) supports the option.
+STATIC_LIBSTDCXX = @STATIC_LIBSTDCXX@
+
 # -------------------------------------------
 # Programs which operate on the build machine
 # -------------------------------------------

Re: [gccgo] Use -static-libstdc++ when building the Go compiler

[Joseph S. Myers]

On Fri, 20 Nov 2009, Ian Lance Taylor wrote:

> When bootstrapping gccgo, the Go compiler winds up being built with
> the current version of libstdc++.  That makes it a pain to run if the
> current version of libstdc++ is newer than the system version.
> Fortunately I introduced the -static-libstdc++ option to avoid just
> this issue for the build-with-cxx branch.  This patch uses the option,
> if it is supported, when building the Go compiler.  Committed to gccgo
> branch.

This should not override --with-host-libstdcxx (and my previous comments 
<http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01719.html> that C++ code 
should be linked with $(CC) in non-bootstrapped builds with 
--with-host-libstdcxx apply equally here as they do to building the whole 
compiler as C++ - i.e. things to get right before merging the Go compiler 
to trunk, or building the whole compiler as C++ by default).

-- 
Joseph S. Myers
joseph@codesourcery.com

Top-level build machinery patch ping (Was: Re: [gccgo] Use -static-libstdc++ when building the Go compiler)

[Ian Lance Taylor]

"Joseph S. Myers" <joseph@codesourcery.com> writes:

> On Fri, 20 Nov 2009, Ian Lance Taylor wrote:
>
>> When bootstrapping gccgo, the Go compiler winds up being built with
>> the current version of libstdc++.  That makes it a pain to run if the
>> current version of libstdc++ is newer than the system version.
>> Fortunately I introduced the -static-libstdc++ option to avoid just
>> this issue for the build-with-cxx branch.  This patch uses the option,
>> if it is supported, when building the Go compiler.  Committed to gccgo
>> branch.
>
> This should not override --with-host-libstdcxx (and my previous comments 
> <http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01719.html> that C++ code 
> should be linked with $(CC) in non-bootstrapped builds with 
> --with-host-libstdcxx apply equally here as they do to building the whole 
> compiler as C++ - i.e. things to get right before merging the Go compiler 
> to trunk, or building the whole compiler as C++ by default).

Speaking of your previous comments, I don't think anybody ever
reviewed 

http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01930.html

So: ping.

Ian

Re: Top-level build machinery patch ping (Was: Re: [gccgo] Use -static-libstdc++ when building the Go compiler)

[DJ Delorie]

> http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01930.html
> 
> So: ping.

Looks OK to me.

Re: Top-level build machinery patch ping (Was: Re: [gccgo] Use -static-libstdc++ when building the Go compiler)

[Paolo Bonzini]

On 11/21/2009 02:53 AM, DJ Delorie wrote:
>> http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01930.html
>>
>> So: ping.
>
> Looks OK to me.

Also looks OK to me, though I'm not sure if here:

+LINKER = $(CC)
+LINKER_FLAGS = $(CFLAGS)

you want $(CFLAGS) or $(CXXFLAGS) since you're using $(CC) only to avoid 
introducing -lstdc++.  But with DJ's approval you can commit it either way.

Paolo