From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Joern Rennecke <amylaar@spamcop.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFA: PR44566: accessor macros (2/3): machine_function
Date: Thu, 24 Jun 2010 12:26:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1006241123090.2149@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20100624064359.hs9ji2d0gkwg4w0s-nzlynne@webmail.spamcop.net>
I see nothing in this patch that defines EXTRA_TARGET, which would
indicate that the #ifdef EXTRA_TARGET stanza doesn't belong here.
You should use @code{MACHINE_FUNCTION (@var{function})} in tm.texi.
I think some people have expressed a dislike of svn:mergeinfo properties
referencing random branches being added to trunk. (Your patch has:
Property changes on: gcc/config
___________________________________________________________________
Added: svn:mergeinfo
Merged /branches/multi-target-20100613-branch/gcc/config:r160896
)
You should create target-gtypes.h under a temporary name, then rename it
once finished to the final target-gtypes.h name using move-if-change,
together with the use of a timestamp file as done for other such generated
files.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2010-06-24 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 11:32 Joern Rennecke
2010-06-24 12:26 ` Joseph S. Myers [this message]
2010-06-24 14:24 ` Joern Rennecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1006241123090.2149@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=amylaar@spamcop.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).