From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-270480-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10675 invoked by alias); 13 Aug 2010 17:02:14 -0000
Received: (qmail 10643 invoked by uid 22791); 13 Aug 2010 17:02:13 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Aug 2010 17:02:08 +0000
Received: (qmail 17387 invoked from network); 13 Aug 2010 17:02:06 -0000
Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 13 Aug 2010 17:02:06 -0000
Received: from jsm28 (helo=localhost)	by digraph.polyomino.org.uk with local-esmtp (Exim 4.69)	(envelope-from <joseph@codesourcery.com>)	id 1Ojxds-0002XQ-PN; Fri, 13 Aug 2010 17:02:04 +0000
Date: Fri, 13 Aug 2010 17:02:00 -0000
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Shujing Zhao <pearly.zhao@oracle.com>
cc: =?ISO-8859-1?Q?Fabien_Ch=EAne?= <fabien.chene@gmail.com>,     GCC Patches <gcc-patches@gcc.gnu.org>,     Paolo Carlini <paolo.carlini@oracle.com>
Subject: Re: [PATCH, C] Fix PR40563
In-Reply-To: <4C52A23B.6010408@oracle.com>
Message-ID: <Pine.LNX.4.64.1008131701530.7859@digraph.polyomino.org.uk>
References: <4C4664DB.6040902@oracle.com> <Pine.LNX.4.64.1007271354460.8014@digraph.polyomino.org.uk> <4C4FEC69.3090600@oracle.com> <AANLkTimETNFpNy=zkJO1+COjQnK87pS2NLG82V8wwYsx@mail.gmail.com> <4C52A23B.6010408@oracle.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-08/txt/msg01026.txt.bz2

On Fri, 30 Jul 2010, Shujing Zhao wrote:

> OK. Clear the comment of diagnose_uninitialized_cst_member.
> C_TYPE_FIELDS_READONLY is used before recursing the struct or union.
> Uninitialized array of structures would be diagnosed if one of members is
> const.
> The warned type is changed to "strip_array_types (TREE_TYPE (decl)", so that
> it would warn struct or union type, not the array.
> 
> The testcase is fixed to test the recursing and test the array of structure
> that has const member.
> 
> Tested on trunk and bootstraped.
> Is it ok?

This patch is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com