From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10682 invoked by alias); 15 Oct 2010 12:20:59 -0000 Received: (qmail 10659 invoked by uid 22791); 15 Oct 2010 12:20:51 -0000 X-SWARE-Spam-Status: No, hits=-3.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Oct 2010 12:20:46 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id D7A7C87D82; Fri, 15 Oct 2010 14:20:43 +0200 (CEST) Date: Fri, 15 Oct 2010 12:46:00 -0000 From: Michael Matz To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Subject: Re: PR testsuite/45621 (indirect inlining related cgraph verifier ICE) In-Reply-To: <20101015012325.GC15487@kam.mff.cuni.cz> Message-ID: References: <20101015012325.GC15487@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg01331.txt.bz2 Hello, On Fri, 15 Oct 2010, Jan Hubicka wrote: > + 2010-10-14 Jan Hubicka > + > + PR middle-end/45621 > + * cgraph.c (cgraph_update_edges_for_call_stmt_node): When new call is > + redirected to clone, be happy. > + * cgraph.h (cgraph node): Enable former_clone_of unconditinally. > + * cgraphunit.c (verify_cgraph_node, cgraph_materialize_clone): Handle > + former_clone_of unconditinally. With disable-checking this results in: libbackend.a(cgraphunit.o): In function `verify_cgraph_node': /gcc/spec/sb-frescobaldi.arch.suse.de-head-64/gcc/gcc/cgraphunit.c:659: undefined reference to `clone_of_p' for which I'm checking in the below as obvious. Ciao, Michael. -- * cgraphunit.c (clone_of_p): Define unconditionally. Index: cgraphunit.c =================================================================== --- cgraphunit.c (revision 165503) +++ cgraphunit.c (working copy) @@ -396,7 +396,6 @@ cgraph_mark_if_needed (tree decl) cgraph_mark_needed_node (node); } -#ifdef ENABLE_CHECKING /* Return TRUE if NODE2 is equivalent to NODE or its clone. */ static bool clone_of_p (struct cgraph_node *node, struct cgraph_node *node2) @@ -405,7 +404,6 @@ clone_of_p (struct cgraph_node *node, st node2 = node2->clone_of; return node2 != NULL; } -#endif /* Verify edge E count and frequency. */