From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6895 invoked by alias); 8 Dec 2010 16:55:52 -0000 Received: (qmail 6886 invoked by uid 22791); 8 Dec 2010 16:55:51 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Dec 2010 16:55:46 +0000 Received: (qmail 1111 invoked from network); 8 Dec 2010 16:55:45 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Dec 2010 16:55:45 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1PQNIt-0001za-O6; Wed, 08 Dec 2010 16:55:43 +0000 Date: Wed, 08 Dec 2010 17:28:00 -0000 From: "Joseph S. Myers" To: Thomas Schwinge cc: gcc-patches@gcc.gnu.org, maxim@codesourcery.com, thomas@schwinge.name Subject: Re: [PATCH] glibc / uclibc / bionic switch vs. non-Linux, GNU-based systems In-Reply-To: <87aakgnrbj.fsf@dirichlet.schwinge.homeip.net> Message-ID: References: <1291821876-23891-1-git-send-email-thomas@schwinge.name> <87aakgnrbj.fsf@dirichlet.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg00681.txt.bz2 On Wed, 8 Dec 2010, Thomas Schwinge wrote: > > This patch works by defining SINGLE_LIBC (along with DEFAULT_LIBC) for > > Why not just SINGLE_LIBC for (a) triggering this single libc case, and > (b) specifying which one to use? That is: Because of the existing conditionals defining CHOOSE_DYNAMIC_LINKER, users of linux.h need to define DEFAULT_LIBC anyway (see the definitions for various uClinux targets that I replaced by a single central definition for uClinux targets) and it seemed simplest to have a single macro specifying the default in all cases rather than different macros for the default in different cases. (I see the first definition of DEFAULT_LIBC in my patch is actually redundant with the one a few lines below case $target in *-*-*android*) tm_defines="$tm_defines DEFAULT_LIBC=LIBC_BIONIC" ;; *-*-*uclibc*) tm_defines="$tm_defines DEFAULT_LIBC=LIBC_UCLIBC" ;; *) tm_defines="$tm_defines DEFAULT_LIBC=LIBC_GLIBC" ;; esac so reviewers should feel free to review my patch on the basis of the duplicate being removed, i.e. - tm_defines="$tm_defines OPTION_GLIBC=1";; + tm_defines="$tm_defines DEFAULT_LIBC=LIBC_GLIBC SINGLE_LIBC";; being changed to - tm_defines="$tm_defines OPTION_GLIBC=1";; + tm_defines="$tm_defines SINGLE_LIBC";; .) -- Joseph S. Myers joseph@codesourcery.com