From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Sumanth Gundapaneni <Sumanth.Gundapaneni@kpitcummins.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Jayant R. Sonar" <Jayant.Sonar@kpitcummins.com>
Subject: Re: CR16 Port addition
Date: Wed, 22 Dec 2010 13:25:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1012221149510.4347@digraph.polyomino.org.uk> (raw)
In-Reply-To: <371569CBCFB2E745B891DBB88B2DFDDD19EA62912D@KCINPUNHJCMS01.kpit.com>
On Wed, 22 Dec 2010, Sumanth Gundapaneni wrote:
> * config/cr16/cr16-libgcc.s: New file.
Files built for the target need to have the exception wording referencing
COPYING.RUNTIME, not no exception as here ...
> * config/cr16/crti.s: New file.
... or the old GPLv2 exception as here. Please check all libgcc sources
in this patch for appropriate license exception wording.
In general, if possible files built for the target should be under
libgcc/config not gcc/config with makefile rules under libgcc/config as
well. At least crt* files can probably go there.
> * config/cr16/unwind-dw2-cr16.c: New file.
> * config/cr16/unwind-dw2.h: New file.
Could you clarify how these source files are related to the main
target-independent unwind-dw2* files, and, if they are based on them in
some way, why you need a target-specific version, how you have kept it up
to date with all changes to the target-independent version since you first
forked it, and how you plan to keep it up to date in future?
> 2010-12-21 Sumanth G <sumanth.gundapaneni@kpitcummins.com>
> Jayant R Sonar <jayant.sonar@kpitcummins.com>
>
> * config.sub: Add National Semiconductor CR16 target.
No, never send such a patch to gcc-patches. Any such changes must go to
config-patches (preferably against the latest config.git, including
testcases). Once they are in config.git, you can import the latest
versions of config.sub and config.guess into the gcc and src repositories
without needing separate approval - but the only changes to those files in
GCC should be imports of unmodified versions from config.git; GCC should
not have any local changes, and the GCC and src repositories should be
kept in sync.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2010-12-22 11:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 11:58 Sumanth Gundapaneni
2010-12-22 13:25 ` Joseph S. Myers [this message]
2010-12-29 15:32 ` Sumanth Gundapaneni
2011-01-13 9:06 Sumanth Gundapaneni
2011-01-14 18:54 ` Richard Henderson
2011-04-08 13:26 Sumanth Gundapaneni
2011-04-08 14:56 ` Joseph S. Myers
2011-05-20 13:59 ` Sumanth Gundapaneni
2011-05-20 17:07 ` Joseph S. Myers
2011-05-30 15:44 ` Sumanth Gundapaneni
2011-06-09 10:15 ` Sumanth Gundapaneni
2011-06-28 8:32 ` Sumanth Gundapaneni
2011-07-15 7:54 ` Sumanth Gundapaneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1012221149510.4347@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Jayant.Sonar@kpitcummins.com \
--cc=Sumanth.Gundapaneni@kpitcummins.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).