From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14368 invoked by alias); 11 Mar 2011 13:01:53 -0000 Received: (qmail 14349 invoked by uid 22791); 11 Mar 2011 13:01:52 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 13:01:46 +0000 Received: (qmail 14330 invoked from network); 11 Mar 2011 13:01:44 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Mar 2011 13:01:44 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1Py1yQ-000303-Se; Fri, 11 Mar 2011 13:01:42 +0000 Date: Fri, 11 Mar 2011 13:01:00 -0000 From: "Joseph S. Myers" To: Nathan Froyd cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler In-Reply-To: <1299817406-16745-8-git-send-email-froydnj@codesourcery.com> Message-ID: References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-8-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00589.txt.bz2 On Thu, 10 Mar 2011, Nathan Froyd wrote: > This patch does lose location information on CASE_LABEL_EXPRs from the C > family of front-ends; it did not seem worth it to have a number of > places pass input_location when said information isn't even used. I'm > happy to add the location_t argument back to CASE_LABEL_EXPRs if people > think that's worthwhile. Since implicit use of input_location is deprecated and should be being phased out (making more locations explicit - including explicit input_location until the places using it have a better location available), I think you should keep the location argument. The C front-end changes in this patch series (including c-family changes) are otherwise OK. -- Joseph S. Myers joseph@codesourcery.com