From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13778 invoked by alias); 18 Mar 2011 18:39:48 -0000 Received: (qmail 13768 invoked by uid 22791); 18 Mar 2011 18:39:47 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_CD,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 18:39:42 +0000 Received: (qmail 26113 invoked from network); 18 Mar 2011 18:39:40 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Mar 2011 18:39:40 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1Q0eaI-0000R1-Tn; Fri, 18 Mar 2011 18:39:38 +0000 Date: Fri, 18 Mar 2011 18:39:00 -0000 From: "Joseph S. Myers" To: Richard Guenther cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][C] Fix PR47939 In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg01132.txt.bz2 On Fri, 18 Mar 2011, Richard Guenther wrote: > > What I think is safe in grokdeclarator is using TYPE_MAIN_VARIANT here if > > *either* the type given in the declaration specifiers is an array type > > (TREE_CODE (type) == ARRAY_TYPE, as in your previous patch) *or* the first > > declarator that is not cdk_attrs is cdk_array (as in this version, but > > checking through a chain of declarator->declarator to find a possible > > cdk_array after a sequence of cdk_attrs). > > > > (Aside from all this it is a longstanding known bug that the debug > > information for arrays of qualified types isn't quite right: PR 8354.) > > Ok, the following works for me. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, ok for trunk? This patch version is OK. -- Joseph S. Myers joseph@codesourcery.com