public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Matz <matz@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, law@redhat.com
Subject: Re: Fix PR48389: ICE in make_edges
Date: Fri, 08 Apr 2011 13:59:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1104081549350.1989@wotan.suse.de> (raw)
In-Reply-To: <20110408133729.GT17079@tyan-ft48-01.lab.bos.redhat.com>

Hi,

On Fri, 8 Apr 2011, Jakub Jelinek wrote:

> On Fri, Apr 08, 2011 at 03:33:49PM +0200, Michael Matz wrote:
> > --- testsuite/gcc.target/i386/pr48389.c	(revision 0)
> > +++ testsuite/gcc.target/i386/pr48389.c	(revision 0)
> > @@ -0,0 +1,12 @@
> > +/* PR middle-end/48389 */
> > +/* { dg-do compile } */
> > +/* { dg-options "-O -m32 -mtune=pentiumpro -Wno-abi" } */
> 
> -m32/-m64 should never go into dg-options.  Either do something like:
> /* { dg-options "-O" } */
> /* { dg-options "-O -mtune=pentiumpro -Wno-abi" { target ilp32 } } */
> or remove -m32 from dg-options and conditionalize dg-do compile on ilp32
> target.

But then I'd have to use --target_board to hit the original problem.  
Can't I somehow make it so that independend of the target_board setting 
32bit code is generated (possibly only when the compiler supports it)?
If it's not possible consider the testcase to be adjusted like below.


Ciao,
Michael.
-- 
/* PR middle-end/48389 */
/* { dg-do compile } */
/* { dg-options "-O -mtune=pentiumpro -Wno-abi" } */
/* { dg-require-effective-target ilp32 } */
typedef float V2SF __attribute__ ((vector_size (128)));
V2SF foo (int x, V2SF a)
{
  V2SF b = {};
  if (x & 42)
    b = a;
  a += b;
  return a;
}

  reply	other threads:[~2011-04-08 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 13:33 Michael Matz
2011-04-08 13:37 ` Jakub Jelinek
2011-04-08 13:59   ` Michael Matz [this message]
2011-04-08 14:03     ` Jakub Jelinek
2011-04-08 14:55     ` H.J. Lu
2011-04-08 15:04 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1104081549350.1989@wotan.suse.de \
    --to=matz@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).