From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25452 invoked by alias); 10 Apr 2011 19:28:29 -0000 Received: (qmail 25442 invoked by uid 22791); 10 Apr 2011 19:28:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 10 Apr 2011 19:28:25 +0000 Received: (qmail 19019 invoked from network); 10 Apr 2011 19:28:23 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Apr 2011 19:28:23 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1Q90J3-0003vA-Ix; Sun, 10 Apr 2011 19:28:21 +0000 Date: Sun, 10 Apr 2011 19:28:00 -0000 From: "Joseph S. Myers" To: Jim Meyering cc: gcc-patches@gcc.gnu.org Subject: Re: doubled words In-Reply-To: <87wrj2nwxq.fsf@rho.meyering.net> Message-ID: References: <87wrj2nwxq.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00716.txt.bz2 On Sun, 10 Apr 2011, Jim Meyering wrote: > I would be inclined to prepare a patch if I thought it would > be applied (promptly?), but I submitted a clear/simple fix for > an obvious double-free bug (albeit only in a test case) a month ago: > > http://patchwork.ozlabs.org/patch/85973/ > avoid memory overrun in a test leading to potential double-free > * testsuite/test-expandargv.c (writeout_test): Fix off-by-one error: > i.e., do copy the trailing NUL byte. > > AFAIK, it hasn't been applied. If a "real" bug has such low priority, > this is not a good time to submit a clean-up change. Please ping unreviewed (or approved but not committed) patches at least weekly, as many times as needed. If a patch isn't reviewed within a week, it's unlikely to be reviewed without a ping. (Actually I suspect the vast bulk of reviews are within two or three days.) -- Joseph S. Myers joseph@codesourcery.com