From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18374 invoked by alias); 26 Apr 2011 15:57:26 -0000 Received: (qmail 18346 invoked by uid 22791); 26 Apr 2011 15:57:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Apr 2011 15:57:10 +0000 Received: (qmail 22873 invoked from network); 26 Apr 2011 15:57:10 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Apr 2011 15:57:10 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QEkdQ-0003dA-T2; Tue, 26 Apr 2011 15:57:08 +0000 Date: Tue, 26 Apr 2011 16:48:00 -0000 From: "Joseph S. Myers" To: Nick Clifton cc: gcc-patches@gcc.gnu.org, law@redhat.com, aoliva@redhat.com Subject: Re: Ping^3 Re: Target header etc. cleanup patch In-Reply-To: <4DB6E98B.3080601@redhat.com> Message-ID: References: <4DB6E98B.3080601@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02052.txt.bz2 On Tue, 26 Apr 2011, Nick Clifton wrote: > Similarly it would be nice to standard abbreviations for CUMULATIVE_ARGS, enum > rtx_code, enum reg_class and const char *. What do you think ? I suspect I think defining an abbreviation for const char * is actively bad, since const char * is a standard C idiom as-is and inventing local names for something with a standard C name should be avoided unless you are genuinely adding GCC-specific semantics. (Yes, HOST_WIDEST_INT ought to be replaced by intmax_t/uintmax_t.) My position on CUMULATIVE_ARGS remains that this type should become private to each back end and not visible in any code outside of config/ - with dynamic conversions from a target-independent type being used by the affected hooks. (See PR 46500.) Once the type is private to the back ends, they can also use a name other than CUMULATIVE_ARGS if they wish - but a typedef rather than a #define, please. -- Joseph S. Myers joseph@codesourcery.com