From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Cary Coutant <ccoutant@google.com>
Cc: reply@codereview.appspotmail.com, jason@redhat.com,
gcc-patches@gcc.gnu.org
Subject: Re: [patch] Add new -gmlt option for min. debug info with line tables (issue4440072)
Date: Wed, 27 Apr 2011 12:16:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1104271006090.9051@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20110426224430.D1BC8481B3@thebrac.mtv.corp.google.com>
On Tue, 26 Apr 2011, Cary Coutant wrote:
> @@ -1856,6 +1871,8 @@ set_debug_level (enum debug_info_type type, int extended, const char *arg,
> else
> opts->x_debug_info_level = (enum debug_info_levels) argval;
> }
> +
> + generate_debug_line_table = debug_info_level >= DINFO_LEVEL_NORMAL;
set_debug_level should not use global state; this needs to check
opts->x_debug_info_level (not the global debug_info_level) and set
opts->x_generate_debug_line_table.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-04-27 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 23:04 Cary Coutant
2011-04-26 23:06 ` Andrew Pinski
2011-04-26 23:09 ` Cary Coutant
2011-04-26 23:37 ` Andrew Pinski
2011-04-26 23:45 ` Cary Coutant
2011-05-03 20:28 ` Jason Merrill
2011-05-06 17:57 ` Cary Coutant
2011-05-09 22:25 ` Jim Wilson
2011-04-27 12:16 ` Joseph S. Myers [this message]
2011-04-27 18:13 ` Cary Coutant
2011-04-27 20:33 ` Cary Coutant
2011-04-29 20:49 ` [google][patch] " Cary Coutant
2011-04-29 20:57 ` Diego Novillo
2011-04-30 3:47 ` Cary Coutant
2011-04-29 20:56 ` [patch] " Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1104271006090.9051@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=ccoutant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).