From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3970 invoked by alias); 4 May 2011 11:56:51 -0000 Received: (qmail 3959 invoked by uid 22791); 4 May 2011 11:56:49 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 11:56:29 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 890CC5362F; Wed, 4 May 2011 13:56:28 +0200 (CEST) Date: Wed, 04 May 2011 12:00:00 -0000 From: Michael Matz To: Richard Guenther Cc: Eric Botcazou , gcc-patches@gcc.gnu.org, Xinliang David Li , Jan Hubicka Subject: Re: [google]: initialize language field for clone function struct In-Reply-To: Message-ID: References: <201105041200.29307.ebotcazou@adacore.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="168427776-193199943-1304510187=:1989" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00283.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --168427776-193199943-1304510187=:1989 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT Content-length: 697 Hi, On Wed, 4 May 2011, Richard Guenther wrote: > > It prevents save_expr from being called at global level, since you > > cannot create SAVE_EXPRs outside functions.  Likewise in > > variable_size. > > I see several places in fold-const.c that are not properly guarded then. > But anyway, if it is supposed to protect SAVE_EXPRs then I'd have > expected save_expr to contain that check and possibly return NULL if it > can't save. > > And I'm not sure you can't do SAVE_EXPRs outside of functions - you > could simply emit global temporaries. It's not the temporary, but the evaluation that poses problems in global context. (you could add a global ctor to it, ugh) Ciao, Michael. --168427776-193199943-1304510187=:1989--