From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Guozhi Wei <carrot@google.com>
Cc: reply@codereview.appspotmail.com, dougkwan@google.com,
jingyu@google.com, gcc-patches@gcc.gnu.org
Subject: Re: [google] Disable getpagesize() for Android toolchain (issue4515131)
Date: Tue, 24 May 2011 12:37:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1105241116440.4054@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20110524093904.2498F2072D@guozhiwei.sha.corp.google.com>
On Tue, 24 May 2011, Guozhi Wei wrote:
> Index: getpagesize.c
> ===================================================================
> --- getpagesize.c (revision 174099)
> +++ getpagesize.c (working copy)
> @@ -60,11 +60,13 @@ BUGS
> # endif /* PAGESIZE */
> #endif /* GNU_OUR_PAGESIZE */
>
> +#if DEFAULT_LIBC != LIBC_BIONIC
This makes no sense to me. getpagesize.c is in libiberty. libiberty does
not include any GCC-specific headers - and in particular, does not include
tm.h, which is where the definitions of DEFAULT_LIBC and LIBC_BIONIC would
come from (via tm_defines in config.gcc).
(In any case, I thought it was now accepted that libiberty should stop
being built for the target, and obviously it doesn't make sense for this
particular host-side functionality to depend on what the target is.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-05-24 11:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 11:45 Guozhi Wei
2011-05-24 12:37 ` Joseph S. Myers [this message]
2011-05-24 19:23 ` Doug Kwan (關振德)
2011-05-26 4:23 ` Jing Yu
2011-05-26 6:20 ` Doug Kwan (關振德)
2011-05-26 8:58 ` Jing Yu
2011-05-26 12:42 ` Joseph S. Myers
2011-05-27 4:01 ` Jing Yu
2011-05-27 4:02 ` Andrew Pinski
2011-05-26 9:56 ` Carrot Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1105241116440.4054@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carrot@google.com \
--cc=dougkwan@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jingyu@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).